Page MenuHomePhabricator

Modularize transactions for Almanac Device
ClosedPublic

Authored by epriestley on Apr 10 2018, 3:43 PM.
Tags
None
Referenced Files
F14840433: D19329.diff
Sat, Feb 1, 6:11 AM
Unknown Object (File)
Tue, Jan 28, 3:42 AM
Unknown Object (File)
Sat, Jan 25, 11:10 AM
Unknown Object (File)
Sat, Jan 25, 1:02 AM
Unknown Object (File)
Sat, Jan 25, 1:02 AM
Unknown Object (File)
Sat, Jan 25, 1:02 AM
Unknown Object (File)
Sat, Jan 18, 2:57 AM
Unknown Object (File)
Wed, Jan 15, 1:16 AM
Subscribers
None

Details

Summary

Depends on D19328. Ref T13120. Ref T12414.

Prior work has left us with just a NAME transaction here, which is straightforward to modularize.

Test Plan
  • Created and renamed devices.
  • Tried to set no name, a bad name, a duplicate name (got errors).
  • Tried to create/rename into a namespace I could not edit (got an error).
  • Grepped for AlmanacDeviceTransaction::.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable