Page MenuHomePhabricator

Modularize transactions for Almanac Device
ClosedPublic

Authored by epriestley on Apr 10 2018, 3:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 9, 6:28 PM
Unknown Object (File)
Mon, Dec 9, 6:28 PM
Unknown Object (File)
Mon, Dec 9, 6:23 PM
Unknown Object (File)
Mon, Dec 9, 5:50 PM
Unknown Object (File)
Mon, Dec 9, 1:55 PM
Unknown Object (File)
Mon, Dec 2, 11:19 PM
Unknown Object (File)
Mon, Dec 2, 11:19 PM
Unknown Object (File)
Mon, Dec 2, 12:50 PM
Subscribers
None

Details

Summary

Depends on D19328. Ref T13120. Ref T12414.

Prior work has left us with just a NAME transaction here, which is straightforward to modularize.

Test Plan
  • Created and renamed devices.
  • Tried to set no name, a bad name, a duplicate name (got errors).
  • Tried to create/rename into a namespace I could not edit (got an error).
  • Grepped for AlmanacDeviceTransaction::.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable