Page MenuHomePhabricator

Modularize transactions for Almanac Device
ClosedPublic

Authored by epriestley on Apr 10 2018, 3:43 PM.
Tags
None
Referenced Files
F18804331: D19329.id46270.diff
Sat, Oct 18, 7:22 AM
F18802388: D19329.id46236.diff
Fri, Oct 17, 6:45 PM
F18772704: D19329.id46270.diff
Thu, Oct 9, 4:00 AM
F18744936: D19329.diff
Fri, Oct 3, 4:43 AM
F18737712: D19329.diff
Wed, Oct 1, 12:12 PM
F18701165: D19329.diff
Sat, Sep 27, 5:45 PM
F18588505: D19329.diff
Sep 12 2025, 12:30 AM
F18509542: D19329.id.diff
Sep 5 2025, 3:27 AM
Subscribers
None

Details

Summary

Depends on D19328. Ref T13120. Ref T12414.

Prior work has left us with just a NAME transaction here, which is straightforward to modularize.

Test Plan
  • Created and renamed devices.
  • Tried to set no name, a bad name, a duplicate name (got errors).
  • Tried to create/rename into a namespace I could not edit (got an error).
  • Grepped for AlmanacDeviceTransaction::.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable