Page MenuHomePhabricator

Modularize transactions for Almanac Device
ClosedPublic

Authored by epriestley on Apr 10 2018, 3:43 PM.
Tags
None
Referenced Files
F19791802: D19329.id.diff
Wed, Feb 25, 11:34 PM
F19787443: D19329.id46236.diff
Wed, Feb 25, 1:42 PM
F19454674: D19329.id46236.diff
Dec 31 2025, 1:51 AM
F19243666: D19329.diff
Dec 22 2025, 12:43 AM
F19152105: D19329.id46236.diff
Dec 11 2025, 12:39 AM
F19111682: D19329.id46236.diff
Dec 9 2025, 4:43 PM
F19090547: D19329.diff
Dec 3 2025, 12:04 PM
F18998066: D19329.diff
Nov 20 2025, 5:17 PM
Subscribers
None

Details

Summary

Depends on D19328. Ref T13120. Ref T12414.

Prior work has left us with just a NAME transaction here, which is straightforward to modularize.

Test Plan
  • Created and renamed devices.
  • Tried to set no name, a bad name, a duplicate name (got errors).
  • Tried to create/rename into a namespace I could not edit (got an error).
  • Grepped for AlmanacDeviceTransaction::.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable