Page MenuHomePhabricator

Allow "drydock.blueprint.edit" to create blueprints
ClosedPublic

Authored by epriestley on Dec 26 2017, 6:24 PM.
Tags
None
Referenced Files
F14827386: D18849.id45228.diff
Wed, Jan 29, 5:45 AM
F14826904: D18849.diff
Wed, Jan 29, 2:46 AM
Unknown Object (File)
Tue, Jan 28, 2:56 AM
Unknown Object (File)
Fri, Jan 24, 10:58 PM
Unknown Object (File)
Fri, Jan 24, 10:57 PM
Unknown Object (File)
Fri, Jan 24, 10:57 PM
Unknown Object (File)
Fri, Jan 24, 8:09 AM
Unknown Object (File)
Tue, Jan 21, 12:08 PM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D18848. Ref PHI243. This puts a bit of logic up front to figure out the blueprint type before we actually start editing it.

This implementation is a little messy but it keeps the API clean. Eventually, the implementation could probably go in the TransactionTypes so more code is shared, but I'd like to wait for a couple more of these first.

This capability probably isn't too useful, but just pays down a bit of technical debt from the caveat introduced in D18822.

Test Plan
  • Created a new blueprint with the API.
  • Tried to create a blueprint without a "type" (got a helpful error).
  • Created and edited blueprints via the web UI.
  • Tried to change the "type" of an existing blueprint (got a helpful error).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Dec 26 2017, 6:24 PM
This revision is now accepted and ready to land.Jan 2 2018, 7:03 PM
This revision was automatically updated to reflect the committed changes.