Page MenuHomePhabricator

Allow "drydock.blueprint.edit" to create blueprints
ClosedPublic

Authored by epriestley on Dec 26 2017, 6:24 PM.
Tags
None
Referenced Files
F14054612: D18849.diff
Sat, Nov 16, 3:21 AM
F14042487: D18849.diff
Tue, Nov 12, 3:50 AM
F14038587: D18849.id45228.diff
Mon, Nov 11, 12:29 AM
F14027431: D18849.diff
Fri, Nov 8, 7:10 AM
F13986807: D18849.id45228.diff
Mon, Oct 21, 5:41 AM
F13966573: D18849.id.diff
Oct 16 2024, 8:34 AM
Unknown Object (File)
Oct 1 2024, 3:20 AM
Unknown Object (File)
Sep 21 2024, 2:32 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D18848. Ref PHI243. This puts a bit of logic up front to figure out the blueprint type before we actually start editing it.

This implementation is a little messy but it keeps the API clean. Eventually, the implementation could probably go in the TransactionTypes so more code is shared, but I'd like to wait for a couple more of these first.

This capability probably isn't too useful, but just pays down a bit of technical debt from the caveat introduced in D18822.

Test Plan
  • Created a new blueprint with the API.
  • Tried to create a blueprint without a "type" (got a helpful error).
  • Created and edited blueprints via the web UI.
  • Tried to change the "type" of an existing blueprint (got a helpful error).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Dec 26 2017, 6:24 PM
This revision is now accepted and ready to land.Jan 2 2018, 7:03 PM
This revision was automatically updated to reflect the committed changes.