Page MenuHomePhabricator
Differential D19356

Give getAlmanacServiceURI() an "options" parameter to prepare for read-only devices
ClosedPublic
Actions

Authored by epriestley on Apr 12 2018, 8:59 PM.
Tags
None
Referenced Files
F18822283: D19356.diff
Thu, Oct 23, 5:34 AM
F18816897: D19356.diff
Tue, Oct 21, 10:21 AM
F18813006: D19356.id.diff
Mon, Oct 20, 1:27 PM
F18808949: D19356.diff
Sun, Oct 19, 9:54 AM
F18788049: D19356.id.diff
Wed, Oct 15, 2:37 AM
F18746465: D19356.id46305.diff
Fri, Oct 3, 12:31 PM
F18614813: D19356.id.diff
Sep 14 2025, 1:12 PM
F18600436: D19356.diff
Sep 13 2025, 9:44 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T10883: Allow repository cluster nodes to be read-only
T13120: Plans: 2018 Week 15 Bonus Content
Commits
rP7c7e6d555b3f: Give getAlmanacServiceURI() an "options" parameter to prepare for read-only…
Summary

Depends on D19355. Ref T10883. Ref T13120. Rather than adding a million parameters here, wrap the selector-parameters in an $options.

The next change adds a new "writable" option to support forcing selection of writable hosts.

Test Plan

Pulled and pushed via HTTP and SSH, viewed repositories via Diffusion.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
8 lines
ssh/
6 lines
repository/
storage/
24 lines

Diff 46315

View Options

src/applications/diffusion/controller/DiffusionServeController.php

Loading...
View Options

src/applications/diffusion/ssh/DiffusionSSHWorkflow.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
Phabricator · Built by Phacility