Paths

Table of Contentst

Differential D19356

Give getAlmanacServiceURI() an "options" parameter to prepare for read-only devices
ClosedPublic
Actions

Authored by epriestley on Apr 12 2018, 8:59 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T10883: Allow repository cluster nodes to be read-only
T13120: Plans: 2018 Week 15 Bonus Content

Commits

rP7c7e6d555b3f: Give getAlmanacServiceURI() an "options" parameter to prepare for read-only…

Summary

Depends on D19355. Ref T10883. Ref T13120. Rather than adding a million parameters here, wrap the selector-parameters in an $options.

The next change adds a new "writable" option to support forcing selection of writable hosts.

Test Plan

Pulled and pushed via HTTP and SSH, viewed repositories via Diffusion.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 12 2018, 8:59 PM

Harbormaster completed remote builds in B20122: Diff 46305.Apr 12 2018, 9:01 PM

epriestley requested review of this revision.Apr 12 2018, 9:01 PM

amckinley accepted this revision.Apr 12 2018, 9:03 PM

This revision is now accepted and ready to land.Apr 12 2018, 9:03 PM

epriestley added a child revision: D19357: Allow repository cluster bindings to be marked as not "writable", making them read-only.Apr 12 2018, 9:08 PM

Closed by commit rP7c7e6d555b3f: Give getAlmanacServiceURI() an "options" parameter to prepare for read-only… (authored by epriestley). · Explain WhyApr 12 2018, 11:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionServeController.php

8 lines

ssh/

DiffusionSSHWorkflow.php

6 lines

repository/

storage/

PhabricatorRepository.php

24 lines

Diff 46315

View Options

src/applications/diffusion/controller/DiffusionServeController.php

View Options

src/applications/diffusion/ssh/DiffusionSSHWorkflow.php

View Options

src/applications/repository/storage/PhabricatorRepository.php

Give getAlmanacServiceURI() an "options" parameter to prepare for read-only devicesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46315

src/applications/diffusion/controller/DiffusionServeController.php

src/applications/diffusion/ssh/DiffusionSSHWorkflow.php

src/applications/repository/storage/PhabricatorRepository.php

Give getAlmanacServiceURI() an "options" parameter to prepare for read-only devices
ClosedPublic
Actions

Revision Contents
Changeset List