Page MenuHomePhabricator

Make various small quality-of-life improvements for Almanac properties
ClosedPublic

Authored by epriestley on Apr 11 2018, 3:41 PM.
Tags
None
Referenced Files
F15541415: D19342.id46280.diff
Fri, Apr 25, 11:50 AM
F15539380: D19342.id46253.diff
Fri, Apr 25, 1:24 AM
F15535953: D19342.id46280.diff
Thu, Apr 24, 7:49 AM
F15531547: D19342.id.diff
Wed, Apr 23, 11:53 AM
F15529582: D19342.diff
Tue, Apr 22, 8:58 PM
F15477978: D19342.id46253.diff
Mon, Apr 7, 7:20 PM
F15477259: D19342.id46253.diff
Mon, Apr 7, 1:09 PM
F15415950: D19342.id46280.diff
Mar 20 2025, 8:31 AM
Subscribers
None

Details

Summary

Depends on D19341. Ref T12414. Ref T13120.

  • Fix a bug where default-valued properties didn't get rendered in grey as they're supposed to (as a hint that the value isn't customized).
  • When resetting a builtin property won't do anything, visually disable the button as a hint.
  • Allow Services to specify properties on their Bindings.
  • Specify that repository bindings have a "protocol" property, so it becomes an explicit thing in the UI. Previously, you had to read the documentation to figure this out.
  • When editing bindings, use the EditField and its configuration if possible. This turns the "Protocol" property into a dropdown in the UI where you select between "http", "https" and "ssh".
  • Give the "protocol" binding a smart default based on the port number of the corresponding interface.
Test Plan
  • Viewed properties on Services, Devices and Bindings.
  • Saw them render sensibly, and grey out + grey button when a builtin value has a default setting.
  • Saw "Protocol" appear as a default property on repository cluster bindings and get a smart value.
  • Edited "protocol", got a nice dropdown.

Screen Shot 2018-04-11 at 8.26.16 AM.png (222×1 px, 23 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable