Page MenuHomePhabricator

Respect external unmentionable PHIDs in Differential revision editor
ClosedPublic

Authored by epriestley on Apr 12 2018, 10:03 PM.
Tags
None
Referenced Files
F15466934: D19361.diff
Thu, Apr 3, 10:59 AM
F15450098: D19361.diff
Fri, Mar 28, 1:55 PM
F15445654: D19361.id.diff
Thu, Mar 27, 3:16 PM
F15440253: D19361.id46312.diff
Wed, Mar 26, 11:40 AM
F15436868: D19361.id46312.diff
Tue, Mar 25, 4:41 PM
F15427023: D19361.diff
Sun, Mar 23, 12:14 PM
F15409515: D19361.diff
Wed, Mar 19, 4:38 AM
F15377278: D19361.diff
Thu, Mar 13, 8:31 AM
Subscribers
None

Details

Summary

See PHI574. Ref T13120. When you Ref Txx or Fixes Txxx, we mark it "unmentionable" to prevent the task from generating both a reference and a mention.

If you add a reference to an object (like a commit hash) to a custom remarkup field, there's currently no real way to prevent it from generating a mention, except that you can explicitly mark the PHID as unmentionable on the Editor.

This isn't exactly a first-class feature, but we technically do it in PhabricatorRepositoryCommitMessageParserWorker, and it probably doesn't hurt or interfere with anything to support it slightly better.

In Differential, respect any existing value and append new values to it rather than overwriting the value.

Test Plan

Edited a revision summary to include Ref Txxx, saw only a reference (not a mention) generate.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable