Page MenuHomePhabricator

Respect external unmentionable PHIDs in Differential revision editor
ClosedPublic

Authored by epriestley on Apr 12 2018, 10:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 6, 4:05 PM
Unknown Object (File)
Mon, Jun 2, 1:33 PM
Unknown Object (File)
Sat, May 31, 8:21 AM
Unknown Object (File)
Apr 26 2025, 3:02 PM
Unknown Object (File)
Apr 12 2025, 3:07 PM
Unknown Object (File)
Apr 12 2025, 2:37 PM
Unknown Object (File)
Apr 11 2025, 3:57 PM
Unknown Object (File)
Apr 11 2025, 11:05 AM
Subscribers
None

Details

Summary

See PHI574. Ref T13120. When you Ref Txx or Fixes Txxx, we mark it "unmentionable" to prevent the task from generating both a reference and a mention.

If you add a reference to an object (like a commit hash) to a custom remarkup field, there's currently no real way to prevent it from generating a mention, except that you can explicitly mark the PHID as unmentionable on the Editor.

This isn't exactly a first-class feature, but we technically do it in PhabricatorRepositoryCommitMessageParserWorker, and it probably doesn't hurt or interfere with anything to support it slightly better.

In Differential, respect any existing value and append new values to it rather than overwriting the value.

Test Plan

Edited a revision summary to include Ref Txxx, saw only a reference (not a mention) generate.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable