Page MenuHomePhabricator

Fix the legacy "25, 50, 100, unlimited" Harbormaster log links to respect generation selection
ClosedPublic

Authored by epriestley on Apr 13 2018, 1:50 PM.

Details

Summary

See PHI565. Ref T13120. Although this older log is on the chopping block (see T13088), there's some migration guidance and other complexity around just replacing it.

Until it gets replaced, make clicking the "number of lines" elements respect the current "Build Generation" setting. Prior to this change, clicking the links would lose the generation information and jump you to the most recent build generation.

Also fix some collateral damage from T13105 where we ended up with white text on a white background in some cases.

Test Plan
  • Restarted a build to get multiple generations.
  • On each generation, clicked the various "25", "50", etc., links.
  • Saw generation and log window sizes both respected by the links.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable