Page MenuHomePhabricator

Remove TYPE_INTERFACE transaction from Almanac Device
ClosedPublic

Authored by epriestley on Apr 10 2018, 3:27 PM.
Tags
None
Referenced Files
F13051666: D19328.id46269.diff
Fri, Apr 19, 3:41 AM
F13050405: D19328.diff
Fri, Apr 19, 2:52 AM
Unknown Object (File)
Sat, Mar 30, 4:42 PM
Unknown Object (File)
Sat, Mar 30, 4:41 PM
Unknown Object (File)
Sat, Mar 30, 4:41 PM
Unknown Object (File)
Sat, Mar 30, 4:41 PM
Unknown Object (File)
Jan 10 2024, 1:13 PM
Unknown Object (File)
Jan 5 2024, 9:12 AM
Subscribers
None

Details

Summary

Depends on D19325. Ref T13120. Ref T12414.

This no longer has any callers in the upstream or in Phacility support libraries, so get rid of it.

This will make modularizing Device transactions significantly easier, since the other transactions are reasonable, normal sorts of transactions.

For existing devices, this leaves some "author edited this object." transactions in the log. I might just leave those since they aren't really hurting anything, or maybe I'll clean them up or hide them later once I have more confidence that these changes are stable.

Test Plan

Grepped for TYPE_INTERFACE and AlmanacDeviceTransaction, found no callsites.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable