Page MenuHomePhabricator

Allow repository cluster bindings to be marked as not "writable", making them read-only
ClosedPublic

Authored by epriestley on Apr 12 2018, 9:08 PM.
Tags
None
Referenced Files
F18086440: D19357.id.diff
Tue, Aug 5, 9:56 PM
F18056373: D19357.diff
Mon, Aug 4, 8:18 AM
F17638215: D19357.id46306.diff
Fri, Jul 11, 4:28 PM
F17638212: D19357.id.diff
Fri, Jul 11, 4:28 PM
Unknown Object (File)
Jul 3 2025, 7:36 PM
Unknown Object (File)
Jul 3 2025, 7:35 PM
Unknown Object (File)
Jun 2 2025, 1:33 PM
Unknown Object (File)
May 27 2025, 2:53 AM
Subscribers
None

Details

Summary

Depends on D19356. Fixes T10883. Ref T13120.

  • Add a "writable" property to the bindings, defaulting to "true" with a nice dropdown.
  • When selecting hosts, allow callers to request a writable host.
  • If the caller wants a writable host, only return hosts if they're writable.
  • In SVN and Mercurial, we sometimes return only writable hosts when we could return read-only hosts, but figuring out if these request are read-only or read-write is currently tricky. Since these repositories can't really cluster yet, this shouldn't matter too much today.
Test Plan
  • Without any config changes, viewed repositories via web UI and pushed/pulled via SSH and HTTP.
  • Made all nodes in the cluster read-only by disabling "writable", pulled and hit the web UI (worked), tried to push via SSH and HTTP (got errors about read-only).
  • Put everything back, pulled and pushed.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • Document the slightly fancier cluster contraction process.
This revision is now accepted and ready to land.Apr 12 2018, 9:56 PM
This revision was automatically updated to reflect the committed changes.

See T13611. This was broken by D20775 (September 2019) until D21576 (February 2021).