Differential D19357

Allow repository cluster bindings to be marked as not "writable", making them read-only
ClosedPublic
Actions

Authored by epriestley on Apr 12 2018, 9:08 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jan 28, 3:45 AM

	Unknown Object (File)
	Tue, Jan 28, 3:45 AM

	Unknown Object (File)
	Tue, Jan 28, 3:44 AM

	Unknown Object (File)
	Tue, Jan 28, 3:44 AM

	Unknown Object (File)
	Sat, Jan 25, 3:30 PM

	Unknown Object (File)
	Sat, Jan 25, 1:07 AM

	Unknown Object (File)
	Sat, Jan 25, 1:07 AM

	Unknown Object (File)
	Sat, Jan 25, 1:07 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10883: Allow repository cluster nodes to be read-only
T13120: Plans: 2018 Week 15 Bonus Content

Commits

rP6556536d0615: Allow repository cluster bindings to be marked as not "writable", making them…

Summary

Depends on D19356. Fixes T10883. Ref T13120.

Add a "writable" property to the bindings, defaulting to "true" with a nice dropdown.
When selecting hosts, allow callers to request a writable host.
If the caller wants a writable host, only return hosts if they're writable.
In SVN and Mercurial, we sometimes return only writable hosts when we could return read-only hosts, but figuring out if these request are read-only or read-write is currently tricky. Since these repositories can't really cluster yet, this shouldn't matter too much today.

Test Plan

Without any config changes, viewed repositories via web UI and pushed/pulled via SSH and HTTP.
Made all nodes in the cluster read-only by disabling "writable", pulled and hit the web UI (worked), tried to push via SSH and HTTP (got errors about read-only).
Put everything back, pulled and pushed.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 12 2018, 9:08 PM

Harbormaster completed remote builds in B20123: Diff 46306.Apr 12 2018, 9:10 PM

epriestley requested review of this revision.Apr 12 2018, 9:10 PM

Document the slightly fancier cluster contraction process.

Harbormaster completed remote builds in B20124: Diff 46307.Apr 12 2018, 9:23 PM

amckinley accepted this revision.Apr 12 2018, 9:56 PM

This revision is now accepted and ready to land.Apr 12 2018, 9:56 PM

Closed by commit rP6556536d0615: Allow repository cluster bindings to be marked as not "writable", making them… (authored by epriestley). · Explain WhyApr 12 2018, 11:10 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D21576: Correct behavior of "writable" Almanac service binding for repository services.Feb 25 2021, 8:15 PM

epriestley mentioned this in rPf970b350ea2f: Correct behavior of "writable" Almanac service binding for repository services.Feb 25 2021, 8:29 PM

See T13611. This was broken by D20775 (September 2019) until D21576 (February 2021).

epriestley mentioned this in T13611: In clusters, "writable" property on bindings may not actually prevent writes.Feb 25 2021, 8:31 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

almanac/

servicetype/

AlmanacClusterRepositoryServiceType.php

5 lines

diffusion/

controller/

DiffusionServeController.php

1 line

ssh/

DiffusionGitReceivePackSSHWorkflow.php

2 lines

DiffusionGitUploadPackSSHWorkflow.php

2 lines

DiffusionMercurialServeSSHWorkflow.php

5 lines

DiffusionSSHWorkflow.php

50 lines

DiffusionSubversionServeSSHWorkflow.php

5 lines

repository/

storage/

PhabricatorRepository.php

41 lines

docs/

user/

cluster/

cluster_repositories.diviner

28 lines

Diff 46316

src/applications/almanac/servicetype/AlmanacClusterRepositoryServiceType.php

Loading...

src/applications/diffusion/controller/DiffusionServeController.php

Loading...

src/applications/diffusion/ssh/DiffusionGitReceivePackSSHWorkflow.php

Loading...

src/applications/diffusion/ssh/DiffusionGitUploadPackSSHWorkflow.php

Loading...

src/applications/diffusion/ssh/DiffusionMercurialServeSSHWorkflow.php

Loading...

src/applications/diffusion/ssh/DiffusionSSHWorkflow.php

Loading...

src/applications/diffusion/ssh/DiffusionSubversionServeSSHWorkflow.php

Loading...

src/applications/repository/storage/PhabricatorRepository.php

Loading...

src/docs/user/cluster/cluster_repositories.diviner

Loading...