Page MenuHomePhabricator

Give the "Filetree" UI element an explicit background color
ClosedPublic

Authored by epriestley on Apr 11 2018, 4:42 PM.
Tags
None
Referenced Files
F18841640: D19344.id46257.diff
Tue, Oct 28, 10:04 AM
F18814312: D19344.id.diff
Mon, Oct 20, 10:57 PM
F18811489: D19344.id.diff
Oct 20 2025, 3:47 AM
F18809099: D19344.diff
Oct 19 2025, 11:08 AM
F18634537: D19344.diff
Sep 16 2025, 10:28 PM
F18620248: D19344.id46258.diff
Sep 15 2025, 4:37 AM
F18617403: D19344.id.diff
Sep 14 2025, 9:08 PM
F18601123: D19344.diff
Sep 13 2025, 11:34 AM
Subscribers
None

Details

Summary

See PHI568. If you make the file tree UI very wide so that the page generates a horizontal scrollbar and then scroll the page, the page content can paint underneath the menu.

The menu already has a z-index to make it render above the content, but doesn't actually have a background. Give it a background.

The "transparent" rule was added in D16346 but I don't see any reason why we actually need it there, so I think this probably won't break anything.

Test Plan

Screen Shot 2018-04-11 at 9.42.15 AM.png (1×1 px, 192 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable