Page MenuHomePhabricator

Give the "Filetree" UI element an explicit background color
ClosedPublic

Authored by epriestley on Apr 11 2018, 4:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jun 9 2025, 10:43 AM
Unknown Object (File)
Jun 2 2025, 1:32 PM
Unknown Object (File)
May 31 2025, 8:51 PM
Unknown Object (File)
May 19 2025, 8:41 AM
Unknown Object (File)
May 6 2025, 4:46 AM
Unknown Object (File)
Apr 28 2025, 8:33 PM
Unknown Object (File)
Apr 27 2025, 11:52 AM
Unknown Object (File)
Apr 24 2025, 5:02 PM
Subscribers
None

Details

Summary

See PHI568. If you make the file tree UI very wide so that the page generates a horizontal scrollbar and then scroll the page, the page content can paint underneath the menu.

The menu already has a z-index to make it render above the content, but doesn't actually have a background. Give it a background.

The "transparent" rule was added in D16346 but I don't see any reason why we actually need it there, so I think this probably won't break anything.

Test Plan

Screen Shot 2018-04-11 at 9.42.15 AM.png (1×1 px, 192 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable