Page MenuHomePhabricator

Toggle revision "shouldBroadcast" correctly when "--draft" is used with prototypes off
ClosedPublic

Authored by epriestley on Apr 12 2018, 9:50 PM.
Tags
None
Referenced Files
F14075508: D19360.diff
Thu, Nov 21, 11:41 AM
Unknown Object (File)
Sun, Nov 17, 7:34 AM
Unknown Object (File)
Thu, Oct 31, 10:59 PM
Unknown Object (File)
Oct 9 2024, 9:22 AM
Unknown Object (File)
Sep 9 2024, 4:25 PM
Unknown Object (File)
Sep 6 2024, 3:10 AM
Unknown Object (File)
Sep 4 2024, 8:04 AM
Unknown Object (File)
Aug 29 2024, 12:14 AM
Subscribers
None

Details

Summary

See PHI573. Ref T13120. Drafts were recently changed so that "draft" and "broadcast" are separate flags, and you can have non-broadcasting revisions in states other than "draft" if builds fail on a draft or you abandon a draft.

However, when draft mode is entered with arc diff --draft and you have prototypes off, this flag wasn't being set correctly.

Test Plan

Disabled prototypes, created a revision with arc diff --draft, observed that draft.broadcast is now correctly false.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Roughly, this is mirroring the logic in DifferentialRevision::initializeNewRevision() introduced in D19284:

https://secure.phabricator.com/D19284#change-yYHadGHexpIu

This revision is now accepted and ready to land.Apr 12 2018, 10:53 PM
This revision was automatically updated to reflect the committed changes.