Page MenuHomePhabricator

Toggle revision "shouldBroadcast" correctly when "--draft" is used with prototypes off
ClosedPublic

Authored by epriestley on Apr 12 2018, 9:50 PM.
Tags
None
Referenced Files
F13086088: D19360.diff
Thu, Apr 25, 12:03 AM
Unknown Object (File)
Wed, Apr 17, 2:36 PM
Unknown Object (File)
Mar 5 2024, 3:29 AM
Unknown Object (File)
Jan 31 2024, 9:08 PM
Unknown Object (File)
Jan 24 2024, 5:03 AM
Unknown Object (File)
Dec 20 2023, 7:42 PM
Unknown Object (File)
Nov 30 2023, 4:01 AM
Unknown Object (File)
Nov 16 2023, 10:18 PM
Subscribers
None

Details

Summary

See PHI573. Ref T13120. Drafts were recently changed so that "draft" and "broadcast" are separate flags, and you can have non-broadcasting revisions in states other than "draft" if builds fail on a draft or you abandon a draft.

However, when draft mode is entered with arc diff --draft and you have prototypes off, this flag wasn't being set correctly.

Test Plan

Disabled prototypes, created a revision with arc diff --draft, observed that draft.broadcast is now correctly false.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Roughly, this is mirroring the logic in DifferentialRevision::initializeNewRevision() introduced in D19284:

https://secure.phabricator.com/D19284#change-yYHadGHexpIu

This revision is now accepted and ready to land.Apr 12 2018, 10:53 PM
This revision was automatically updated to reflect the committed changes.