Page MenuHomePhabricator

Toggle revision "shouldBroadcast" correctly when "--draft" is used with prototypes off
ClosedPublic

Authored by epriestley on Apr 12 2018, 9:50 PM.
Tags
None
Referenced Files
F19907325: D19360.diff
Wed, Apr 1, 9:52 AM
F19906391: D19360.diff
Tue, Mar 31, 11:00 PM
F19750287: D19360.id46310.diff
Feb 15 2026, 11:33 PM
F19503566: D19360.diff
Jan 9 2026, 12:21 AM
F19064451: D19360.id.diff
Nov 29 2025, 9:45 PM
F18816311: D19360.id.diff
Oct 21 2025, 5:56 AM
F18807481: D19360.diff
Oct 19 2025, 2:00 AM
F18757992: D19360.id46313.diff
Oct 5 2025, 8:20 PM
Subscribers
None

Details

Summary

See PHI573. Ref T13120. Drafts were recently changed so that "draft" and "broadcast" are separate flags, and you can have non-broadcasting revisions in states other than "draft" if builds fail on a draft or you abandon a draft.

However, when draft mode is entered with arc diff --draft and you have prototypes off, this flag wasn't being set correctly.

Test Plan

Disabled prototypes, created a revision with arc diff --draft, observed that draft.broadcast is now correctly false.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Roughly, this is mirroring the logic in DifferentialRevision::initializeNewRevision() introduced in D19284:

https://secure.phabricator.com/D19284#change-yYHadGHexpIu

This revision is now accepted and ready to land.Apr 12 2018, 10:53 PM
This revision was automatically updated to reflect the committed changes.