Page MenuHomePhabricator

Toggle revision "shouldBroadcast" correctly when "--draft" is used with prototypes off
ClosedPublic

Authored by epriestley on Apr 12 2018, 9:50 PM.
Tags
None
Referenced Files
F18816311: D19360.id.diff
Tue, Oct 21, 5:56 AM
F18807481: D19360.diff
Oct 19 2025, 2:00 AM
F18757992: D19360.id46313.diff
Oct 5 2025, 8:20 PM
F18612672: D19360.id.diff
Sep 14 2025, 9:41 AM
F18597082: D19360.diff
Sep 13 2025, 2:05 AM
F18509565: D19360.id.diff
Sep 5 2025, 3:28 AM
F18502691: D19360.diff
Sep 4 2025, 10:36 PM
F18274248: D19360.id46313.diff
Aug 22 2025, 6:10 PM
Subscribers
None

Details

Summary

See PHI573. Ref T13120. Drafts were recently changed so that "draft" and "broadcast" are separate flags, and you can have non-broadcasting revisions in states other than "draft" if builds fail on a draft or you abandon a draft.

However, when draft mode is entered with arc diff --draft and you have prototypes off, this flag wasn't being set correctly.

Test Plan

Disabled prototypes, created a revision with arc diff --draft, observed that draft.broadcast is now correctly false.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Roughly, this is mirroring the logic in DifferentialRevision::initializeNewRevision() introduced in D19284:

https://secure.phabricator.com/D19284#change-yYHadGHexpIu

This revision is now accepted and ready to land.Apr 12 2018, 10:53 PM
This revision was automatically updated to reflect the committed changes.