Page MenuHomePhabricator

QuicksandBugs
ActivePublic

Watchers

  • This project does not have any watchers.
  • View All

Details

Description

Doom befalls us all.

Recent Activity

Aug 1 2019

epriestley closed T13363: In "Edit Subtasks" dialog, clicking a task tile sometimes (?) closes the dialog as Resolved by committing rP3069ef41662d: Prevent object titles in the "Object Attacher" dialog from triggering Quicksand….
Aug 1 2019, 7:25 PM · Quicksand
epriestley added a revision to T13363: In "Edit Subtasks" dialog, clicking a task tile sometimes (?) closes the dialog: D20693: Prevent object titles in the "Object Attacher" dialog from triggering Quicksand "Close Dialog on Navigation" behavior.
Aug 1 2019, 7:06 PM · Quicksand
epriestley triaged T13363: In "Edit Subtasks" dialog, clicking a task tile sometimes (?) closes the dialog as Normal priority.
Aug 1 2019, 6:59 PM · Quicksand

Jul 3 2019

epriestley added a revision to T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it: D20640: Fix double-close on dialogs leading to Javascript console error.
Jul 3 2019, 3:19 PM · Quicksand

Jun 19 2019

epriestley added a revision to T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it: D20590: Use "link.getAttribute('href')", not "link.href", to bypass dark browser magic.
Jun 19 2019, 5:24 PM · Quicksand
epriestley added a comment to T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it.

D20573 has one issue where the "Select" buttons in the "Merge Duplicates In" dialog are now closing the dialog. We might be missing a JX.pass() / e.prevent() (hopefully) or might need to get slightly more creative in distinguishing between navigation links and javascript magic links.

Jun 19 2019, 2:51 PM · Quicksand

Jun 6 2019

epriestley added a subtask for T10469: Implement "Tabs", an amazing feature where multiple different pages are loaded in the same browser window!: T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it.
Jun 6 2019, 1:58 AM · Quicksand, Feature Request, Workboards
epriestley added a parent task for T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it: T10469: Implement "Tabs", an amazing feature where multiple different pages are loaded in the same browser window!.
Jun 6 2019, 1:58 AM · Quicksand
epriestley renamed T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it from With Quicksand enabled, "Choose Subtype" dialog on "Create Subtask" workflow is not dismissed by making a selection to When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it.
Jun 6 2019, 1:57 AM · Quicksand
epriestley added a comment to T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it.

D20573 will fix this, but perhaps not in the most graceful way possible.

Jun 6 2019, 1:56 AM · Quicksand
epriestley added a revision to T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it: D20573: When a user clicks a navigation link in a dialog, close the dialog.
Jun 6 2019, 1:50 AM · Quicksand

May 30 2019

epriestley updated the task description for T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it.
May 30 2019, 7:10 PM · Quicksand
epriestley added a comment to T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it.

This likely affects other similar dialogs. The fix is to duct-tape something in Quicksand to something in the "click an area to click a link" behavior, most likely.

May 30 2019, 7:07 PM · Quicksand
epriestley created T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it.
May 30 2019, 7:05 PM · Quicksand

Nov 6 2018

epriestley updated the task description for T13081: Quicksand breaks the back button after a reload, et al.
Nov 6 2018, 4:22 PM · Quicksand

Apr 11 2018

epriestley updated the task description for T13081: Quicksand breaks the back button after a reload, et al.
Apr 11 2018, 9:48 PM · Quicksand

Mar 14 2018

epriestley updated the task description for T13081: Quicksand breaks the back button after a reload, et al.
Mar 14 2018, 5:27 PM · Quicksand

Mar 1 2018

epriestley updated the task description for T13081: Quicksand breaks the back button after a reload, et al.
Mar 1 2018, 12:26 AM · Quicksand
epriestley updated the task description for T13081: Quicksand breaks the back button after a reload, et al.
Mar 1 2018, 12:22 AM · Quicksand

Feb 21 2018

epriestley updated the task description for T13081: Quicksand breaks the back button after a reload, et al.
Feb 21 2018, 1:13 AM · Quicksand

Feb 15 2018

epriestley updated the task description for T13081: Quicksand breaks the back button after a reload, et al.
Feb 15 2018, 4:56 PM · Quicksand
epriestley renamed T13081: Quicksand breaks the back button after a reload, et al from Quicksand breaks the back button after a reload to Quicksand breaks the back button after a reload, et al.
Feb 15 2018, 1:31 PM · Quicksand
epriestley triaged T13081: Quicksand breaks the back button after a reload, et al as Normal priority.
Feb 15 2018, 1:26 PM · Quicksand

Feb 14 2018

epriestley added a comment to T13080: Freeze header from differential sometimes sticks around when using the back button.

Quicksand isn't really bound by natural law, but I think that might fix it.

Feb 14 2018, 11:28 PM · Quicksand, Differential
epriestley closed T13080: Freeze header from differential sometimes sticks around when using the back button as Resolved by committing rPa4053bb5808e: When a ChangesetList sleeps after a Quicksand navigation, also hide any visible….
Feb 14 2018, 11:25 PM · Quicksand, Differential
epriestley added a revision to T13080: Freeze header from differential sometimes sticks around when using the back button: D19086: When a ChangesetList sleeps after a Quicksand navigation, also hide any visible banner.
Feb 14 2018, 11:22 PM · Quicksand, Differential
epriestley added projects to T13080: Freeze header from differential sometimes sticks around when using the back button: Differential, Quicksand.
Feb 14 2018, 11:13 PM · Quicksand, Differential

Feb 13 2018

epriestley triaged T10469: Implement "Tabs", an amazing feature where multiple different pages are loaded in the same browser window! as Wishlist priority.
Feb 13 2018, 11:44 PM · Quicksand, Feature Request, Workboards
epriestley moved T10469: Implement "Tabs", an amazing feature where multiple different pages are loaded in the same browser window! from Backlog to Far Future on the Workboards board.
Feb 13 2018, 11:44 PM · Quicksand, Feature Request, Workboards

Jul 27 2017

epriestley merged T11639: InvalidArgumentException when clicking "Show Older Changes" on diff into T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.
Jul 27 2017, 4:53 PM · Quicksand, Bug Report

Jul 9 2017

chad removed the image for Quicksand.
Jul 9 2017, 7:41 PM

May 17 2017

epriestley closed T8047: Differential inline reticle can persist across Quicksand navigations as Resolved by committing rP0ca49fbeb951: Move "hover over an inline to see the affected lines" code to the new class tree.
May 17 2017, 12:37 AM · Inline Comments, Quicksand

May 16 2017

epriestley added a comment to T8047: Differential inline reticle can persist across Quicksand navigations.

I marked D17919 as fixing this. I can't reproduce it after that change (except: the drag-select behavior isn't converted yet) and we're now Quicksand-aware, although it's possible I'm just not doing the right sequence of operations.

May 16 2017, 11:09 PM · Inline Comments, Quicksand
epriestley added a revision to T8047: Differential inline reticle can persist across Quicksand navigations: D17919: Move "hover over an inline to see the affected lines" code to the new class tree.
May 16 2017, 11:06 PM · Inline Comments, Quicksand
epriestley added a comment to T8047: Differential inline reticle can persist across Quicksand navigations.

The keyboard reticle has been fixed but the inline reticle is still at large.

May 16 2017, 4:46 PM · Inline Comments, Quicksand
epriestley added a revision to T8047: Differential inline reticle can persist across Quicksand navigations: D17900: Hide the Differential keyboard focus reticle after Quicksand navigation.
May 16 2017, 1:47 PM · Inline Comments, Quicksand
epriestley created T12717: KeyboardShortcutManager is not Quicksand-aware.
May 16 2017, 1:45 PM · Inline Comments, Quicksand
epriestley moved T8047: Differential inline reticle can persist across Quicksand navigations from Glitches to Reticle on the Inline Comments board.
May 16 2017, 1:28 PM · Inline Comments, Quicksand
epriestley closed T11093: DifferentialInlineCommentEditor retains state across Quicksand requests as Resolved.

I believe this is now resolved by the series of changes attached to T12616. In particular, D17840 introduced Quicksand-aware state to changeset lists.

May 16 2017, 1:26 PM · Inline Comments, Restricted Project, Quicksand, Differential

May 8 2017

epriestley added a revision to T11093: DifferentialInlineCommentEditor retains state across Quicksand requests: D17840: Add a Quicksand-aware page-level container to diffs.
May 8 2017, 4:01 PM · Inline Comments, Restricted Project, Quicksand, Differential
epriestley added a revision to T8047: Differential inline reticle can persist across Quicksand navigations: D17840: Add a Quicksand-aware page-level container to diffs.
May 8 2017, 4:01 PM · Inline Comments, Quicksand

Apr 24 2017

epriestley moved T11093: DifferentialInlineCommentEditor retains state across Quicksand requests from Glitches to Editor on the Inline Comments board.
Apr 24 2017, 10:33 AM · Inline Comments, Restricted Project, Quicksand, Differential
epriestley moved T8047: Differential inline reticle can persist across Quicksand navigations from Backlog to Glitches on the Inline Comments board.
Apr 24 2017, 10:30 AM · Inline Comments, Quicksand
epriestley added a comment to T8047: Differential inline reticle can persist across Quicksand navigations.

The keyboard reticle probably has the same issue but we can figure that out later.

Apr 24 2017, 10:30 AM · Inline Comments, Quicksand
epriestley removed a parent task for T8047: Differential inline reticle can persist across Quicksand navigations: T12634: Keyboard focus reticle is generally oblivious to the world around it.
Apr 24 2017, 10:30 AM · Inline Comments, Quicksand
epriestley added a comment to T8047: Differential inline reticle can persist across Quicksand navigations.

Oh, this actually is the inline reticle, not the keyboard reticle.

Apr 24 2017, 10:29 AM · Inline Comments, Quicksand
epriestley added a parent task for T8047: Differential inline reticle can persist across Quicksand navigations: T12634: Keyboard focus reticle is generally oblivious to the world around it.
Apr 24 2017, 10:29 AM · Inline Comments, Quicksand
epriestley added a project to T8047: Differential inline reticle can persist across Quicksand navigations: Inline Comments.
Apr 24 2017, 10:29 AM · Inline Comments, Quicksand

Apr 21 2017

epriestley moved T11093: DifferentialInlineCommentEditor retains state across Quicksand requests from Backlog to Glitches on the Inline Comments board.
Apr 21 2017, 12:23 PM · Inline Comments, Restricted Project, Quicksand, Differential
epriestley added a project to T11093: DifferentialInlineCommentEditor retains state across Quicksand requests: Inline Comments.
Apr 21 2017, 12:20 PM · Inline Comments, Restricted Project, Quicksand, Differential