Page MenuHomePhabricator

Add a Quicksand-aware page-level container to diffs
ClosedPublic

Authored by epriestley on May 8 2017, 4:01 PM.
Tags
None
Referenced Files
F18124334: D17840.diff
Wed, Aug 13, 12:36 PM
F18102233: D17840.id42918.diff
Sat, Aug 9, 7:23 PM
F18094633: D17840.id.diff
Thu, Aug 7, 10:15 PM
F18090796: D17840.id43043.diff
Wed, Aug 6, 5:37 PM
F18083863: D17840.id.diff
Tue, Aug 5, 11:53 AM
F18077889: D17840.diff
Mon, Aug 4, 7:35 PM
F17852770: D17840.id42919.diff
Jul 27 2025, 1:03 PM
F17849351: D17840.id42917.diff
Jul 27 2025, 8:35 AM
Subscribers
None

Details

Summary

Ref T12616. Ref T8047. Ref T11093. We currently have several bugs where diff state sticks across Quicksand pages.

Add a new top-level object to handle this, with sleep() and wake() methods. In sleep(), future changes will remove/deacivate all the reticles/editors/etc.

See T12616 for high-level discussion of plans here.

This general idea is likely to become more formal eventually (e.g. for "sheets" or whatever we call them, in T10469) but I think this is probably a reasonable place to draw a line for now.

Test Plan
  • Added some logging to sleep(), wake() and construct().
  • Viewed changes in Differential.
  • With Quicksand on, browsed around; saw state change logs fire properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • Slightly less debugging code.
  • Make the state change more robust to Quicksand and behaviors firing in any order.
chad added inline comments.
webroot/rsrc/js/application/diff/DiffChangesetList.js
8–26

spacing expected?

This revision is now accepted and ready to land.May 8 2017, 10:08 PM
This revision was automatically updated to reflect the committed changes.