Page MenuHomePhabricator

Use "link.getAttribute('href')", not "link.href", to bypass dark browser magic
ClosedPublic

Authored by epriestley on Jun 19 2019, 5:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 12:45 PM
Unknown Object (File)
Sat, Mar 23, 12:44 PM
Unknown Object (File)
Sat, Mar 23, 12:44 PM
Unknown Object (File)
Sun, Mar 17, 1:01 PM
Unknown Object (File)
Feb 22 2024, 3:51 PM
Unknown Object (File)
Feb 15 2024, 12:43 PM
Unknown Object (File)
Feb 3 2024, 10:39 PM
Unknown Object (File)
Jan 25 2024, 11:42 AM
Subscribers
None

Details

Summary

Ref T13302. In at least some browsers (including Safari and Chrome), when you write this:

<a href="#">...</a>

...and then access <that node>.href, you get http://local-domain-whatever.com/path/to/current/page# back.

This is wonderful, but not what we want. Access the raw attribute value instead, which is # in all browsers.

Test Plan
  • In Safari, Chrome, and Firefox:
  • Clicked "Edit Subtasks" from a task.
  • Clicked "Select" buttons to select several tasks.
  • Before: Clicking these button incorrectly closed the dialog (because of D20573).
  • After: Clicking these buttons now selects tasks without closing the dialog.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable