Details
Details
- Reviewers
chad - Maniphest Tasks
- T8047: Differential inline reticle can persist across Quicksand navigations
T9270: Toggling File Browser on Differential while creating inline comment causes inline/edit focus reticle to offset
T12616: Modernize display code for inline comments - Commits
- rP0ca49fbeb951: Move "hover over an inline to see the affected lines" code to the new class tree
Hovered over inlines, saw lines select properly.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Prior to this change, we also highlighted the <th /> ("Table Holumn") nodes with yellow. I think we don't really need to, although we could restore that once I finish up here. We could also make the overlay reticle bigger: I think its current size is to let you click the line numbers, but pointer-events: none does the same thing.