Page MenuHomePhabricator

Prevent object titles in the "Object Attacher" dialog from triggering Quicksand "Close Dialog on Navigation" behavior
ClosedPublic

Authored by epriestley on Aug 1 2019, 7:06 PM.

Details

Summary

Fixes T13363. Currently, these are genuine links which we intercept events for.

Make them pseudolinks instead. Possible alternative approaches are:

  • Keep them as genuine links, but mark them as non-navigation links for Quicksand. (But: yuck, weird special case.)
  • Keep them as genuine links, and have the dialog handler JX.Stratcom.pass() to see if anything handles the event. (But: the "pass()" pattern generally feels bad.)

"Tableaus" or whatever comes out of T10469 some day will probably break everything anyway?

Test Plan
  • Opened the "Edit Related Tasks... > Edit Subtasks" dialog.
  • Clicked task title links (not the "open in new window" icon, and not the "Select" button).
  • Before: Dialog (sometimes) closed abruptly.
  • After: Task is consistently selected as part of the attachment set.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Aug 1 2019, 7:06 PM
epriestley requested review of this revision.Aug 1 2019, 7:08 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 1 2019, 7:25 PM
This revision was automatically updated to reflect the committed changes.