Page MenuHomePhabricator

Prevent object titles in the "Object Attacher" dialog from triggering Quicksand "Close Dialog on Navigation" behavior
ClosedPublic

Authored by epriestley on Aug 1 2019, 7:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 28, 1:00 AM
Unknown Object (File)
Sat, Jun 25, 3:43 PM
Unknown Object (File)
Wed, Jun 22, 5:10 AM
Unknown Object (File)
Tue, Jun 14, 10:27 AM
Unknown Object (File)
Sat, Jun 11, 1:38 AM
Unknown Object (File)
Thu, Jun 9, 8:17 AM
Unknown Object (File)
Wed, Jun 8, 9:07 PM
Unknown Object (File)
Jun 3 2022, 2:00 AM
Subscribers
None

Details

Summary

Fixes T13363. Currently, these are genuine links which we intercept events for.

Make them pseudolinks instead. Possible alternative approaches are:

  • Keep them as genuine links, but mark them as non-navigation links for Quicksand. (But: yuck, weird special case.)
  • Keep them as genuine links, and have the dialog handler JX.Stratcom.pass() to see if anything handles the event. (But: the "pass()" pattern generally feels bad.)

"Tableaus" or whatever comes out of T10469 some day will probably break everything anyway?

Test Plan
  • Opened the "Edit Related Tasks... > Edit Subtasks" dialog.
  • Clicked task title links (not the "open in new window" icon, and not the "Select" button).
  • Before: Dialog (sometimes) closed abruptly.
  • After: Task is consistently selected as part of the attachment set.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 1 2019, 7:25 PM
This revision was automatically updated to reflect the committed changes.