Issues with Support Impact that also have a higher cost to fix the longer they remain open, at a higher rate than user growth. The most common reasons are:
Implemented this approach in D13998.
In those rare cases when I have to deal with "old version causes headaches, nev version is not avail everywhere", I put handlers for old and new in place, with handler of old way spilling out warnings that "old version causes headache and I don't care anymore about it, use new".
Thanks @epriestley. RHEL6 is still widely used, and even the latest update on that line carries only git 1.7.1. So if we need a new version of git, its installation becomes a messy business with either custom / rpmforge-extras repo or do compile/install. Would prefer if we can keep the 1.7.1 support around.
no one has ever reported an issue with an old version which we could not trivially resolve
It looks like --get-url was added in early 2011:
D13983 breaks on users running RHEL6. There git version is 1.7.1 and git 1.7.1 does not support --get-url option for ls-remote.
Those were all the cases of parsing git environment-dependent output I could find in arc (unless built-in formats like git log --format=medium are susceptible to git-config/localization/future change, which I doubt).
Yes, it would be a desperate measure with a lot of problems of its own.
the command has potential side effects, or the time of execution is important, and cannot be simply re-run under LC_ALL=C.
(Sorry I hadn't seen T7339, certainly makes my last comment mostly redundant. Perhaps the tasks can be merged?)
system default locale
Also not mentioned here is cases where we phutil_passthru() some command like git push. These would be best run in the system default locale, since we echo the output to the user -- unless we also parse it. I think we never do this right now, but I'm not 100% sure.
See also T7339, which is somewhat related.
I think the current Phabricator/Arcanist handling of locales, at least on Linux, is wrong. The LANG environment variable has lower priority than the family of LC_* variables, as per POSIX §8.2:
(This is a bulk edit test.)
I have this working functionally, but the UI is still an atrocious mess. Probably have something ready tomorrow.
After mulling this over for a bit while dealing with other stuff, I'm pretty convinced that the general purpose infrastructure in T5166 is the way forward here, so my plan is to move forward with that.
This appears to work to undo a status change batch edit:
Another report of this over the weekend:
the test in https://secure.phabricator.com/diffusion/ARC/browse/master/src/repository/api/ArcanistGitAPI.php;0c9a03771961be79d09e566051a5a594866760d9$503-508
fails for non-English git, which makes repo detection fail (And shows up as "you can't close this revision" exception during arc land).
LANG=en_US.UTF-8 should do the trick, but it fails if the en_US.UTF-8 locale is not generated/available.
At least for now, this no longer blocks Phacility or T2783.