Page MenuHomePhabricator
Differential D13993

Use 'git blame --porcelain' for git blame info
ClosedPublic
Actions

Authored by jbeta on Aug 25 2015, 4:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 8:11 PM
Unknown Object (File)
Fri, Dec 6, 12:18 PM
Unknown Object (File)
Sun, Dec 1, 6:51 AM
Unknown Object (File)
Sun, Nov 24, 8:18 AM
Unknown Object (File)
Nov 21 2024, 10:50 AM
Unknown Object (File)
Nov 17 2024, 9:22 AM
Unknown Object (File)
Nov 14 2024, 1:59 PM
Unknown Object (File)
Nov 8 2024, 8:39 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5554: arc fails with svn/git/hg non english locales
Commits
rARC4c3d75401f81: Use 'git blame --porcelain' for git blame info
Summary

This guards against stability issues with the output format of 'git
blame' (such as git config, localization (ref T5554) or future changes).

For example, git config blame.blankboundary true breaks arc cover
before this patch.

Test Plan
  • Set git config blame.blankboundary true on a test repo.
  • Ran arc cover. It failed with an exception ("Bad blame?").
  • Applied this patch.
  • arc cover works.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jbeta updated this revision to Diff 33816.Aug 25 2015, 4:18 PM
jbeta retitled this revision from to Use 'git blame --porcelain' for git blame info.
jbeta updated this object.
jbeta edited the test plan for this revision. (Show Details)
jbeta added a reviewer: epriestley.
jbeta added a task: T5554: arc fails with svn/git/hg non english locales.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 25 2015, 4:18 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Aug 25 2015, 4:35 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 25 2015, 4:35 PM
Closed by commit rARC4c3d75401f81: Use 'git blame --porcelain' for git blame info (authored by jbeta, committed by epriestley). · Explain WhyAug 25 2015, 4:36 PM
This revision was automatically updated to reflect the committed changes.
• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM
chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM

Revision Contents
Changeset List

PathSize
src/
repository/
api/
51 lines

Diff 33817

View Options

src/repository/api/ArcanistGitAPI.php

Loading...
Phabricator · Built by Phacility