Page MenuHomePhabricator

Use 'git blame --porcelain' for git blame info
ClosedPublic

Authored by jbeta on Aug 25 2015, 4:18 PM.

Details

Summary

This guards against stability issues with the output format of 'git
blame' (such as git config, localization (ref T5554) or future changes).

For example, git config blame.blankboundary true breaks arc cover
before this patch.

Test Plan
  • Set git config blame.blankboundary true on a test repo.
  • Ran arc cover. It failed with an exception ("Bad blame?").
  • Applied this patch.
  • arc cover works.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jbeta retitled this revision from to Use 'git blame --porcelain' for git blame info.
jbeta updated this object.
jbeta edited the test plan for this revision. (Show Details)
jbeta added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 25 2015, 4:35 PM
This revision was automatically updated to reflect the committed changes.