Page MenuHomePhabricator

Accept Conduit tokens as an authentication mechanism
ClosedPublic

Authored by epriestley on Dec 12 2014, 11:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 11, 11:17 PM
Unknown Object (File)
Feb 3 2024, 1:28 AM
Unknown Object (File)
Jan 26 2024, 11:08 PM
Unknown Object (File)
Jan 15 2024, 4:03 PM
Unknown Object (File)
Jan 10 2024, 8:55 PM
Unknown Object (File)
Jan 10 2024, 9:38 AM
Unknown Object (File)
Jan 10 2024, 9:38 AM
Unknown Object (File)
Jan 10 2024, 9:38 AM
Subscribers

Details

Summary
  • Ref T5955. Accept the tokens introduced in D10985 as an authentication token.
  • Ref T3628. Permit simple curl-compatible decoding of parameters.
Test Plan
  • Ran some sensible curl API commands:
epriestley@orbital ~/dev/phabricator $ curl -g "http://local.phacility.com/api/user.whoami?api.token=api-f7dfpoyelk4mmz6vxcueb6hcbtbk" ; echo
{"result":{"phid":"PHID-USER-cvfydnwadpdj7vdon36z","userName":"admin","realName":"asdf","image":"http:\/\/local.phacility.com\/res\/1410737307T\/phabricator\/3eb28cd9\/rsrc\/image\/avatar.png","uri":"http:\/\/local.phacility.com\/p\/admin\/","roles":["admin","verified","approved","activated"]},"error_code":null,"error_info":null}
epriestley@orbital ~/dev/phabricator $ curl -g "http://local.phacility.com/api/differential.query?api.token=api-f7dfpoyelk4mmz6vxcueb6hcbtbk&ids[]=1" ; echo
{"result":[{"id":"1","phid":"PHID-DREV-v3a67ixww3ccg5lqbxee","title":"zxcb","uri":"http:\/\/local.phacility.com\/D1","dateCreated":"1418405590","dateModified":"1418405590","authorPHID":"PHID-USER-cvfydnwadpdj7vdon36z","status":"0","statusName":"Needs Review","branch":null,"summary":"","testPlan":"zxcb","lineCount":"6","activeDiffPHID":"PHID-DIFF-pzbtc5rw6pe5j2kxtlr2","diffs":["1"],"commits":[],"reviewers":[],"ccs":[],"hashes":[],"auxiliary":{"phabricator:projects":[],"phabricator:depends-on":[],"organization.sqlmigration":null},"arcanistProjectPHID":null,"repositoryPHID":null,"sourcePath":null}],"error_code":null,"error_info":null}
  • Ran older-style commands like arc list against the local install.
  • Ran commands via web console.
  • Added and ran a unit test to make sure nothing is using forbidden parameter names.
  • Terminated a token and verified it no longer works.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Accept Conduit tokens as an authentication mechanism.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Dec 15 2014, 6:44 PM
This revision was automatically updated to reflect the committed changes.