Page MenuHomePhabricator

Don't use "-c" flag in "git:branch-unique()" revision range rule
ClosedPublic

Authored by epriestley on Dec 10 2015, 10:15 PM.
Tags
None
Referenced Files
F18917966: D14735.id.diff
Sun, Nov 9, 10:08 AM
F18905260: D14735.diff
Sat, Nov 8, 1:32 PM
F18806797: D14735.id35630.diff
Oct 18 2025, 9:37 PM
F18760792: D14735.id.diff
Oct 6 2025, 10:27 AM
F18756816: D14735.diff
Oct 5 2025, 1:41 PM
F18712955: D14735.id.diff
Sep 29 2025, 5:34 AM
F18506803: D14735.id.diff
Sep 5 2025, 1:48 AM
F18499522: D14735.diff
Sep 4 2025, 7:49 PM
Subscribers
None

Details

Summary

Fixes T9953.

  • "-c" was introduced in 1.7.2.
  • "--no-color" has existed forever as far as I can tell.
  • "--no-column" was introducd in 1.7.11, but there was nothing that needed to be disabled before that (hopefully).
Test Plan
  • Ran arc which --trace and observed a reasonable git branch command with correct output.
  • Ran arc which --trace with a faked older Git version, observed command omit --no-column.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Don't use "-c" flag in "git:branch-unique()" revision range rule.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 10 2015, 10:15 PM
This revision was automatically updated to reflect the committed changes.