Paths

Table of Contentst

Differential D14735

Don't use "-c" flag in "git:branch-unique()" revision range rule
ClosedPublic
Actions

Authored by epriestley on Dec 10 2015, 10:15 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 21, 4:19 AM

	Unknown Object (File)
	Wed, Dec 18, 6:59 AM

	Unknown Object (File)
	Tue, Dec 17, 12:42 AM

	Unknown Object (File)
	Sun, Dec 15, 8:01 AM

	Unknown Object (File)
	Sun, Dec 1, 10:18 AM

	Unknown Object (File)
	Sun, Dec 1, 7:08 AM

	Unknown Object (File)
	Sun, Dec 1, 7:08 AM

	Unknown Object (File)
	Sun, Dec 1, 7:08 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T9953: arc fails with `git:branch-unique(*)` base commit rule on CentOS 6

Commits

rARCd0e73bb65610: Don't use "-c" flag in "git:branch-unique()" revision range rule

Summary

Fixes T9953.

"-c" was introduced in 1.7.2.
"--no-color" has existed forever as far as I can tell.
"--no-column" was introducd in 1.7.11, but there was nothing that needed to be disabled before that (hopefully).

Test Plan

Ran arc which --trace and observed a reasonable git branch command with correct output.
Ran arc which --trace with a faked older Git version, observed command omit --no-column.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35629.Dec 10 2015, 10:15 PM

epriestley retitled this revision from to Don't use "-c" flag in "git:branch-unique()" revision range rule.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9953: arc fails with `git:branch-unique(*)` base commit rule on CentOS 6.

chad accepted this revision.Dec 10 2015, 10:15 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 10 2015, 10:15 PM

Closed by commit rARCd0e73bb65610: Don't use "-c" flag in "git:branch-unique()" revision range rule (authored by epriestley, committed by epriestley). · Explain WhyDec 10 2015, 10:19 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T5554: arc fails with svn/git/hg non english locales.Dec 12 2015, 1:46 PM

Revision Contents
Changeset List

Path

Size

src/

repository/

api/

ArcanistGitAPI.php

14 lines

Diff 35630

src/repository/api/ArcanistGitAPI.php

Loading...