Use 'remote.origin.url' fallback for git < 1.7.5
ClosedPublic
Actions

Authored by jbeta on Aug 26 2015, 10:01 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCc22dfe61ed01: Use 'remote.origin.url' fallback for git < 1.7.5

Summary

'git ls-remote --get-url' is more correct, but younger and less
supported. This commit tempers previous optimism about its availability,
improving support for users of older git packages.

Test Plan

Set git config url.xttps.insteadOf https rewrite rule.
Ran arc which with git 1.7.5 in $PATH, saw rewritten configured remote.
Ran arc which with git 1.7.4 in $PATH, saw configured remote.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jbeta updated this revision to Diff 33823.Aug 26 2015, 10:01 PM

jbeta retitled this revision from to Use 'remote.origin.url' fallback for git < 1.7.5.

jbeta updated this object.

jbeta edited the test plan for this revision. (Show Details)

jbeta added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 26 2015, 10:01 PM

Herald added a subscriber: Korvin. · View Herald Transcript

jbeta mentioned this in T5554: arc fails with svn/git/hg non english locales.Aug 26 2015, 10:03 PM

Thanks!

This revision is now accepted and ready to land.Aug 26 2015, 10:58 PM

Closed by commit rARCc22dfe61ed01: Use 'remote.origin.url' fallback for git < 1.7.5 (authored by jbeta, committed by epriestley). · Explain WhyAug 26 2015, 10:59 PM

This revision was automatically updated to reflect the committed changes.

• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM

chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM

Revision Contents
Changeset List

Path

Size

src/

repository/

api/

ArcanistGitAPI.php

20 lines

Diff 33824

View Options

src/repository/api/ArcanistGitAPI.php

Use 'remote.origin.url' fallback for git < 1.7.5ClosedPublicActions