Make ManiphestTaskQuery more modern and safe
ClosedPublic
Actions

Authored by epriestley on Jun 22 2015, 1:20 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T8637: Maniphest batch editor can affect far too many tasks

Commits

Restricted Diffusion Commit
rP487e12101aba: Make ManiphestTaskQuery more modern and safe

Summary

Ref T8637. This class has some really old parameter handling which can send withIDs(array()) down a "fetch everything" pathway. Clean up most of it.

Test Plan

Issued every ApplicationSearch query.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32410.Jun 22 2015, 1:20 PM

epriestley retitled this revision from to Make ManiphestTaskQuery more modern and safe.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 22 2015, 1:20 PM

epriestley mentioned this in T8637: Maniphest batch editor can affect far too many tasks.Jun 22 2015, 1:20 PM

epriestley updated this object.

epriestley added a task: T8637: Maniphest batch editor can affect far too many tasks.

btrahan accepted this revision.Jun 22 2015, 5:28 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jun 22 2015, 5:28 PM

Closed by commit rP487e12101aba: Make ManiphestTaskQuery more modern and safe (authored by epriestley, committed by epriestley). · Explain WhyJun 22 2015, 6:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

query/

ManiphestTaskQuery.php

206 lines

Diff 32421

View Options

src/applications/maniphest/query/ManiphestTaskQuery.php

Make ManiphestTaskQuery more modern and safeClosedPublicActions