Page MenuHomePhabricator

jbeta
Picker of Nits

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Aug 14 2015, 12:41 AM (276 w, 6 d)
Availability
Available

Recent Activity

Aug 27 2015

jbeta accepted D13999: Fix possible recursive embeds in Dashboard text panels.

Applied this diff on my test install, panels confirmed unhaunted.

Aug 27 2015, 12:48 AM

Aug 26 2015

jbeta added a comment to T5554: arc fails with svn/git/hg non english locales.
In T5554#134045, @jbeta wrote:

To make it still work out of the box with most potential users of insteadOf, we could use either command depending on git version if you think that's worth the hassle.

Implemented this approach in D13998.

Aug 26 2015, 10:03 PM · Arcanist
jbeta retitled D13998: Use 'remote.origin.url' fallback for git < 1.7.5 from to Use 'remote.origin.url' fallback for git < 1.7.5.
Aug 26 2015, 10:01 PM
jbeta added a comment to T5554: arc fails with svn/git/hg non english locales.

D13983 breaks on users running RHEL6. There git version is 1.7.1 and git 1.7.1 does not support --get-url option for ls-remote.

Aug 26 2015, 8:53 PM · Arcanist

Aug 25 2015

jbeta added a comment to T5554: arc fails with svn/git/hg non english locales.

Those were all the cases of parsing git environment-dependent output I could find in arc (unless built-in formats like git log --format=medium are susceptible to git-config/localization/future change, which I doubt).

Aug 25 2015, 5:19 PM · Arcanist
jbeta added a revision to T5554: arc fails with svn/git/hg non english locales: D13993: Use 'git blame --porcelain' for git blame info.
Aug 25 2015, 4:18 PM · Arcanist
jbeta retitled D13993: Use 'git blame --porcelain' for git blame info from to Use 'git blame --porcelain' for git blame info.
Aug 25 2015, 4:18 PM
jbeta added a comment to T8509: Exception when creating project with same tag as primary slug..

(Whoops, failed to find this one. Sorry.)

Aug 25 2015, 8:33 AM · Projects
jbeta created T9256: Unhandled AphrontDuplicateKeyQueryException when duplicate hashtags are assigned to a project.
Aug 25 2015, 12:26 AM · Projects

Aug 24 2015

jbeta added a comment to D13989: Minimize reliance on 'git branch' output format.

Should be more robust now.

Aug 24 2015, 11:10 PM
jbeta added a comment to D13989: Minimize reliance on 'git branch' output format.
Aug 24 2015, 11:06 PM
jbeta updated the diff for D13989: Minimize reliance on 'git branch' output format.
  • Switched strategy to parsing branch refs instead of relying on git "short" formats
Aug 24 2015, 11:06 PM
jbeta added inline comments to D13989: Minimize reliance on 'git branch' output format.
Aug 24 2015, 8:30 PM
jbeta added a comment to D13989: Minimize reliance on 'git branch' output format.

Turned out, (test) is a valid branch name in git.

Aug 24 2015, 2:18 PM
jbeta updated the diff for D13989: Minimize reliance on 'git branch' output format.

Rebased against master

Aug 24 2015, 2:08 PM
jbeta retitled D13989: Minimize reliance on 'git branch' output format from to Minimize reliance on 'git branch' output format.
Aug 24 2015, 1:53 PM
jbeta added a revision to T5554: arc fails with svn/git/hg non english locales: D13989: Minimize reliance on 'git branch' output format.
Aug 24 2015, 1:53 PM · Arcanist
jbeta added a comment to T9235: Add a warning about "always_populate_raw_post_data" being misconfigured.

It seems you also need both display_errors and display_startup_errors turned on to hit this, though. I don't know if that is something you'd want to support.

Aug 24 2015, 10:59 AM · Contributor Onboarding, Setup
jbeta added a comment to T9016: Weird CSS issue with inline comments.

Well, due to recent shortages of warm expressions of user gratitude, the upstream has had to resort to providing their own positive feedback. They achieve this by self-awarding cool-looking badges for commits.

Aug 24 2015, 10:49 AM · Badge Awarded, Differential, PHUI, Mobile
jbeta added a comment to T9235: Add a warning about "always_populate_raw_post_data" being misconfigured.

I just hit problem (2) on this report myself, had to trace it the same way @aelam did.

Aug 24 2015, 10:39 AM · Contributor Onboarding, Setup
jbeta updated the diff for D13983: Avoid parsing git "remote show" using "ls-remote".
  • Keep previous behavior in the case where origin does not exist.
Aug 24 2015, 9:03 AM
johnny-bit awarded D13983: Avoid parsing git "remote show" using "ls-remote" a Like token.
Aug 24 2015, 8:45 AM
jbeta added a revision to T5554: arc fails with svn/git/hg non english locales: D13983: Avoid parsing git "remote show" using "ls-remote".
Aug 24 2015, 12:19 AM · Arcanist
jbeta retitled D13983: Avoid parsing git "remote show" using "ls-remote" from to Avoid parsing git "remote show" using "ls-remote".
Aug 24 2015, 12:19 AM

Aug 22 2015

jbeta added a comment to T5554: arc fails with svn/git/hg non english locales.

I think this tactic (re-run the command to figure out the error) is a really fragile one and would be very hesitant to pursue it over requiring users to install locales, but agree on this otherwise.

Yes, it would be a desperate measure with a lot of problems of its own.

Aug 22 2015, 7:36 PM · Arcanist
jbeta created T9248: "Show older changes" link spits out JSON when opened on a new tab.
Aug 22 2015, 5:10 AM · PHUI
jbeta updated subscribers of T5554: arc fails with svn/git/hg non english locales.

(Sorry I hadn't seen T7339, certainly makes my last comment mostly redundant. Perhaps the tasks can be merged?)

Aug 22 2015, 4:44 AM · Arcanist

Aug 21 2015

jbeta added a comment to T5554: arc fails with svn/git/hg non english locales.

I think the current Phabricator/Arcanist handling of locales, at least on Linux, is wrong. The LANG environment variable has lower priority than the family of LC_* variables, as per POSIX §8.2:

Aug 21 2015, 1:14 PM · Arcanist

Aug 20 2015

jbeta added a comment to Contributor.

(also there's a typo in the badge name :p)

Aug 20 2015, 11:24 AM
jbeta added a comment to D13944: Fix wrong plural of an `arc land` message.

Got it. In general, the rest of the code relies on an untranslated $this->branchType. I suppose that should be solved in a more general diff.

Aug 20 2015, 11:08 AM
jbeta updated the diff for D13944: Fix wrong plural of an `arc land` message.
  • Made the entire message block translatable
  • Fixed switch indentation
Aug 20 2015, 11:06 AM
jbeta added a comment to D13944: Fix wrong plural of an `arc land` message.

Hmm... still, @avivey should be right in that $this->branchType makes the complete message not translatable, no?

Aug 20 2015, 10:28 AM
jbeta planned changes to D13944: Fix wrong plural of an `arc land` message.

Fair enough then, I'll update this.

Aug 20 2015, 10:24 AM
jbeta added a comment to D13944: Fix wrong plural of an `arc land` message.

Wouldn't that be harder to translate later on?

Aug 20 2015, 10:12 AM
jbeta updated D13944: Fix wrong plural of an `arc land` message.
Aug 20 2015, 2:47 AM
jbeta added a revision to T9225: Wrong pluralization ("branchs") in an arc land message: D13944: Fix wrong plural of an `arc land` message.
Aug 20 2015, 2:47 AM · Arcanist
jbeta added a comment to T9225: Wrong pluralization ("branchs") in an arc land message.
In T9225#133080, @chad wrote:

We'll even give you badge

Aug 20 2015, 2:47 AM · Arcanist
jbeta retitled D13944: Fix wrong plural of an `arc land` message from to Fix wrong plural of an `arc land` message.
Aug 20 2015, 2:46 AM
jbeta created T9225: Wrong pluralization ("branchs") in an arc land message.
Aug 20 2015, 2:19 AM · Arcanist

Aug 14 2015

jbeta added a comment to T9176: VCS access broken after update.

(On a less important note, confirmed fixed for us in HEAD. Thanks for the quick response.)

Aug 14 2015, 1:06 AM · Diffusion
jbeta created T9176: VCS access broken after update.
Aug 14 2015, 12:51 AM · Diffusion