- User Since
- Aug 14 2015, 12:41 AM (276 w, 6 d)
Aug 27 2015
Applied this diff on my test install, panels confirmed unhaunted.
Aug 26 2015
Implemented this approach in D13998.
Aug 25 2015
Those were all the cases of parsing git environment-dependent output I could find in arc (unless built-in formats like git log --format=medium are susceptible to git-config/localization/future change, which I doubt).
(Whoops, failed to find this one. Sorry.)
Aug 24 2015
Should be more robust now.
- Switched strategy to parsing branch refs instead of relying on git "short" formats
Turned out, (test) is a valid branch name in git.
Rebased against master
It seems you also need both display_errors and display_startup_errors turned on to hit this, though. I don't know if that is something you'd want to support.
Well, due to recent shortages of warm expressions of user gratitude, the upstream has had to resort to providing their own positive feedback. They achieve this by self-awarding cool-looking badges for commits.
I just hit problem (2) on this report myself, had to trace it the same way @aelam did.
- Keep previous behavior in the case where origin does not exist.
Aug 22 2015
Yes, it would be a desperate measure with a lot of problems of its own.
(Sorry I hadn't seen T7339, certainly makes my last comment mostly redundant. Perhaps the tasks can be merged?)
Aug 21 2015
I think the current Phabricator/Arcanist handling of locales, at least on Linux, is wrong. The LANG environment variable has lower priority than the family of LC_* variables, as per POSIX §8.2:
Aug 20 2015
(also there's a typo in the badge name :p)
Got it. In general, the rest of the code relies on an untranslated $this->branchType. I suppose that should be solved in a more general diff.
- Made the entire message block translatable
- Fixed switch indentation
Hmm... still, @avivey should be right in that $this->branchType makes the complete message not translatable, no?
Fair enough then, I'll update this.
Wouldn't that be harder to translate later on?
Aug 14 2015
(On a less important note, confirmed fixed for us in HEAD. Thanks for the quick response.)