Paths

Table of Contentst

Differential D10989

Add conduit.getcapabilities and a modern CLI handshake workflow
ClosedPublic
Actions

Authored by epriestley on Dec 13 2014, 12:45 AM.

Tags

None

Subscribers

Details

Reviewers

Maniphest Tasks

Restricted Maniphest Task
T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings

Commits

Restricted Diffusion Commit
rP288498f8d099: Add conduit.getcapabilities and a modern CLI handshake workflow

Summary

Ref T5955.

Add conduit.getcapabilities to help arc (and other clients) determine formats, protocols, etc., the server supports.
Fixes T3117. Add a more modern version of the handshake workflow that allows all generated tokens to remain valid for an hour.
Generally, add a CLI token type. This token type expires after an hour when generated, then becomes permanent if used.

Test Plan

See D10988.
Ran conduit.getcapabilities and inspected output.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 26383.Dec 13 2014, 12:45 AM

epriestley retitled this revision from to Add conduit.getcapabilities and a modern CLI handshake workflow.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings, Restricted Maniphest Task.

Herald added a subscriber: epriestley. · View Herald TranscriptDec 13 2014, 12:45 AM

Fix some error string formatting.

btrahan accepted this revision.Dec 15 2014, 6:47 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Dec 15 2014, 6:47 PM

Closed by commit rP288498f8d099: Add conduit.getcapabilities and a modern CLI handshake workflow (authored by epriestley, committed by epriestley). · Explain WhyDec 15 2014, 7:15 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

applications/

conduit/

application/

PhabricatorConduitApplication.php

1 line

controller/

PhabricatorConduitAPIController.php

37 lines

PhabricatorConduitTokenHandshakeController.php

46 lines

method/

ConduitGetCapabilitiesConduitAPIMethod.php

60 lines

storage/

PhabricatorConduitToken.php

14 lines

Diff 26397

src/__phutil_library_map__.php

Loading...

src/applications/conduit/application/PhabricatorConduitApplication.php

Loading...

src/applications/conduit/controller/PhabricatorConduitAPIController.php

Loading...

src/applications/conduit/controller/PhabricatorConduitTokenHandshakeController.php

Loading...

src/applications/conduit/method/ConduitGetCapabilitiesConduitAPIMethod.php

Loading...

src/applications/conduit/storage/PhabricatorConduitToken.php

Loading...