Page MenuHomePhabricator

Add hard stops on empty batch edit sets
ClosedPublic

Authored by epriestley on Jun 22 2015, 1:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 10:54 PM
Unknown Object (File)
Thu, Dec 5, 7:54 AM
Unknown Object (File)
Thu, Dec 5, 6:29 AM
Unknown Object (File)
Tue, Dec 3, 1:26 PM
Unknown Object (File)
Sun, Dec 1, 11:08 AM
Unknown Object (File)
Tue, Nov 26, 6:44 PM
Unknown Object (File)
Thu, Nov 21, 1:39 AM
Unknown Object (File)
Nov 17 2024, 12:25 AM

Details

Summary

Ref T8637. If a user tries to batch edit a list of tasks which can't be edited, we fall through to withIDs(array()), which can affect everything.

Explicitly stop batch editing if we don't have valid IDs or valid tasks.

The UI sort-of warns you that something is wrong, but this is ultimately a pretty severe UX issue. I'll fix the underlying Query in the next diff.

Test Plan

Tried to batch edit a list of tasks I didn't have permission to edit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Add hard stops on empty batch edit sets.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 22 2015, 5:28 PM
This revision was automatically updated to reflect the committed changes.