Fixes T7376.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T7376: Put commit hashes in stack traces
- Commits
- rPHUa259a43911f6: Put version information in stack traces
[Wed Feb 25 11:05:39.865668 2015] [:error] [pid 2132] [client 127.0.0.1:58544] [2015-02-25 11:05:39] EXCEPTION: (Exception) herp at [<phabricator>/src/applications/home/controller/PhabricatorHomeMainController.php:19] [Wed Feb 25 11:05:39.866248 2015] [:error] [pid 2132] [client 127.0.0.1:58544] libcore(), instances(head=master, ref.master=3f62bd346197), services(head=master, ref.master=b2c33cc00bd8), arcanist(head=master, ref.master=dd59423d56ad), phutil(head=err1, ref.master=46764a249766, ref.err1=5bc34397d59a), phabricator(head=almanac2, ref.master=8316c9dc14d5, ref.almanac2=8a5513aa815a, custom=17) [Wed Feb 25 11:05:39.866259 2015] [:error] [pid 2132] [client 127.0.0.1:58544] #0 PhabricatorHomeMainController::processRequest() called at [<phabricator>/src/aphront/AphrontController.php:33] [Wed Feb 25 11:05:39.866274 2015] [:error] [pid 2132] [client 127.0.0.1:58544] #1 AphrontController::handleRequest(AphrontRequest) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:196] [Wed Feb 25 11:05:39.866280 2015] [:error] [pid 2132] [client 127.0.0.1:58544] #2 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:121] [Wed Feb 25 11:05:39.866283 2015] [:error] [pid 2132] [client 127.0.0.1:58544] #3 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phabricator>/webroot/index.php:19]
Diff Detail
Diff Detail
- Repository
- rPHU libphutil
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
For posterity, here's how to read this:
phabricator(head=almanac2, ref.master=8316c9dc14d5, ref.almanac2=8a5513aa815a, custom=17)
That means "the branch almanac2 is checked out, master is at 8136, almanac2 is at 8a55, there are 17 custom extension files".
I'm also using raw functions here instead of, e.g., Filesystem, to limit the chance that handling an error results in a second error. We'd much rather get this information wrong than create more errors or loop or crash or whatever.