Page MenuHomePhabricator

Put version information in stack traces
ClosedPublic

Authored by epriestley on Feb 25 2015, 7:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 15, 10:43 PM
Unknown Object (File)
Sun, Mar 3, 12:25 PM
Unknown Object (File)
Jan 29 2024, 10:02 PM
Unknown Object (File)
Jan 16 2024, 12:34 AM
Unknown Object (File)
Jan 16 2024, 12:34 AM
Unknown Object (File)
Jan 12 2024, 6:48 AM
Unknown Object (File)
Dec 27 2023, 8:26 PM
Unknown Object (File)
Dec 25 2023, 2:46 AM
Subscribers

Details

Summary

Fixes T7376.

Test Plan
[Wed Feb 25 11:05:39.865668 2015] [:error] [pid 2132] [client 127.0.0.1:58544] [2015-02-25 11:05:39] EXCEPTION: (Exception) herp at [<phabricator>/src/applications/home/controller/PhabricatorHomeMainController.php:19]
[Wed Feb 25 11:05:39.866248 2015] [:error] [pid 2132] [client 127.0.0.1:58544] libcore(), instances(head=master, ref.master=3f62bd346197), services(head=master, ref.master=b2c33cc00bd8), arcanist(head=master, ref.master=dd59423d56ad), phutil(head=err1, ref.master=46764a249766, ref.err1=5bc34397d59a), phabricator(head=almanac2, ref.master=8316c9dc14d5, ref.almanac2=8a5513aa815a, custom=17)
[Wed Feb 25 11:05:39.866259 2015] [:error] [pid 2132] [client 127.0.0.1:58544]   #0 PhabricatorHomeMainController::processRequest() called at [<phabricator>/src/aphront/AphrontController.php:33]
[Wed Feb 25 11:05:39.866274 2015] [:error] [pid 2132] [client 127.0.0.1:58544]   #1 AphrontController::handleRequest(AphrontRequest) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:196]
[Wed Feb 25 11:05:39.866280 2015] [:error] [pid 2132] [client 127.0.0.1:58544]   #2 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:121]
[Wed Feb 25 11:05:39.866283 2015] [:error] [pid 2132] [client 127.0.0.1:58544]   #3 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phabricator>/webroot/index.php:19]

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Put version information in stack traces.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.

For posterity, here's how to read this:

phabricator(head=almanac2, ref.master=8316c9dc14d5, ref.almanac2=8a5513aa815a, custom=17)

That means "the branch almanac2 is checked out, master is at 8136, almanac2 is at 8a55, there are 17 custom extension files".

I'm also using raw functions here instead of, e.g., Filesystem, to limit the chance that handling an error results in a second error. We'd much rather get this information wrong than create more errors or loop or crash or whatever.

  • Should be ksort(), not asort().
btrahan edited edge metadata.
This revision is now accepted and ready to land.Feb 25 2015, 7:56 PM
This revision was automatically updated to reflect the committed changes.