Page MenuHomePhabricator

Improve Python HMAC example in webhook documentation
AbandonedPublic

Authored by fwilson42 on Jun 26 2018, 2:33 AM.
Tags
None
Referenced Files
F14059663: D19508.diff
Sun, Nov 17, 9:02 PM
F14047161: D19508.diff
Thu, Nov 14, 2:23 AM
F14033660: D19508.diff
Sat, Nov 9, 7:02 PM
F14018816: D19508.diff
Tue, Nov 5, 7:45 PM
F13972838: D19508.diff
Oct 17 2024, 9:29 PM
Unknown Object (File)
Oct 7 2024, 9:22 PM
Unknown Object (File)
Oct 7 2024, 9:22 PM
Unknown Object (File)
Oct 7 2024, 11:47 AM
Subscribers
Tokens
"Hungry Hippo" token, awarded by yelirekim.

Details

Summary

This changes the example from a "subprocess" call out to PHP to use
Python's standard library "hmac" instead. This removes the dependency
on PHP; webhooks might not be run on a machine with it installed.

Test Plan

Run the PHP example with key = "test key" and body = "test body":

echo hash_hmac('sha256', 'test body', 'test key');
// => e327344d7533dfd50ceed6541c3ba412b06cc52b0cdfc900fcaf58992b470617

Run the Python example with the same parameters (Python 2):

>>> import hashlib
>>> import hmac
>>> hmac.new('test key', 'test body', hashlib.sha256).hexdigest()
'e327344d7533dfd50ceed6541c3ba412b06cc52b0cdfc900fcaf58992b470617'

And Python 3:

>>> import hashlib
>>> import hmac
>>> hmac.new(b'test key', b'test body', hashlib.sha256).hexdigest()
'e327344d7533dfd50ceed6541c3ba412b06cc52b0cdfc900fcaf58992b470617'

Note that all values are the same.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20453
Build 27780: arc lint + arc unit