HomePhabricator

Provide default values for table view properties which are `count`ed

Description

Provide default values for table view properties which are counted

Summary:
PHP 7.2 has changed the behavior of count, you must provide an array or Countable as a parameter, otherwise a warning is generated. These two class members are counted during rendering, and are commonly left as null properties.

https://wiki.php.net/rfc/counting_non_countables

Test Plan: Browsed around my install and stopped seeing count(): Parameter must be an array or an object that implements Countable at [AphrontTableView.php:153] everywhere.

Reviewers: Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D19140

Details

Provenance
yelirekimAuthored on Feb 25 2018, 8:12 PM
yelirekimPushed on Feb 25 2018, 9:54 PM
Reviewer
Blessed Reviewers
Differential Revision
D19140: Provide default values for table view properties which are `count`ed
Parents
rP4c7370a1a3b0: Make the filetree view width sticky across show/hide and reload
Branches
Unknown
Tags
Unknown
Build Status
Buildable 19658
Build 26621: Run Core Tests