Page MenuHomePhabricator
Differential D16624

Remove a flaky test which can fail under load
ClosedPublic
Actions

Authored by epriestley on Sep 28 2016, 10:10 PM.
Tags
None
Referenced Files
F14000299: D16624.id40023.diff
Thu, Oct 24, 8:58 PM
F13998612: D16624.id.diff
Thu, Oct 24, 10:14 AM
F13992238: D16624.diff
Tue, Oct 22, 3:23 PM
Unknown Object (File)
Sep 15 2024, 7:03 PM
Unknown Object (File)
Sep 14 2024, 6:19 PM
Unknown Object (File)
Sep 12 2024, 11:34 AM
Unknown Object (File)
Sep 12 2024, 11:33 AM
Unknown Object (File)
Sep 12 2024, 11:33 AM
View All Files
Subscribers
None
Tokens
"Y So Serious" token, awarded by yelirekim.

Details

Reviewers
chad
Commits
rPHU19ef6e504d26: Remove a flaky test which can fail under load
Summary

This test can fail incorrectly when the host is under load (e.g., several builds running simultaneously).

Essentially everything it tests is tested more reliably by adjacent tests.

Test Plan

Laughed robustly.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40023.Sep 28 2016, 10:10 PM
epriestley retitled this revision from to Remove a flaky test which can fail under load.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Sep 28 2016, 10:54 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 28 2016, 10:54 PM
Closed by commit rPHU19ef6e504d26: Remove a flaky test which can fail under load (authored by epriestley, committed by epriestley). · Explain WhySep 28 2016, 11:15 PM
This revision was automatically updated to reflect the committed changes.
yelirekim awarded a token.Sep 28 2016, 11:46 PM

Revision Contents
Changeset List

PathSize
src/
future/
exec/
__tests__/
12 lines

Diff 40026

View Options

src/future/exec/__tests__/ExecFutureTestCase.php

Loading...
Phabricator · Built by Phacility