Remove a flaky test which can fail under load
ClosedPublic
Actions

Authored by epriestley on Sep 28 2016, 10:10 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 19, 5:23 PM

	Unknown Object (File)
	Wed, Apr 17, 3:19 PM

	Unknown Object (File)
	Tue, Apr 9, 3:05 PM

	Unknown Object (File)
	Sun, Apr 7, 12:52 PM

	Unknown Object (File)
	Sun, Apr 7, 4:57 AM

	Unknown Object (File)
	Sun, Apr 7, 3:48 AM

	Unknown Object (File)
	Wed, Apr 3, 9:55 PM

	Unknown Object (File)
	Sat, Mar 30, 2:47 AM

View All Files

Subscribers

None

Tokens

"Y So Serious" token, awarded by yelirekim.

Details

Reviewers

chad

Commits

rPHU19ef6e504d26: Remove a flaky test which can fail under load

Summary

This test can fail incorrectly when the host is under load (e.g., several builds running simultaneously).

Essentially everything it tests is tested more reliably by adjacent tests.

Test Plan

Laughed robustly.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40023.Sep 28 2016, 10:10 PM

epriestley retitled this revision from to Remove a flaky test which can fail under load.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

chad accepted this revision.Sep 28 2016, 10:54 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 28 2016, 10:54 PM

Closed by commit rPHU19ef6e504d26: Remove a flaky test which can fail under load (authored by epriestley, committed by epriestley). · Explain WhySep 28 2016, 11:15 PM

This revision was automatically updated to reflect the committed changes.

yelirekim awarded a token.Sep 28 2016, 11:46 PM

Revision Contents
Changeset List

Path

Size

src/

future/

exec/

__tests__/

ExecFutureTestCase.php

12 lines

Diff 40026

View Options

src/future/exec/tests/ExecFutureTestCase.php

Remove a flaky test which can fail under loadClosedPublicActions