Page MenuHomePhabricator

Indicate that the "upload file" modal dialog is doing something when uploading large files
Closed, ResolvedPublic

Description

If you click the "upload file" button on a textarea, then select a large file, there is no indication that anything is happening, even though it will eventually work.

repro:

  1. cat /dev/urandom > bigfile.garbage for a while
  2. Click "upload file" on an input textarea somewhere
  3. Choose your big garbage file for upload
  4. Click upload
  5. Wait a while
  6. Eventually the file will upload

What happens here is that during step 5, users will click "upload" again, and again, thinking that nothing is happening. This becomes a self fulfilling prophecy at that point.

Event Timeline

What browser are you using? I get a progress bubble in the lower left immediately. Here's a screenshot -- note the blue upload progress element in the lower left corner.

Screen Shot 2018-01-31 at 7.05.48 PM.png (1×2 px, 245 KB)

We can maybe visually disable the form/dialog box when you click "Submit", I suppose (see T11145).

Ok I actually get a dialog on secure., it's probably because we're out of date with the upstream.

It's possible that adjusting SettingsNotifications to No Notifications disables this bubble, if that's a compounding factor here. D18600 pulled back some of the aggressiveness of that setting but I'd guess it might still be hitting the upload progress bubbles.

We don't have a notifications server, does that make it like that?

Not unless something super weird/buggy is going on.

Hm, actually the problem here is that the notification bubble doesn't show up for any file uploads on our current version. I suppose it could actually be "on our current version + extensions". I'll get a reproduction matrix together tomorrow.

Locally, seems like "No Notifications" correctly has no effect on the "Upload" bubble being shown at HEAD of master.

If you're running something between D18457 (Aug 23) and D18600 above (Sep 13), the "No Notifications" setting was ridiculously strong but if you're more recent than that I can't think of any changes we've made recently-ish here.

From rereading D18600, maybe "ridiculously strong" is an understatement and it was actually so powerful it took effect even if you didn't enable it.

Here I was thinking I found a helpful public bug.

epriestley claimed this task.

Presuming this is a version issue or evil spirits or something until some contrary evidence surfaces.