Page MenuHomePhabricator

Provide default values for table view properties which are `count`ed
ClosedPublic

Authored by yelirekim on Feb 25 2018, 8:19 PM.
Tags
None
Referenced Files
F13905495: D19140.id45847.diff
Mon, Oct 7, 9:09 PM
F13905494: D19140.id45846.diff
Mon, Oct 7, 9:09 PM
F13905493: D19140.id.diff
Mon, Oct 7, 9:08 PM
Unknown Object (File)
Sat, Oct 5, 9:48 PM
Unknown Object (File)
Tue, Sep 10, 8:14 PM
Unknown Object (File)
Tue, Sep 10, 6:21 PM
Unknown Object (File)
Tue, Sep 10, 12:49 AM
Unknown Object (File)
Sep 4 2024, 11:39 AM
Subscribers

Details

Summary

PHP 7.2 has changed the behavior of count, you must provide an array or Countable as a parameter, otherwise a warning is generated. These two class members are counted during rendering, and are commonly left as null properties.

https://wiki.php.net/rfc/counting_non_countables

Test Plan

Browsed around my install and stopped seeing count(): Parameter must be an array or an object that implements Countable at [AphrontTableView.php:153] everywhere.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

yelirekim edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Feb 25 2018, 8:31 PM

(See D18964 previously -- I'm still on 7.1 locally so there may be a few more of these lurking around.)

This revision was automatically updated to reflect the committed changes.