Page MenuHomePhabricator

Expose Drydock blueprints via Conduit
ClosedPublic

Authored by yelirekim on Sep 24 2016, 7:00 AM.
Tags
None
Referenced Files
F13905194: D16593.id40218.diff
Mon, Oct 7, 7:44 PM
F13905192: D16593.id40217.diff
Mon, Oct 7, 7:44 PM
F13905191: D16593.id39944.diff
Mon, Oct 7, 7:44 PM
F13905190: D16593.id.diff
Mon, Oct 7, 7:44 PM
Unknown Object (File)
Sat, Oct 5, 9:55 PM
Unknown Object (File)
Thu, Oct 3, 9:53 PM
Unknown Object (File)
Thu, Oct 3, 9:32 PM
Unknown Object (File)
Tue, Oct 1, 5:18 AM
Subscribers

Details

Summary

This search engine ports cleanly to Conduit out of the box.

Ref T11694

Test Plan

called the API method from the console, browsed blueprints in the ui

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

yelirekim retitled this revision from to Expose Drydock blueprints via Conduit.
yelirekim updated this object.
yelirekim edited the test plan for this revision. (Show Details)
epriestley added a reviewer: epriestley.

Is class useful today? If not, maybe omit it?

If you do need it, I think we should give BlueprintImplementation classes a type constant and use that instead -- e.g., drydock.workingcopy instead of DrydockWorkingCopyBlueprintImplementation as the thing that clients deal with. In the past, we did more "just use the class name" stuff since it seemed like a waste of effort and like code duplication to define constants, but have generally moved away from that for several reasons:

  • class names are cumbersome identifiers for humans (moreso if/when we run into PHP namespaces);
  • in practice, we rename classes with some frequency (T5655), and when changes occur, remapping bare class names is super confusing but migrating them is a pain;
  • PhutilClassMapQuery introduced some tools to make using string identifiers easier.
This revision is now accepted and ready to land.Sep 26 2016, 1:44 PM
yelirekim edited edge metadata.

remove class from conduit fields

This revision was automatically updated to reflect the committed changes.