Page MenuHomePhabricator
Feed All Stories

Apr 25 2023

cspeckmim updated the diff for D21861: Fix support for pk-zip compressed figlet font files.

Fix the implementation of using pk-zip compressed figlet font files

Apr 25 2023, 7:20 PM
cspeckmim planned changes to D21861: Fix support for pk-zip compressed figlet font files.

Okay I figured out what was happening.

  1. We observed the issue with using {} as index operator on our production server
  2. I updated the Figlet.php on our production server to fix the indexing issue
  3. This resulted in getting the zip_open issue, which this error result was cached (return raiseError() vs. a 500 php error)
  4. I applied the index issue change and the zip_open change to our test environment and was able to load the diff that was failing in production
  5. Someone had previously installed a bunch of figlet fonts on our production server but it was after the last time we duplicated production to our test server - so the tests I was running in our test environment never hit the zip issue directly.
  6. On the production server many of the fonts are PK-zip compressed however have the .flf extension. I had been looking for .zip or .tar.gz files so I had assumed none of the fonts installed were compressed.
Apr 25 2023, 6:52 PM
epriestley added a comment to D21861: Fix support for pk-zip compressed figlet font files.

I'm a little confused about how we ever hit the test for zip_open() (or whatever prompted the original change in D21860) if you don't have any custom compressed fonts and Phabricator doesn't ship with any custom compressed fonts? This change looks good to me, but how did we run into a problem in the first place?

Apr 25 2023, 5:13 PM
cspeckmim added inline comments to D21861: Fix support for pk-zip compressed figlet font files.
Apr 25 2023, 4:24 PM
cspeckmim added a comment to D21861: Fix support for pk-zip compressed figlet font files.

I'm not sure why the change D21860 did not work to decompress the tar/gzip figlet file

Apr 25 2023, 3:54 PM
cspeckmim added a comment to D21861: Fix support for pk-zip compressed figlet font files.

Sorry for jumping the gun on landing that previous one. To my surprise we didn't even have any custom figlet font files installed previously. I did some more thorough testing with this change to ensure that custom figlet font files still work properly, unless they're compressed. I'm not sure why the change D21860 did not work to decompress the tar/gzip figlet file but if it's not worth supporting I prefer to remove the complexity.

Apr 25 2023, 3:46 PM
cspeckmim requested review of D21861: Fix support for pk-zip compressed figlet font files.
Apr 25 2023, 3:35 PM
cspeckmim added a comment to D21860: Update Figlet implementation to be PHP8 compatible.

Oh whoops. I didn't realize figlet font file format wasn't compressed

Apr 25 2023, 3:04 PM
epriestley added a comment to D21860: Update Figlet implementation to be PHP8 compatible.

(It would also probably be fine to just remove support for compressed figlet fonts, they're probably saving like 5KB?)

Apr 25 2023, 3:03 PM
cspeckmim closed D21860: Update Figlet implementation to be PHP8 compatible.
Apr 25 2023, 3:03 PM
cspeckmim committed rPd5c63c86e7e4: Update Figlet implementation to be PHP8 compatible (authored by cspeckmim).
Update Figlet implementation to be PHP8 compatible
Apr 25 2023, 3:03 PM
epriestley accepted D21860: Update Figlet implementation to be PHP8 compatible.

Thanks!

Apr 25 2023, 2:59 PM
cspeckmim added a revision to T13588: PHP 8 Compatibility: D21860: Update Figlet implementation to be PHP8 compatible.
Apr 25 2023, 2:53 PM · Infrastructure
cspeckmim requested review of D21860: Update Figlet implementation to be PHP8 compatible.
Apr 25 2023, 2:53 PM

Apr 6 2023

sekimura updated sekimura.
Apr 6 2023, 12:34 AM

Apr 1 2023

cspeckmim added a comment to D21859: Update the arc-hg.py extension to work with mercurial 6.4.

Thank you it’s very appreciated!

Apr 1 2023, 6:37 PM
epriestley added a comment to D21859: Update the arc-hg.py extension to work with mercurial 6.4.

I also cherry-picked this to stable, since I don't have any specific plans around when I'm going to cut the next release right now.

Apr 1 2023, 1:59 PM
epriestley committed rARC60446ec65cfa: (stable) Update the arc-hg.py extension to work with mercurial 6.4 (authored by cspeckmim).
(stable) Update the arc-hg.py extension to work with mercurial 6.4
Apr 1 2023, 1:58 PM
epriestley added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

If the small pipe needs to drain into the big one, how about taking a large pvc end-cap, drilling a 1/4" hold and forcing the smaller pipe in it?

Apr 1 2023, 1:58 PM · Hardware
avivey added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

If the small pipe needs to drain into the big one, how about taking a large pvc end-cap, drilling a 1/4" hold and forcing the smaller pipe in it? Maybe seal the whole thing with some silicone.

Apr 1 2023, 10:14 AM · Hardware
cspeckmim closed D21859: Update the arc-hg.py extension to work with mercurial 6.4.
Apr 1 2023, 3:28 AM
cspeckmim committed rARC0fc22183e796: Update the arc-hg.py extension to work with mercurial 6.4 (authored by cspeckmim).
Update the arc-hg.py extension to work with mercurial 6.4
Apr 1 2023, 3:28 AM

Mar 31 2023

epriestley added a comment to T13689: A Considered Review: 3D Printing.

I've been using Fusion 360, which I'd say is "not bad". (See also T13697, perhaps.)

Mar 31 2023, 10:41 PM · Hardware
Korvin added a comment to T13689: A Considered Review: 3D Printing.

I'm curious what 3d modeling software you use, I've had success making simple boxes and things like that with sketchup but I've been a little intimidated by more advanced modeling software.

Mar 31 2023, 9:11 PM · Hardware
epriestley accepted D21859: Update the arc-hg.py extension to work with mercurial 6.4.

Thanks!

Mar 31 2023, 1:25 PM
cspeckmim requested review of D21859: Update the arc-hg.py extension to work with mercurial 6.4.
Mar 31 2023, 3:17 AM

Mar 2 2023

epriestley added a comment to T13693: Address various issues with Bernina B740 Sewing Machine.

...I suspect that's a difficult geometry for FDM in PLA.

Mar 2 2023, 5:46 PM · Hardware
epriestley added a comment to T13693: Address various issues with Bernina B740 Sewing Machine.

These sewing machine shaft collars are kind of tricky: thread unspools around them, so the inward face must have a completely smooth edge that can't catch or snag. This rules out a simple clamping-style shaft collar with a slit in it.

Mar 2 2023, 6:33 AM · Hardware
epriestley added a comment to T13693: Address various issues with Bernina B740 Sewing Machine.

Spool Cap (Small)

Mar 2 2023, 6:13 AM · Hardware

Feb 17 2023

epriestley edited the content of Changelog.
Feb 17 2023, 6:49 PM
epriestley renamed 2023 Week 7 (Mid February) from 2023 Week 7 to 2023 Week 7 (Mid February).
Feb 17 2023, 6:47 PM
epriestley created an object: 2023 Week 7 (Mid February).
Feb 17 2023, 6:47 PM
epriestley closed D21858: Fix file PHID extraction in Pholio.
Feb 17 2023, 6:36 PM
epriestley committed rPa83cb99e856a: Fix file PHID extraction in Pholio (authored by epriestley).
Fix file PHID extraction in Pholio
Feb 17 2023, 6:36 PM
epriestley updated the task description for T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default".
Feb 17 2023, 6:35 PM · Remarkup
epriestley requested review of D21858: Fix file PHID extraction in Pholio.
Feb 17 2023, 6:30 PM
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21858: Fix file PHID extraction in Pholio.
Feb 17 2023, 6:30 PM · Remarkup

Feb 7 2023

epriestley closed T13697: Stop Fusion360 from arbitrarily stealing focus on MacOS as Resolved.

ADPClientService is a (currently) non-essential background service that collects juicy user data to send to Autodesk, since there's no way they could be expected to make ends meet on just $545/year licenses alone. You can find lots of threads about how to disable it in various Autodesk products, but none of these instructions appear to work in the current version of Fusion 360.

Feb 7 2023, 5:36 AM · Hardware

Feb 5 2023

epriestley added a comment to T13697: Stop Fusion360 from arbitrarily stealing focus on MacOS.
...
Focus taken by Safari.
Focus taken by ADPClientService.
Focus taken by Safari.
...
Feb 5 2023, 3:54 PM · Hardware

Feb 4 2023

epriestley added a comment to T13697: Stop Fusion360 from arbitrarily stealing focus on MacOS.

It stopped doing it as soon as I started watching it. But just wait, I'll catch it in the act. >_> <_<

Feb 4 2023, 10:03 PM · Hardware
epriestley triaged T13697: Stop Fusion360 from arbitrarily stealing focus on MacOS as Low priority.
Feb 4 2023, 3:49 PM · Hardware
epriestley updated the summary of D21857: Remove call to PHP "utf8_decode()" in "phutil_utf8_strlen()".
Feb 4 2023, 1:56 PM
epriestley updated the summary of D21857: Remove call to PHP "utf8_decode()" in "phutil_utf8_strlen()".
Feb 4 2023, 1:55 PM
epriestley closed D21857: Remove call to PHP "utf8_decode()" in "phutil_utf8_strlen()".
Feb 4 2023, 1:54 PM
epriestley committed rARCd87d5f0e02e2: Remove call to PHP "utf8_decode()" in "phutil_utf8_strlen()" (authored by epriestley).
Remove call to PHP "utf8_decode()" in "phutil_utf8_strlen()"
Feb 4 2023, 1:54 PM
epriestley added a comment to D21857: Remove call to PHP "utf8_decode()" in "phutil_utf8_strlen()".

An easy optimization here is likely to avoid calling phutil_utf8v(...) on very long strings using a strategy like this:

Feb 4 2023, 1:53 PM
epriestley updated the diff for D21857: Remove call to PHP "utf8_decode()" in "phutil_utf8_strlen()".
  • Slightly smaller diff.
Feb 4 2023, 1:51 PM
epriestley requested review of D21857: Remove call to PHP "utf8_decode()" in "phutil_utf8_strlen()".
Feb 4 2023, 1:50 PM
epriestley added a revision to T13588: PHP 8 Compatibility: D21857: Remove call to PHP "utf8_decode()" in "phutil_utf8_strlen()".
Feb 4 2023, 1:50 PM · Infrastructure
epriestley closed D21856: Correct a PHP8 compatibility issue when running "arc diff" with no active branch.
Feb 4 2023, 1:16 PM
epriestley committed rARCc39ab20eb371: Correct a PHP8 compatibility issue when running "arc diff" with no active branch (authored by epriestley).
Correct a PHP8 compatibility issue when running "arc diff" with no active branch
Feb 4 2023, 1:16 PM
epriestley requested review of D21856: Correct a PHP8 compatibility issue when running "arc diff" with no active branch.
Feb 4 2023, 1:03 PM
epriestley added a revision to T13588: PHP 8 Compatibility: D21856: Correct a PHP8 compatibility issue when running "arc diff" with no active branch.
Feb 4 2023, 1:03 PM · Infrastructure

Jan 23 2023

epriestley added a comment to T13689: A Considered Review: 3D Printing.

They sell "broken" Ender 3 printers on eBay for like $75 shipped. I ordered two. One had a bad board (a $40 part); one had a bad Y limit switch (a $3 part) -- so the actual cost per printer seems to be around ~$100 if you're familiar with how they work and can identify which parts aren't working.

Jan 23 2023, 7:36 PM · Hardware

Dec 22 2022

epriestley updated the task description for T13696: FAQ: Pocket Hole Joinery.
Dec 22 2022, 9:02 PM · Hardware

Dec 21 2022

epriestley triaged T13696: FAQ: Pocket Hole Joinery as Normal priority.
Dec 21 2022, 9:37 PM · Hardware
epriestley closed T13694: Create a "BRK/First Alert" smoke detector connector adapter as Resolved.

I traced the alarms back to Breaker #8 in Panel #2 (the detector tool actually worked okay this time). I disconnected the breaker and verified that killed the circuit. I swapped the alarms and updated the map of known breakers with this new information:

Dec 21 2022, 4:42 AM · Hardware

Dec 20 2022

epriestley added a comment to T13692: Build a portable motorized vehicle for a 3 year old.

No great surprise, but the blue boards seem about the same as the red boards and have the same problems:

Dec 20 2022, 5:29 AM · Hardware
epriestley added a comment to T13694: Create a "BRK/First Alert" smoke detector connector adapter.

The genuine article is not a JST-VH 4-pin connector -- the connecting clip is a little different, and there's no hole in the housing for (unused) pin #2. However, the pin size and spacing is right, so you can cut the connecting clip off a JST-VH and melt one of the pins out and the connector will fit well enough.

Dec 20 2022, 12:46 AM · Hardware

Dec 16 2022

epriestley added a comment to T13692: Build a portable motorized vehicle for a 3 year old.

I bought an oscilloscope and tested the speed signal of one of the new red boards once it arrived. The scope showed the perfectly sensible signal I expected, and the signal came off the board fine once I hooked it up. So maybe the first couple boards were legitimately bad?

Dec 16 2022, 10:35 PM · Hardware
epriestley added a comment to T13694: Create a "BRK/First Alert" smoke detector connector adapter.

This connector has a 4mm pin pitch, but I had a great deal of difficulty finding a likely-seeming bare connector with a 4mm pitch. After resigning myself to a Digikey quest for a connector that will fit a board on T13692, which also has a "4mm" pitch I realize the pitch is probably not 4mm but 3.96mm -- a wonderful pitch for which many connectors are readily available.

Dec 16 2022, 10:13 PM · Hardware
epriestley closed T13695: Improve performance of "MAXX Action Police Pursuit" vehicle as Resolved.

Here's the updated lightbar:

Dec 16 2022, 1:19 AM · Hardware

Dec 14 2022

epriestley added a comment to T13694: Create a "BRK/First Alert" smoke detector connector adapter.

Here's my nice safe smoke detector power adapter:

Dec 14 2022, 11:23 PM · Hardware
epriestley added a comment to T13695: Improve performance of "MAXX Action Police Pursuit" vehicle.

There doesn't seem to be anything mechanically wrong with the toy, although the motor and gearbox don't seem to be accessible without breaking something.

Dec 14 2022, 12:46 AM · Hardware
epriestley triaged T13695: Improve performance of "MAXX Action Police Pursuit" vehicle as Normal priority.
Dec 14 2022, 12:06 AM · Hardware

Dec 13 2022

epriestley triaged T13694: Create a "BRK/First Alert" smoke detector connector adapter as Normal priority.
Dec 13 2022, 11:46 PM · Hardware

Dec 5 2022

epriestley added a comment to T13692: Build a portable motorized vehicle for a 3 year old.

The capacitors on both boards arrived pretty banged up.

Dec 5 2022, 8:05 PM · Hardware
ggodlewski updated ggodlewski.
Dec 5 2022, 10:48 AM

Dec 3 2022

epriestley added a comment to T13693: Address various issues with Bernina B740 Sewing Machine.

String Shelf

Dec 3 2022, 7:36 AM · Hardware
epriestley attached a referenced file: F11291992: Screen Shot 2022-11-03 at 4.23.07 PM.png.
Dec 3 2022, 7:07 AM · Hardware
epriestley added a comment to T13693: Address various issues with Bernina B740 Sewing Machine.

Turny Thing

Dec 3 2022, 7:07 AM · Hardware
epriestley triaged T13693: Address various issues with Bernina B740 Sewing Machine as Normal priority.
Dec 3 2022, 6:52 AM · Hardware
epriestley added a comment to T13692: Build a portable motorized vehicle for a 3 year old.

Motor Drivers

Dec 3 2022, 6:18 AM · Hardware

Dec 1 2022

epriestley triaged T13692: Build a portable motorized vehicle for a 3 year old as Normal priority.
Dec 1 2022, 4:02 PM · Hardware

Nov 22 2022

epriestley triaged T13691: Prevent 2015 Audi Q3 radio from playing music on vehicle start as Normal priority.
Nov 22 2022, 9:51 PM · Hardware

Nov 20 2022

kaidowei updated kaidowei.
Nov 20 2022, 10:19 PM

Nov 4 2022

epriestley added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

Couple of years ago the furnace wasn't working so well. Light comes on, three reds. Pressure switch stuck open. I take off a panel, pull the pressure switches. The contacts close properly. No clue what's wrong. Call an HVAC guy. He's pretty busy. No problem, we got plenty of sweaters. Ha. He makes it out early the next week.

Nov 4 2022, 4:04 AM · Hardware
jmeador added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

all my drains are belong to PVC

Nov 4 2022, 2:28 AM · Hardware
epriestley added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

... condensate drain ...

Nov 4 2022, 12:28 AM · Hardware
epriestley triaged T13690: A Considered Review: PCB Manufacturing as Wishlist priority.
Nov 4 2022, 12:21 AM · Hardware
epriestley added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

...there's enough absorbent material underneath the sink...

Nov 4 2022, 12:05 AM · Hardware

Nov 3 2022

epriestley updated the task description for T13689: A Considered Review: 3D Printing.
Nov 3 2022, 11:44 PM · Hardware
epriestley triaged T13689: A Considered Review: 3D Printing as Wishlist priority.
Nov 3 2022, 11:43 PM · Hardware
jmeador added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

(You don't actually need a leak detector, I think there's enough absorbent material underneath the sink to last a long while before it damages the floor)

Nov 3 2022, 10:01 PM · Hardware
jmeador added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

Here is my bathroom sink. The right-most pipe coming out of the wall is the condensate drain from HVAC. The tailpiece is most definitely 1 1/4 and the rest of the piping is 1 1/2, at least to the naked eye.

Nov 3 2022, 9:41 PM · Hardware
epriestley added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

I can't see a way to make the trap be any less garbage than it is because the 4" flanged tailpipe (the shortest flanged 1-1/4" tailpipe I could find) plus an additional 8" of tailpipe underneath it (the only 1-1/4" branch tailpipe I could find, which is only available with a slip fitting) means that the bottom of the lower tailpipe is super low. It looks like I left an extra 6" of flexible pipe on the drain side for fun, but that's just the rigid bottom of the tailpipe plus the minimum bend radius without making the flexible pipe start to crimp -- the bottom of the tailpipe is like 1-1/2" below the black plastic retainer clip.

Nov 3 2022, 9:09 PM · Hardware
jmeador added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

A few more thoughts:

Nov 3 2022, 8:31 PM · Hardware
epriestley added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

Since there's no fresh water supply to the dehumidifier I don't think there's much benefit to an air gap, as there's no way backflow could ever contaminate a supply line. A clogged sink drain could possibly drain sink water out through the dehumidifier bucket, but the top of the drain line is only ~1"-2" below the top of the sink so it would overflow the basin onto the floor before very long anyway.

Nov 3 2022, 8:14 PM · Hardware
jmeador added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

My terminology might be wrong throughout this but a couple thoughts:

Nov 3 2022, 4:51 PM · Hardware

Oct 26 2022

epriestley added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

Other options I explored and rejected:

Oct 26 2022, 8:42 PM · Hardware
epriestley triaged T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe? as Wishlist priority.
Oct 26 2022, 8:34 PM · Hardware
epriestley created Hardware.
Oct 26 2022, 8:32 PM
epriestley added a comment to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default".
  • Inline Comments: See PHI2217. See PHI2206. Inline comments don't currently attach images.
  • Destroying Edges: See PHI2201. See PHI2217. Destroying files that have old edge types may raise warnings. The destruction still works, although it doesn't hit the edges.
  • Destroying Files: See PHI2217. Destroying an object doesn't destroy corresponding FileAttachment objects, so you can end up with ghosts in the UI.
Oct 26 2022, 8:08 PM · Remarkup
epriestley closed T13683: Security Guidance: References to Files in Remarkup as Resolved.

There are some remaining non-security bugs with this that I'll follow up on in T13682. I believe the security side of this is now resolved.

Oct 26 2022, 8:03 PM · Guides, Files, Security
epriestley added a comment to T13683: Security Guidance: References to Files in Remarkup .

The details of this attack will be disclosed at a later date, once installs have had some sort of plausible chance to upgrade.

Oct 26 2022, 8:01 PM · Guides, Files, Security
epriestley added a comment to T13684: Drydock resource accounting may put significant stress on the MySQL binlog if a lease is unsatisfiable.

An earlier patch here (rCORE6d6170f76463) swapped binlogs to MIXED and set a 24-hour retention policy. This issue has not reoccurred in the cluster since that patch went out, but the root causes remain unresolved.

Oct 26 2022, 7:58 PM · Drydock
epriestley closed T13685: "RemarkupField" returns "RemarkupValue" when editing defaults, which fails to survive serialization as Resolved.

I filed T13687 as a followup for preventing this particular sort of error (where a Phobject is incorrectly serialized directly).

Oct 26 2022, 7:56 PM · EditEngine, Files
epriestley triaged T13687: Consider implementing "JsonSerializable" in Phobject to forbid serialization as Wishlist priority.
Oct 26 2022, 7:56 PM · Infrastructure
epriestley closed T13686: Disable Ubuntu unattended upgrades as Resolved.

I patched and partially deployed this in early August. Another unattended MySQL upgrade went out on Monday night, also didn't restart MySQL on affected hosts, and caused some downtime on hosts that didn't have the patch (to "disable unattended upgrades"). I've now deployed this everywhere, and am presuming this is fixed until evidence arises to the contrary.

Oct 26 2022, 7:53 PM · Phacility

Oct 25 2022

epriestley added a comment to T13686: Disable Ubuntu unattended upgrades.

See also PHI2219, PHI2220.

Oct 25 2022, 12:17 PM · Phacility