Page MenuHomePhabricator
Feed All Stories

Aug 23 2019

epriestley closed D20697: Refactor the Phortune account detail page into a series of smaller, more focused sections.
Aug 23 2019, 3:56 AM
epriestley requested review of D20733: Update Phortune Merchant UI to bring it in line with Account UI.
Aug 23 2019, 3:55 AM
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: D20733: Update Phortune Merchant UI to bring it in line with Account UI.
Aug 23 2019, 3:54 AM · Phortune, Phacility

Aug 22 2019

epriestley requested review of D20732: Update Charge and Cart policies in Phortune, and make URIs more consistent.
Aug 22 2019, 10:00 PM
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: D20732: Update Charge and Cart policies in Phortune, and make URIs more consistent.
Aug 22 2019, 9:59 PM · Phortune, Phacility
epriestley added a comment to T13367: Phortune "enterprise" update errata.

We're also using inconsistent icons for "Order/Invoice/Receipt/Cart" in different interfaces. I'm going to standardize on this lovely purse, I think:

Aug 22 2019, 9:50 PM · Phortune, Phacility
epriestley added a comment to T13385: Get rid of "sourcePath" and "sourceMachine" as Diff attributes.

sourceMachine is currently exposed only in the UI.

Aug 22 2019, 8:53 PM · Differential
epriestley committed rPecbc82da33c5: Expose "commits.add|set|remove" on "maniphest.edit" API calls (authored by epriestley).
Expose "commits.add|set|remove" on "maniphest.edit" API calls
Aug 22 2019, 8:34 PM
epriestley closed D20731: Expose "commits.add|set|remove" on "maniphest.edit" API calls.
Aug 22 2019, 8:34 PM
epriestley committed rP353155a2034e: Add "modifiedStart" and "modifiedEnd" constraints to "differential.revision. (authored by epriestley).
Add "modifiedStart" and "modifiedEnd" constraints to "differential.revision.
Aug 22 2019, 8:34 PM
epriestley closed D20730: Add "modifiedStart" and "modifiedEnd" constraints to "differential.revision.search".
Aug 22 2019, 8:34 PM
epriestley closed T13386: Offset paging in "differential.query" can overheat with a nonsensical error message as Resolved by committing rP353155a2034e: Add "modifiedStart" and "modifiedEnd" constraints to "differential.revision..
Aug 22 2019, 8:34 PM · ApplicationSearch, Differential
epriestley requested review of D20731: Expose "commits.add|set|remove" on "maniphest.edit" API calls.
Aug 22 2019, 8:33 PM
epriestley requested review of D20730: Add "modifiedStart" and "modifiedEnd" constraints to "differential.revision.search".
Aug 22 2019, 8:23 PM
epriestley added a revision to T13386: Offset paging in "differential.query" can overheat with a nonsensical error message: D20730: Add "modifiedStart" and "modifiedEnd" constraints to "differential.revision.search".
Aug 22 2019, 8:21 PM · ApplicationSearch, Differential
epriestley committed rP109d7dcaf197: Convert "Empower" from state-based MFA to one-shot MFA (authored by epriestley).
Convert "Empower" from state-based MFA to one-shot MFA
Aug 22 2019, 3:35 PM
epriestley closed D20729: Convert "Empower" from state-based MFA to one-shot MFA.
Aug 22 2019, 3:34 PM
epriestley requested review of D20729: Convert "Empower" from state-based MFA to one-shot MFA.
Aug 22 2019, 2:08 PM
epriestley added a revision to T13382: Update various user account CLI tools: D20729: Convert "Empower" from state-based MFA to one-shot MFA.
Aug 22 2019, 2:07 PM · People
epriestley committed rPf1b054a20fd5: Correct the interaction between overheating and offset-based paging (authored by epriestley).
Correct the interaction between overheating and offset-based paging
Aug 22 2019, 3:27 AM
epriestley closed D20728: Correct the interaction between overheating and offset-based paging.
Aug 22 2019, 3:27 AM
epriestley requested review of D20728: Correct the interaction between overheating and offset-based paging.
Aug 22 2019, 3:18 AM
epriestley added a revision to T13386: Offset paging in "differential.query" can overheat with a nonsensical error message: D20728: Correct the interaction between overheating and offset-based paging.
Aug 22 2019, 3:16 AM · ApplicationSearch, Differential
epriestley triaged T13386: Offset paging in "differential.query" can overheat with a nonsensical error message as Normal priority.
Aug 22 2019, 2:45 AM · ApplicationSearch, Differential
epriestley committed rP5741514aeb5b: When a client submits an overlong "sourcePath", truncate it and continue (authored by epriestley).
When a client submits an overlong "sourcePath", truncate it and continue
Aug 22 2019, 2:28 AM
epriestley closed D20727: When a client submits an overlong "sourcePath", truncate it and continue.
Aug 22 2019, 2:28 AM
epriestley requested review of D20727: When a client submits an overlong "sourcePath", truncate it and continue.
Aug 22 2019, 2:17 AM
epriestley added a revision to T13385: Get rid of "sourcePath" and "sourceMachine" as Diff attributes: D20727: When a client submits an overlong "sourcePath", truncate it and continue.
Aug 22 2019, 2:16 AM · Differential
epriestley renamed T13385: Get rid of "sourcePath" and "sourceMachine" as Diff attributes from Get rid of "sourcePath" and "host" as Diff attributes to Get rid of "sourcePath" and "sourceMachine" as Diff attributes.
Aug 22 2019, 2:11 AM · Differential
epriestley created T13385: Get rid of "sourcePath" and "sourceMachine" as Diff attributes.
Aug 22 2019, 2:05 AM · Differential
epriestley committed rPc4399313737b: Respect "disabled" custom field status granted by "subtype" configuration in… (authored by epriestley).
Respect "disabled" custom field status granted by "subtype" configuration in…
Aug 22 2019, 1:03 AM
epriestley closed D20726: Respect "disabled" custom field status granted by "subtype" configuration in form validation.
Aug 22 2019, 1:03 AM
epriestley closed T13384: When a custom field is "disabled", that should take precedence over the field being "required" as Resolved by committing rPc4399313737b: Respect "disabled" custom field status granted by "subtype" configuration in….
Aug 22 2019, 1:03 AM · Custom Fields
epriestley added a revision to T13384: When a custom field is "disabled", that should take precedence over the field being "required": D20726: Respect "disabled" custom field status granted by "subtype" configuration in form validation.
Aug 22 2019, 1:02 AM · Custom Fields
epriestley updated the task description for T13384: When a custom field is "disabled", that should take precedence over the field being "required".
Aug 22 2019, 12:52 AM · Custom Fields
epriestley updated the task description for T13384: When a custom field is "disabled", that should take precedence over the field being "required".
Aug 22 2019, 12:47 AM · Custom Fields
epriestley triaged T13384: When a custom field is "disabled", that should take precedence over the field being "required" as Normal priority.
Aug 22 2019, 12:47 AM · Custom Fields

Aug 21 2019

epriestley committed rP64b399d9be26: Remove "bin/accountadmin" and "scripts/user/add_user.php" (authored by epriestley).
Remove "bin/accountadmin" and "scripts/user/add_user.php"
Aug 21 2019, 12:58 AM
epriestley closed D20725: Remove "bin/accountadmin" and "scripts/user/add_user.php".
Aug 21 2019, 12:58 AM
epriestley closed T13382: Update various user account CLI tools as Resolved by committing rP64b399d9be26: Remove "bin/accountadmin" and "scripts/user/add_user.php".
Aug 21 2019, 12:58 AM · People
epriestley added a comment to T13382: Update various user account CLI tools.

./bin/user create

Aug 21 2019, 12:55 AM · People
epriestley committed rPfc34554892ec: Replace "bin/people profileimage" with "bin/user enable|empower" (authored by epriestley).
Replace "bin/people profileimage" with "bin/user enable|empower"
Aug 21 2019, 12:51 AM
epriestley closed D20724: Replace "bin/people profileimage" with "bin/user enable|empower".
Aug 21 2019, 12:51 AM
epriestley requested review of D20725: Remove "bin/accountadmin" and "scripts/user/add_user.php".
Aug 21 2019, 12:47 AM
epriestley added a revision to T13382: Update various user account CLI tools: D20725: Remove "bin/accountadmin" and "scripts/user/add_user.php".
Aug 21 2019, 12:45 AM · People

Aug 20 2019

epriestley requested review of D20724: Replace "bin/people profileimage" with "bin/user enable|empower".
Aug 20 2019, 9:47 PM
epriestley added a revision to T13382: Update various user account CLI tools: D20724: Replace "bin/people profileimage" with "bin/user enable|empower".
Aug 20 2019, 9:45 PM · People
epriestley added a comment to T13382: Update various user account CLI tools.

You can automate at least some administrative actions...

Aug 20 2019, 9:35 PM · People
epriestley committed rP721a86401ff4: Implement "drydock.resource.search" (authored by epriestley).
Implement "drydock.resource.search"
Aug 20 2019, 8:07 PM
epriestley closed T13383: Provide a "drydock.resource.search" API method as Resolved by committing rP721a86401ff4: Implement "drydock.resource.search".
Aug 20 2019, 8:07 PM · Conduit, Drydock
epriestley closed D20723: Implement "drydock.resource.search".
Aug 20 2019, 8:07 PM
epriestley updated the diff for D20723: Implement "drydock.resource.search".
  • Fix copy/paste "Buildables" vs "Blueprints" mistake.
Aug 20 2019, 8:04 PM
epriestley requested review of D20723: Implement "drydock.resource.search".
Aug 20 2019, 8:04 PM
epriestley added a revision to T13383: Provide a "drydock.resource.search" API method: D20723: Implement "drydock.resource.search".
Aug 20 2019, 8:02 PM · Conduit, Drydock
epriestley committed rP803eb29c71d3: Fix flag typo in "Managing Caches" documentation (authored by epriestley).
Fix flag typo in "Managing Caches" documentation
Aug 20 2019, 7:36 PM
epriestley closed D20722: Fix flag typo in "Managing Caches" documentation.
Aug 20 2019, 7:36 PM
epriestley requested review of D20722: Fix flag typo in "Managing Caches" documentation.
Aug 20 2019, 7:31 PM
epriestley edited the content of Changelog.
Aug 20 2019, 4:05 PM
epriestley committed rPf74f953c7d26: (stable) Promote 2019 Week 33 (authored by epriestley).
(stable) Promote 2019 Week 33
Aug 20 2019, 4:04 PM
epriestley created an object: 2019 Week 33 (Mid August).
Aug 20 2019, 4:04 PM
epriestley triaged T13383: Provide a "drydock.resource.search" API method as Normal priority.
Aug 20 2019, 3:52 PM · Conduit, Drydock
epriestley updated the task description for T13072: Merge Harbormaster BuildCommand into BuildMessage.
Aug 20 2019, 3:50 PM · Harbormaster
epriestley added a comment to T13382: Update various user account CLI tools.

(You can automate at least some administrative actions at an "omnipotent" power level with bin/conduit call --method user.edit nowadays, too, although accountadmin operated with interactive prompts so it's unlikely anyone automated on top of it.)

Aug 20 2019, 2:11 PM · People
epriestley triaged T13382: Update various user account CLI tools as Normal priority.
Aug 20 2019, 2:08 PM · People

Aug 17 2019

epriestley requested review of D20721: Update Phortune subscriptions for modern infrastructure.
Aug 17 2019, 2:52 AM
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: D20721: Update Phortune subscriptions for modern infrastructure.
Aug 17 2019, 2:51 AM · Phortune, Phacility

Aug 16 2019

epriestley added a comment to T13366: Update Phortune to work better with "enterprise" billing/accounts departments.

Stuff to fix with subscriptions:

Aug 16 2019, 10:51 PM · Phortune, Phacility
epriestley requested review of D20720: When a page throws an exception and response construction throws another exception, throw an aggregate exception.
Aug 16 2019, 10:21 PM
epriestley requested review of D20719: Make Phortune payment methods transaction-oriented and always support "Add Payment Method".
Aug 16 2019, 9:57 PM
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: D20719: Make Phortune payment methods transaction-oriented and always support "Add Payment Method".
Aug 16 2019, 9:56 PM · Phortune, Phacility
epriestley added a revision to T13367: Phortune "enterprise" update errata: D20719: Make Phortune payment methods transaction-oriented and always support "Add Payment Method".
Aug 16 2019, 9:56 PM · Phortune, Phacility
epriestley added a comment to T13367: Phortune "enterprise" update errata.

if this is really an issue we could likely throw a rate limit on the action

Aug 16 2019, 5:44 PM · Phortune, Phacility
epriestley added a comment to T13367: Phortune "enterprise" update errata.

This is sort-of-quasi-intentional

Aug 16 2019, 5:42 PM · Phortune, Phacility
epriestley added inline comments to D20718: Update PhortunePaymentMethod for modern policy interfaces.
Aug 16 2019, 5:30 PM
epriestley updated the diff for D20718: Update PhortunePaymentMethod for modern policy interfaces.

This is actually slightly tricky.

Aug 16 2019, 5:29 PM
epriestley added a comment to T13381: Policy explanations for some extended policy objects with "open" default policy plus constraints are misleading.

A related issue is that when object A returns object B as an extended policy check and the user fails the extended policy check, the "PolicyException" dialog is misleading. It reads like this:

Aug 16 2019, 5:27 PM · Policy
epriestley requested review of D20718: Update PhortunePaymentMethod for modern policy interfaces.
Aug 16 2019, 5:10 PM
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: D20718: Update PhortunePaymentMethod for modern policy interfaces.
Aug 16 2019, 5:08 PM · Phortune, Phacility
epriestley triaged T13381: Policy explanations for some extended policy objects with "open" default policy plus constraints are misleading as Wishlist priority.
Aug 16 2019, 5:04 PM · Policy
epriestley requested review of D20717: Update Phortune payment account interfaces to handle merchant vs customer views.
Aug 16 2019, 4:39 PM
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: D20717: Update Phortune payment account interfaces to handle merchant vs customer views.
Aug 16 2019, 4:38 PM · Phortune, Phacility
epriestley requested review of D20716: In Phortune, use actual merchant authority (not authority grants) to control account visibility.
Aug 16 2019, 3:19 PM
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: D20716: In Phortune, use actual merchant authority (not authority grants) to control account visibility.
Aug 16 2019, 3:18 PM · Phortune, Phacility

Aug 15 2019

epriestley requested review of D20715: In Phortune, write relationships between payment accounts and merchants they interact with.
Aug 15 2019, 11:17 PM
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: D20715: In Phortune, write relationships between payment accounts and merchants they interact with.
Aug 15 2019, 11:16 PM · Phortune, Phacility
epriestley updated the task description for T13367: Phortune "enterprise" update errata.
Aug 15 2019, 11:00 PM · Phortune, Phacility
epriestley triaged T13380: `git push` fatals when CWD does not exist as Low priority.
Aug 15 2019, 8:02 PM · Arcanist
epriestley closed T13379: Query panels executing bucketed queries with limits have unclear behavior as Wontfix.

Actually, since the modern behavior is reasonable by default (the "Limit" field is not required, and defaults to empty, and the panel works properly if "Limit" is left blank), users have to explicitly set a limit to get any unintuitive behavior here. If they do, they still get a "View All Results" hint.

Aug 15 2019, 7:47 PM · Dashboards
epriestley added a comment to T13379: Query panels executing bucketed queries with limits have unclear behavior.

The bucket limit is currently implemented like this:

Aug 15 2019, 7:43 PM · Dashboards
epriestley committed rPd890c03ac348: Namespace all column references in ProjectQuery to fix ambiguity with Ferret… (authored by epriestley).
Namespace all column references in ProjectQuery to fix ambiguity with Ferret…
Aug 15 2019, 7:22 PM
epriestley closed T13378: Project queries with a Ferret fulltext constraint encounter ambiguous column error when paging as Resolved by committing rPd890c03ac348: Namespace all column references in ProjectQuery to fix ambiguity with Ferret….
Aug 15 2019, 7:22 PM · Projects
epriestley closed D20714: Namespace all column references in ProjectQuery to fix ambiguity with Ferret constraints.
Aug 15 2019, 7:22 PM
epriestley triaged T13379: Query panels executing bucketed queries with limits have unclear behavior as Low priority.
Aug 15 2019, 7:21 PM · Dashboards
epriestley requested review of D20714: Namespace all column references in ProjectQuery to fix ambiguity with Ferret constraints.
Aug 15 2019, 7:03 PM
epriestley added a revision to T13378: Project queries with a Ferret fulltext constraint encounter ambiguous column error when paging: D20714: Namespace all column references in ProjectQuery to fix ambiguity with Ferret constraints.
Aug 15 2019, 7:02 PM · Projects
epriestley triaged T13378: Project queries with a Ferret fulltext constraint encounter ambiguous column error when paging as Low priority.
Aug 15 2019, 7:00 PM · Projects
epriestley added a comment to T13366: Update Phortune to work better with "enterprise" billing/accounts departments.

It would also be nice to figure out Phortune permissions better here since this is a good opportunity to vet everything.

Aug 15 2019, 6:49 PM · Phortune, Phacility
epriestley updated the task description for T13367: Phortune "enterprise" update errata.
Aug 15 2019, 5:54 PM · Phortune, Phacility
avivey awarded T13376: Write about "add more logging / monitoring / tests" a Manufacturing Defect? token.
Aug 15 2019, 5:26 PM · Guides
epriestley triaged T13377: Write about "how to solve problems with program behavior" as Wishlist priority.
Aug 15 2019, 4:54 PM · Guides