Page MenuHomePhabricator

Respect "disabled" custom field status granted by "subtype" configuration in form validation
ClosedPublic

Authored by epriestley on Aug 22 2019, 1:02 AM.
Tags
None
Referenced Files
F18829530: D20726.id.diff
Fri, Oct 24, 10:41 PM
F18823131: D20726.diff
Thu, Oct 23, 10:18 AM
F18813352: D20726.id49416.diff
Mon, Oct 20, 3:34 PM
F18810639: D20726.id49415.diff
Sun, Oct 19, 10:39 PM
F18649982: D20726.diff
Sep 20 2025, 10:58 PM
F18567285: D20726.id.diff
Sep 9 2025, 3:39 PM
F18519359: D20726.diff
Sep 5 2025, 4:29 PM
F18474805: D20726.diff
Sep 2 2025, 10:50 PM
Subscribers
None

Details

Summary

Fixes T13384. Currently, the subtype "disabled" configuration is not respected when selecting fields for ROLE_EDIT.

The only meaningful caller for ROLE_EDIT is transaction validation, but transaction validation should respect fields being disabled by subtype configuration.

Test Plan
  • Added a "required" Maniphest custom field "F", then "disabled" it in a subtype "S".
  • Created a task of subtype "S".
    • Before: Form submission fails with error "F is required", even though the field is not actually visible on the form and can not be set.
    • After: Form submits cleanly and creates the task.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Draft.Aug 22 2019, 1:03 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.