Page MenuHomePhabricator

Respect "disabled" custom field status granted by "subtype" configuration in form validation
ClosedPublic

Authored by epriestley on Aug 22 2019, 1:02 AM.
Tags
None
Referenced Files
F15477854: D20726.id.diff
Mon, Apr 7, 6:19 PM
F15473143: D20726.diff
Sat, Apr 5, 7:47 PM
F15462879: D20726.id49416.diff
Tue, Apr 1, 6:26 PM
F15454919: D20726.id49415.diff
Sat, Mar 29, 9:17 PM
F15445043: D20726.id49416.diff
Thu, Mar 27, 12:21 PM
F15415788: D20726.id49416.diff
Thu, Mar 20, 7:52 AM
F15403953: D20726.id49416.diff
Tue, Mar 18, 5:39 AM
F15399616: D20726.diff
Mon, Mar 17, 5:50 AM
Subscribers
None

Details

Summary

Fixes T13384. Currently, the subtype "disabled" configuration is not respected when selecting fields for ROLE_EDIT.

The only meaningful caller for ROLE_EDIT is transaction validation, but transaction validation should respect fields being disabled by subtype configuration.

Test Plan
  • Added a "required" Maniphest custom field "F", then "disabled" it in a subtype "S".
  • Created a task of subtype "S".
    • Before: Form submission fails with error "F is required", even though the field is not actually visible on the form and can not be set.
    • After: Form submits cleanly and creates the task.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Draft.Aug 22 2019, 1:03 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.