Page MenuHomePhabricator

Respect "disabled" custom field status granted by "subtype" configuration in form validation

Authored by epriestley on Aug 22 2019, 1:02 AM.



Fixes T13384. Currently, the subtype "disabled" configuration is not respected when selecting fields for ROLE_EDIT.

The only meaningful caller for ROLE_EDIT is transaction validation, but transaction validation should respect fields being disabled by subtype configuration.

Test Plan
  • Added a "required" Maniphest custom field "F", then "disabled" it in a subtype "S".
  • Created a task of subtype "S".
    • Before: Form submission fails with error "F is required", even though the field is not actually visible on the form and can not be set.
    • After: Form submits cleanly and creates the task.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Aug 22 2019, 1:02 AM
This revision was not accepted when it landed; it landed in state Draft.Aug 22 2019, 1:03 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.