Differential D20729

Convert "Empower" from state-based MFA to one-shot MFA
ClosedPublic
Actions

Authored by epriestley on Aug 22 2019, 2:07 PM.

Tags

None

Referenced Files

	F18837613: D20729.id49422.diff
	Mon, Oct 27, 6:48 AM

	F18834608: D20729.id.diff
	Sun, Oct 26, 9:50 AM

	F18829509: D20729.diff
	Fri, Oct 24, 10:35 PM

	F18734008: D20729.id.diff
	Tue, Sep 30, 10:46 PM

	F18702951: D20729.id49423.diff
	Sep 28 2025, 2:19 AM

	F18684896: D20729.diff
	Sep 26 2025, 10:06 AM

	F18622812: D20729.diff
	Sep 15 2025, 1:03 PM

	F18622005: D20729.id.diff
	Sep 15 2025, 10:10 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13382: Update various user account CLI tools
Commits: rP109d7dcaf197: Convert "Empower" from state-based MFA to one-shot MFA

Summary

Ref T13382. Currently, the "Make Administrator" action in the web UI does state-based MFA. Convert it to one-shot MFA.

Test Plan

Empowered and unempowered a user from the web UI, got one-shot MFA'd. Empowered a user from the CLI, no MFA issues.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Aug 22 2019, 2:07 PM

Harbormaster completed remote builds in B23280: Diff 49422.Aug 22 2019, 2:08 PM

epriestley requested review of this revision.Aug 22 2019, 2:08 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 22 2019, 3:34 PM

Closed by commit rP109d7dcaf197: Convert "Empower" from state-based MFA to one-shot MFA (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP109d7dcaf197: Convert "Empower" from state-based MFA to one-shot MFA.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

controller/

PhabricatorPeopleEmpowerController.php

11 lines

xaction/

PhabricatorUserEmpowerTransaction.php

7 lines

Diff 49423

View Options

src/applications/people/controller/PhabricatorPeopleEmpowerController.php