Page MenuHomePhabricator
Feed All Stories

Sep 25 2018

epriestley closed T9116: Shell completion doesn't work for filenames containing a space as Resolved by committing Restricted Diffusion Commit.
Sep 25 2018, 11:16 PM · Restricted Project, Arcanist
epriestley updated the task description for T13098: Plans: Arcanist toolsets and extensions.
Sep 25 2018, 10:54 PM · Arcanist, Plans
epriestley added a revision to T13098: Plans: Arcanist toolsets and extensions: Unknown Object (Differential Revision).
Sep 25 2018, 10:42 PM · Arcanist, Plans
epriestley added a revision to T13098: Plans: Arcanist toolsets and extensions: Unknown Object (Differential Revision).
Sep 25 2018, 10:35 PM · Arcanist, Plans
epriestley added a revision to T13098: Plans: Arcanist toolsets and extensions: Restricted Differential Revision.
Sep 25 2018, 10:32 PM · Arcanist, Plans
epriestley added a comment to T13098: Plans: Arcanist toolsets and extensions.

Here are some of the bigger ideas around arc unit:

Sep 25 2018, 5:59 PM · Arcanist, Plans
epriestley added a parent task for T5568: Support `.arcunit`, similar to `.arclint`: T13098: Plans: Arcanist toolsets and extensions.
Sep 25 2018, 4:47 PM · Unit, Arcanist
epriestley added a subtask for T13098: Plans: Arcanist toolsets and extensions: T5568: Support `.arcunit`, similar to `.arclint`.
Sep 25 2018, 4:47 PM · Arcanist, Plans
epriestley closed T5568: Support `.arcunit`, similar to `.arclint` as Resolved.

This has existed for some time and will be the only option after T13098.

Sep 25 2018, 4:47 PM · Unit, Arcanist
epriestley closed T5568: Support `.arcunit`, similar to `.arclint`, a subtask of T9223: Allow `arc diff` to run a build step like `gradle` first, then read lint and unit messages from the output, as Resolved.
Sep 25 2018, 4:47 PM · Unit, Arcanist
epriestley added a parent task for T10329: Implement internal workflows / a build engine in Arcanist: T13098: Plans: Arcanist toolsets and extensions.
Sep 25 2018, 4:43 PM · Restricted Project, Arcanist
epriestley added a subtask for T13098: Plans: Arcanist toolsets and extensions: T10329: Implement internal workflows / a build engine in Arcanist.
Sep 25 2018, 4:43 PM · Arcanist, Plans
epriestley closed T10329: Implement internal workflows / a build engine in Arcanist as Resolved.

I'm going to roll this forward into T13098, which is essentially a superset of all the ideas here except arc build (a new step which can: generate code, generate artifacts shared between lint/unit, and prepare a working copy to be able to execute unit tests). That will probably happen, but likely after T13098 stabilizes.

Sep 25 2018, 4:43 PM · Restricted Project, Arcanist
epriestley closed T10329: Implement internal workflows / a build engine in Arcanist, a subtask of T9223: Allow `arc diff` to run a build step like `gradle` first, then read lint and unit messages from the output, as Resolved.
Sep 25 2018, 4:43 PM · Unit, Arcanist
epriestley closed T10329: Implement internal workflows / a build engine in Arcanist, a subtask of T10620: Support complex mappings from branch names to JIRA/Maniphest tasks, as Resolved.
Sep 25 2018, 4:43 PM · Restricted Project, Arcanist, Feature Request
epriestley closed T10329: Implement internal workflows / a build engine in Arcanist, a subtask of T10622: Auto add reviewers based on custom logic, as Resolved.
Sep 25 2018, 4:43 PM · Restricted Project, Arcanist, Feature Request
epriestley added a comment to T13098: Plans: Arcanist toolsets and extensions.

In theory, arc unit is next on the docket so we can start getting test coverage, then Windows support. However, I suspect arc unit may unfurl into a lot of substeps.

Sep 25 2018, 4:20 PM · Arcanist, Plans
epriestley added a revision to T13198: Consider an "arc prompts" or similar, to improve automation on top of "arc": Unknown Object (Differential Revision).
Sep 25 2018, 4:16 PM · Arcanist, Plans
epriestley added a revision to T12996: Parallelize substages of `arc diff`: Unknown Object (Differential Revision).
Sep 25 2018, 4:16 PM · Arcanist
epriestley added a revision to T13098: Plans: Arcanist toolsets and extensions: Unknown Object (Differential Revision).
Sep 25 2018, 4:15 PM · Arcanist, Plans
epriestley added a comment to T13098: Plans: Arcanist toolsets and extensions.

For prompting, the major things I want to do are:

Sep 25 2018, 1:33 PM · Arcanist, Plans
epriestley added a comment to T9116: Shell completion doesn't work for filenames containing a space.

I've marked D19705 as fixing this. Some stuff still doesn't work, notably:

Sep 25 2018, 1:05 PM · Restricted Project, Arcanist
epriestley added a revision to T13098: Plans: Arcanist toolsets and extensions: Unknown Object (Differential Revision).
Sep 25 2018, 12:53 PM · Arcanist, Plans
epriestley added a revision to T9116: Shell completion doesn't work for filenames containing a space: Unknown Object (Differential Revision).
Sep 25 2018, 12:53 PM · Restricted Project, Arcanist
epriestley added a comment to T9116: Shell completion doesn't work for filenames containing a space.

In a directory with a file foo bar:

Sep 25 2018, 12:46 PM · Restricted Project, Arcanist
epriestley added a comment to T9116: Shell completion doesn't work for filenames containing a space.

Some general notes on this after putting far more time than feels valuable into it:

Sep 25 2018, 3:20 AM · Restricted Project, Arcanist

Sep 24 2018

epriestley added a comment to T9116: Shell completion doesn't work for filenames containing a space.

How did anyone get computers to do anything before 2005?

Sep 24 2018, 11:18 PM · Restricted Project, Arcanist
epriestley added a revision to T13098: Plans: Arcanist toolsets and extensions: Unknown Object (Differential Revision).
Sep 24 2018, 11:11 PM · Arcanist, Plans
epriestley updated the task description for T13202: Plans: 2018 Week 38-40 Bonus Content.
Sep 24 2018, 6:24 PM · Plans
epriestley merged T7787: Support "!priority high" and other email commands from "arc todo" into T11934: Make email commands ("/subscribe") work in all contexts, including Conpherence ("/me").
Sep 24 2018, 4:48 PM · Conpherence (v4), Feature Request
epriestley merged task T7787: Support "!priority high" and other email commands from "arc todo" into T11934: Make email commands ("/subscribe") work in all contexts, including Conpherence ("/me").
Sep 24 2018, 4:48 PM · Arcanist
epriestley added a comment to T7787: Support "!priority high" and other email commands from "arc todo".

I'm going to merge this into T11934 since I now expect to provide a more general version of arc edit <object> and make all comment areas support these commands.

Sep 24 2018, 4:48 PM · Arcanist
epriestley added a subtask for T13098: Plans: Arcanist toolsets and extensions: T9116: Shell completion doesn't work for filenames containing a space.
Sep 24 2018, 4:46 PM · Arcanist, Plans
epriestley added a parent task for T9116: Shell completion doesn't work for filenames containing a space: T13098: Plans: Arcanist toolsets and extensions.
Sep 24 2018, 4:46 PM · Restricted Project, Arcanist
epriestley moved T13165: Copy detection in Git is very eager about empty files from Backlog to Far Future on the Arcanist board.
Sep 24 2018, 4:44 PM · Differential, Arcanist, Git
epriestley closed T7035: arc diff --reviwers loses template information as Invalid.

Can't reproduce:

Sep 24 2018, 4:41 PM · Restricted Project, Arcanist
epriestley closed T6850: PHP Notices, when Linter Cache enabled as Wontfix.

This feature has been removed in experimental and wilds, and I don't currently expect to restore it.

Sep 24 2018, 4:38 PM · Lint, Arcanist
epriestley moved T6362: parseDiff assumes GNU-style unified diff from Backlog to Diff Parsing on the Arcanist board.
Sep 24 2018, 4:37 PM · Arcanist
epriestley closed T6766: `arc diff` should do an early check for total diff size and provide appropriate hints for the user, a subtask of T13098: Plans: Arcanist toolsets and extensions, as Wontfix.
Sep 24 2018, 4:37 PM · Arcanist, Plans
epriestley closed T6766: `arc diff` should do an early check for total diff size and provide appropriate hints for the user as Wontfix.

In T13098, I expect to remove both of these warnings because:

Sep 24 2018, 4:37 PM · Arcanist
epriestley added a subtask for T13098: Plans: Arcanist toolsets and extensions: T6766: `arc diff` should do an early check for total diff size and provide appropriate hints for the user.
Sep 24 2018, 4:31 PM · Arcanist, Plans
epriestley added a parent task for T6766: `arc diff` should do an early check for total diff size and provide appropriate hints for the user: T13098: Plans: Arcanist toolsets and extensions.
Sep 24 2018, 4:31 PM · Arcanist
epriestley closed T5643: arc diff should prompt for committing when called again after resolving a merge conflict during arc land as Wontfix.

We haven't seen friction here from other installs in the last few years, and I think (?) this encourages a questionable practice (assuming unreviewed changes in the working copy should be amended) in the general case.

Sep 24 2018, 4:31 PM · Arcanist
epriestley closed T6584: arc diff --verbatim mis-parses for previous review sometimes as Wontfix.

iiam

Sep 24 2018, 4:28 PM · Arcanist
epriestley moved T4725: `arc liberate` should throw when encountering (and eventually support) namespaces and traits from Backlog to Upstream on the Arcanist board.
Sep 24 2018, 4:25 PM · XHPAST, Arcanist
epriestley merged T5636: add option to arc diff to include entire commit history for review into T1508: When running "arc diff" on a range of commits, preserve the individual commits while still creating a single diff from them.
Sep 24 2018, 4:25 PM · Restricted Project, Arcanist
epriestley merged task T5636: add option to arc diff to include entire commit history for review into T1508: When running "arc diff" on a range of commits, preserve the individual commits while still creating a single diff from them.
Sep 24 2018, 4:24 PM · Arcanist
epriestley added a comment to T5636: add option to arc diff to include entire commit history for review.

As requested, this is the same as T1508, "when I run arc diff, each commit in the range should be preserved and visible in the web UI".

Sep 24 2018, 4:24 PM · Arcanist
epriestley closed T5173: Provide man pages for Arcanist, a subtask of T4200: Building OS packages and install scripts, as Wontfix.
Sep 24 2018, 4:19 PM · Guides, Setup
epriestley closed T5173: Provide man pages for Arcanist as Wontfix.

I don't plan to pursue this.

Sep 24 2018, 4:19 PM · Arcanist
epriestley closed T5172: Create an `arc status` workflow as Wontfix.

I think this has failed to collect any compelling use cases in several years and don't plan to pursue it.

Sep 24 2018, 4:06 PM · Prioritized, Restricted Project, Arcanist
epriestley moved T5141: `ArcanistXHPASTLinter` should raise warnings when deprecated functions are used from Backlog to Upstream on the Arcanist board.
Sep 24 2018, 4:04 PM · Lint, Arcanist
epriestley closed T5088: Arcanist: Add a command to check whether the current workspace state matches the latest uploaded Revision as Wontfix.

See also T4953. I don't really understand this use case and suspect Harbormaster now solves it (when revisions are updated, run a build which deploys the changes to a sandbox). It sounds like the use case is really "would arc patch do anything?", not "would arc diff --update do anything?".

Sep 24 2018, 4:03 PM · Restricted Project, Arcanist
epriestley closed T4953: If arc diff is run twice on exact same commit, will upload new diff to differential as Wontfix.

This is intended and has legitimate use cases.

Sep 24 2018, 4:00 PM · Restricted Project, Wikimedia, Arcanist
epriestley closed T4949: Support JUnit as an output format for unit test results as Wontfix.

This will be fully modularized in T13098 if it isn't already. I don't expect us to upstream a JUnit formatter, per T10038.

Sep 24 2018, 3:58 PM · Unit, Arcanist
epriestley closed T4949: Support JUnit as an output format for unit test results, a subtask of T13098: Plans: Arcanist toolsets and extensions, as Wontfix.
Sep 24 2018, 3:58 PM · Arcanist, Plans
epriestley added a subtask for T13098: Plans: Arcanist toolsets and extensions: T4949: Support JUnit as an output format for unit test results.
Sep 24 2018, 3:57 PM · Arcanist, Plans
epriestley added a parent task for T4949: Support JUnit as an output format for unit test results: T13098: Plans: Arcanist toolsets and extensions.
Sep 24 2018, 3:57 PM · Unit, Arcanist
epriestley closed T4719: config option to make 'arc land --hold' default behavior, a subtask of T13098: Plans: Arcanist toolsets and extensions, as Wontfix.
Sep 24 2018, 3:56 PM · Arcanist, Plans
epriestley closed T4719: config option to make 'arc land --hold' default behavior as Wontfix.

I don't plan to pursue this, as requested.

Sep 24 2018, 3:56 PM · Arcanist
epriestley added a subtask for T13098: Plans: Arcanist toolsets and extensions: T4719: config option to make 'arc land --hold' default behavior.
Sep 24 2018, 3:55 PM · Arcanist, Plans
epriestley added a parent task for T4719: config option to make 'arc land --hold' default behavior: T13098: Plans: Arcanist toolsets and extensions.
Sep 24 2018, 3:55 PM · Arcanist
epriestley moved T4682: With SVN 1.7, certain property changes won't show properly in Differential from Backlog to Diff Parsing on the Arcanist board.
Sep 24 2018, 3:54 PM · Subversion, Arcanist
epriestley moved T1947: Merged files in SVN don't pull content correctly when diffed from Backlog to Diff Parsing on the Arcanist board.
Sep 24 2018, 3:52 PM · Arcanist, Subversion
epriestley moved T1508: When running "arc diff" on a range of commits, preserve the individual commits while still creating a single diff from them from Backlog to Far Future on the Arcanist board.
Sep 24 2018, 3:51 PM · Restricted Project, Arcanist
epriestley closed Restricted Maniphest Task, a subtask of T13098: Plans: Arcanist toolsets and extensions, as Wontfix.
Sep 24 2018, 3:51 PM · Arcanist, Plans
epriestley added a subtask for T13098: Plans: Arcanist toolsets and extensions: Unknown Object (Maniphest Task).
Sep 24 2018, 3:49 PM · Arcanist, Plans
epriestley moved T1083: Update revisions with merge/rebase diffs so incremental changes can be shown from Backlog to Far Future on the Arcanist board.
Sep 24 2018, 3:48 PM · Arcanist, Differential
epriestley closed T3089: Using 'arc diff' after sending diffs through the web UI breaks the diff view. as Wontfix.

This is many years old, hasn't seen further reports, and no longer has usable reproduction instructions.

Sep 24 2018, 3:47 PM · Arcanist, Differential
epriestley closed T12010: Untangle the Gordian Knot of iterating on Differential/Diffusion/Arcanist as Resolved.

Piece by piece, this was effectively untangled. Differential largely moved forward; Arcanist has a path forward in T13098 (although it's ultimately a "major version" sort of change), and Diffusion stuff has settled into relatively actionable plans in, e.g., T13075.

Sep 24 2018, 3:46 PM · Diffusion (v3), Arcanist, Differential
epriestley closed T12010: Untangle the Gordian Knot of iterating on Differential/Diffusion/Arcanist, a subtask of T13098: Plans: Arcanist toolsets and extensions, as Resolved.
Sep 24 2018, 3:46 PM · Arcanist, Plans
epriestley added a subtask for T13098: Plans: Arcanist toolsets and extensions: T12010: Untangle the Gordian Knot of iterating on Differential/Diffusion/Arcanist.
Sep 24 2018, 3:36 PM · Arcanist, Plans
epriestley added a parent task for T12010: Untangle the Gordian Knot of iterating on Differential/Diffusion/Arcanist: T13098: Plans: Arcanist toolsets and extensions.
Sep 24 2018, 3:36 PM · Diffusion (v3), Arcanist, Differential
epriestley moved T12996: Parallelize substages of `arc diff` from Backlog to vNext on the Arcanist board.
Sep 24 2018, 3:35 PM · Arcanist
epriestley moved T13098: Plans: Arcanist toolsets and extensions from Backlog to vNext on the Arcanist board.
Sep 24 2018, 3:35 PM · Arcanist, Plans
epriestley moved T13198: Consider an "arc prompts" or similar, to improve automation on top of "arc" from Backlog to vNext on the Arcanist board.
Sep 24 2018, 3:35 PM · Arcanist, Plans
epriestley moved T13203: Arcanist Wilds Patch Notes (Ongoing) from Backlog to vNext on the Arcanist board.
Sep 24 2018, 3:35 PM · Arcanist, Plans
epriestley added a comment to T13098: Plans: Arcanist toolsets and extensions.

In D19697 I claimed my next plans were "Windows, signal handling, and prompts", but I think arc unit needs to work again before I can convincingly do the Windows stuff. So it looks like signal handling and prompts first.

Sep 24 2018, 3:34 PM · Arcanist, Plans

Sep 23 2018

epriestley updated the task description for T13202: Plans: 2018 Week 38-40 Bonus Content.
Sep 23 2018, 6:08 PM · Plans
epriestley added a revision to T13202: Plans: 2018 Week 38-40 Bonus Content: Unknown Object (Differential Revision).
Sep 23 2018, 6:06 PM · Plans
epriestley added a revision to T13202: Plans: 2018 Week 38-40 Bonus Content: Unknown Object (Differential Revision).
Sep 23 2018, 3:43 PM · Plans
epriestley updated the task description for T13098: Plans: Arcanist toolsets and extensions.
Sep 23 2018, 3:16 PM · Arcanist, Plans
epriestley created 2018 Week 38 (Very Late September).
Sep 23 2018, 3:12 PM
epriestley renamed T13202: Plans: 2018 Week 38-40 Bonus Content from Plans: 2018 Week 38 Bonus Content to Plans: 2018 Week 38-39 Bonus Content.
Sep 23 2018, 3:09 PM · Plans

Sep 22 2018

bcooksley added a comment to T13204: First mail sent by Differential doesn't have a Message-ID header set properly.

In my case (using GMail) it appears to thread properly as well however apparently some clients (KMail) rely on these headers more heavily than others.

Sep 22 2018, 12:07 AM · Mail, Differential

Sep 21 2018

epriestley triaged T13205: Perhaps, provide options for hardening long-lived and relatively stable directories in Drydock? as Wishlist priority.
Sep 21 2018, 11:27 PM · Drydock
epriestley added a comment to T13204: First mail sent by Differential doesn't have a Message-ID header set properly.

In order for threading to work in email clients, the Message-ID header needs to be set on the initial email, with following emails having In-Reply-To / References set to that same Message-ID.

Sep 21 2018, 11:25 PM · Mail, Differential
epriestley added a comment to T13204: First mail sent by Differential doesn't have a Message-ID header set properly.

I can't reproduce this: mail threads properly in my client.

Sep 21 2018, 11:23 PM · Mail, Differential
bcooksley created T13204: First mail sent by Differential doesn't have a Message-ID header set properly.
Sep 21 2018, 10:56 PM · Mail, Differential
epriestley added a revision to T13098: Plans: Arcanist toolsets and extensions: Unknown Object (Differential Revision).
Sep 21 2018, 10:44 PM · Arcanist, Plans
epriestley updated the task description for T13203: Arcanist Wilds Patch Notes (Ongoing).
Sep 21 2018, 10:39 PM · Arcanist, Plans
epriestley updated the task description for T13203: Arcanist Wilds Patch Notes (Ongoing).
Sep 21 2018, 10:05 PM · Arcanist, Plans
derek edited the content of Organizations Using Phabricator.
Sep 21 2018, 3:09 PM

Sep 20 2018

epriestley added a revision to T13098: Plans: Arcanist toolsets and extensions: Unknown Object (Differential Revision).
Sep 20 2018, 10:45 PM · Arcanist, Plans
epriestley updated the task description for T13203: Arcanist Wilds Patch Notes (Ongoing).
Sep 20 2018, 10:31 PM · Arcanist, Plans
amckinley created U42 Arcanist Commit Ranges Docs.
Sep 20 2018, 10:29 PM
epriestley added a revision to T13098: Plans: Arcanist toolsets and extensions: Unknown Object (Differential Revision).
Sep 20 2018, 10:07 PM · Arcanist, Plans
epriestley updated the task description for T13203: Arcanist Wilds Patch Notes (Ongoing).
Sep 20 2018, 9:52 PM · Arcanist, Plans
epriestley added a comment to T13203: Arcanist Wilds Patch Notes (Ongoing).

Also, damn, I've used libphutil for so many things - ExecFuture and HTTPSFuture are just by far the best thing out there for async work.

Sep 20 2018, 9:47 PM · Arcanist, Plans
epriestley updated the task description for T13203: Arcanist Wilds Patch Notes (Ongoing).
Sep 20 2018, 9:45 PM · Arcanist, Plans