Page MenuHomePhabricator

arc diff --verbatim mis-parses for previous review sometimes
Closed, WontfixPublic

Description

This is a pretty obscure error, but I'm curious what might be causing it!

I made a commit and sent it off for review. The commit message said something like, "In Dxxxx, Fred did some work. Now I do some more work." No problem, the review went off and the git commit message was amended to say: "Differential Revision: http://phabricator.khanacademy.org/Dyyyy."

Then i made another commit on top of that, and ran arc diff --amend. This failed with this error:

Usage Exception: You don't own revision Dxxxx 'Make notification config side-effect-less on load'. You can only update revisions you own.

When I then ran arc diff instead -- without the --amend it properly updated Dyyyy.

I dont' know why adding --amend would change the arc which output, but apparently it did.

Event Timeline

csilvers raised the priority of this task from to Needs Triage.
csilvers updated the task description. (Show Details)
csilvers added a project: Arcanist.
csilvers added a subscriber: csilvers.

Oops, my mistake -- the usage exception didn't reference Dxxxx at all. Instead, it referenced the differential revision of the change before mine.

In other words: Fred landed Daaaa. I then created a revision that was named Dbbbb. When I did arc diff --amend on my next commit, it complained that I don't own Daaaa.

I've done something similar zillions of times without error, so I don't know what might be going on here. Probably low priority. I'll ping if I see it again.

epriestley claimed this task.
epriestley added a subscriber: epriestley.

iiam