Page MenuHomePhabricator

PHP Notices, when Linter Cache enabled
Closed, WontfixPublic

Description

When I enable linter cache by adding "arc.lint.cache": true to the .arcconfig file of the project, then during arc lint command execution I'm getting following PHP notices:

[2015-01-02 13:44:15] ERROR 2: file_exists(): Unable to find the wrapper "svn" - did you forget to enable it when you configured PHP? at [.../libphutil/src/filesystem/Filesystem.php:885]
  #0 file_exists(string) called at [<phutil>/src/filesystem/Filesystem.php:885]
  #1 Filesystem::pathExists(string) called at [<arcanist>/src/workflow/ArcanistWorkflow.php:1591]
  #2 ArcanistWorkflow::getRepositoryVersion() called at [<arcanist>/src/workflow/ArcanistLintWorkflow.php:240]
  #3 ArcanistLintWorkflow::run() called at [<arcanist>/scripts/arcanist.php:343]

It happens due $engine->setRepositoryVersion($this->getRepositoryVersion()); code in https://secure.phabricator.com/diffusion/ARC/browse/master/src/workflow/ArcanistLintWorkflow.php;0352db802e9ddff35286b247e27a89ea11a78929$232 where getRepositoryVersion call tried to do Filesystem::pathExists on the svn://username@repository.host.com/path/to/file.php path: https://secure.phabricator.com/diffusion/ARC/browse/master/src/workflow/ArcanistWorkflow.php;0352db802e9ddff35286b247e27a89ea11a78929$1562

I guess it's a mistake in the ArcanistSubversionAPI::getChangedFiles method, that should return paths in working copy instead of paths in repository.

Event Timeline

aik099 raised the priority of this task from to Needs Triage.
aik099 updated the task description. (Show Details)
aik099 added a project: Arcanist.
aik099 added a subscriber: aik099.
chad triaged this task as Normal priority.Jan 2 2015, 5:15 PM
chad added a project: Lint.
epriestley claimed this task.
epriestley added a subscriber: epriestley.

This feature has been removed in experimental and wilds, and I don't currently expect to restore it.