Page MenuHomePhabricator
Feed All Stories

Apr 20 2017

epriestley added a comment to T12607: Decrease pain and suffering caused by deploy/upgrade process.

Oh, maybe not. Things are kind of weird on secure. We should probably sort that out and get that hitting "real" /status/ somehow.

Apr 20 2017, 8:47 PM · Phacility
epriestley added a comment to T12607: Decrease pain and suffering caused by deploy/upgrade process.

Oh, hrrm. Maybe that RedirectMatch is actually getting hit in practice by the LB, that's suuuper old. I get this from the host itself:

Apr 20 2017, 8:45 PM · Phacility
epriestley added a comment to T12607: Decrease pain and suffering caused by deploy/upgrade process.

The actual check is elsewhere in that file:

Apr 20 2017, 8:42 PM · Phacility
epriestley added a comment to T12607: Decrease pain and suffering caused by deploy/upgrade process.

secure is hitting the magic override code in the second link since we deploy rSERVICES there too.

Apr 20 2017, 8:41 PM · Phacility
epriestley added a comment to T12607: Decrease pain and suffering caused by deploy/upgrade process.

Yeah, I don't like trying to mess with the LBs very much either. I recall the FB F5's (I think?) took like 75 seconds per API call and you needed to make 12 API calls to remove a host, I just figured AWS LBs might be some kind of special magic LBs that can add and remove elements from a list in about a second.

Apr 20 2017, 8:41 PM · Phacility
amckinley added a comment to T12607: Decrease pain and suffering caused by deploy/upgrade process.
Apr 20 2017, 8:39 PM · Phacility
amckinley added a comment to T12607: Decrease pain and suffering caused by deploy/upgrade process.

Another possible question here is: how long does it take to pull a node out of an ELB with the AWS API? If it's very fast, maybe worthwhile to pursue actively managing nodes in the LB. But I'm guessing it's at least similar to the ~10s health check stuff.

Apr 20 2017, 8:36 PM · Phacility
epriestley added a comment to T12607: Decrease pain and suffering caused by deploy/upgrade process.

On health-check, vanilla Phabricator runs this:

Apr 20 2017, 8:35 PM · Phacility
jessjohnson created T12609: Prevent arc land when unit tests or build fails.
Apr 20 2017, 8:35 PM · Feature Request
epriestley added a comment to T12607: Decrease pain and suffering caused by deploy/upgrade process.

I'm pretty sure there's a reasonable way to ask apache to gracefully stop in a blocking way

Apr 20 2017, 8:28 PM · Phacility
amckinley added a comment to T12607: Decrease pain and suffering caused by deploy/upgrade process.

There's also a discussion to be had about generally increasing the robustness of the healthcheck: that endpoint could attempt a DB connection, look for a full disk, check that ntp status is reasonable, etc, etc. This has tradeoffs as far as creating extra CPU load, false negatives, etc, etc, but there's probably a happy medium between "Apache doing RedirectMatch 200 "^/status/$"" and generating a full page.

Apr 20 2017, 8:28 PM · Phacility
amckinley updated subscribers of T12607: Decrease pain and suffering caused by deploy/upgrade process.
Apr 20 2017, 8:21 PM · Phacility
amckinley created T12607: Decrease pain and suffering caused by deploy/upgrade process.
Apr 20 2017, 8:21 PM · Phacility
chad renamed T12604: Pager hard to notice in Diffusion from Can't find folder in Diffusion to Pager hard to notice in Diffusion.
Apr 20 2017, 8:04 PM · Design, Bug Report, Diffusion
beverly awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Yellow Medal token.
Apr 20 2017, 8:02 PM · Workboards (v3), Restricted Project
epriestley added a comment to T12606: Investigate browser-upload-to-S3 to reduce load on web pool during large file uploads.

Maybe "duration of all file upload requests" / "duration of all requests". That isn't a perfect metric but should be a reasonable-ish proxy for real resources we care about, I think.

Apr 20 2017, 8:00 PM · Phacility, Files
amckinley added a comment to T12606: Investigate browser-upload-to-S3 to reduce load on web pool during large file uploads.

What would the appropriate query be? "Number of uploaded files with size greater than X as a percentage of all files/file bytes"?

Apr 20 2017, 7:57 PM · Phacility, Files
epriestley added a comment to T12606: Investigate browser-upload-to-S3 to reduce load on web pool during large file uploads.

nice progress bar

Apr 20 2017, 7:49 PM · Phacility, Files
epriestley added a comment to T12606: Investigate browser-upload-to-S3 to reduce load on web pool during large file uploads.

I suspect this isn't worth the complexity. If you drag-and-drop, the maximum request size is 4MB (one chunk) and we get a nice progress bar, resumable uploads, and the bucket can remain completely private. And we can do encryption and deduplicate file blocks.

Apr 20 2017, 7:45 PM · Phacility, Files
amckinley created T12606: Investigate browser-upload-to-S3 to reduce load on web pool during large file uploads.
Apr 20 2017, 7:34 PM · Phacility, Files
jmeador added a comment to T12604: Pager hard to notice in Diffusion.

I agree, pagination way below the fold is rather inconspicuous

Apr 20 2017, 5:59 PM · Design, Bug Report, Diffusion
chad added a comment to T12604: Pager hard to notice in Diffusion.

hahaha, thanks... really easy to miss those

Apr 20 2017, 5:58 PM · Design, Bug Report, Diffusion
chad added a project to T12604: Pager hard to notice in Diffusion: Design.
Apr 20 2017, 5:58 PM · Design, Bug Report, Diffusion
jmeador added a comment to T12604: Pager hard to notice in Diffusion.

Bystander input: try page 3: https://phabricator.kde.org/source/krita/browse/master/libs/ui/?offset=200

Apr 20 2017, 5:57 PM · Design, Bug Report, Diffusion
chad created T12604: Pager hard to notice in Diffusion.
Apr 20 2017, 5:38 PM · Design, Bug Report, Diffusion
oliverchick updated subscribers of T4453: When multiple commits correspond to a single revision, Differential updates to show one of them arbitrarily.
Apr 20 2017, 3:45 PM · Restricted Project, Prioritized, Differential
epriestley closed T12603: Exception visible when sshing to phacility as Resolved.

I patched this and deployed it. I'll follow up on the internal report with details.

Apr 20 2017, 1:37 PM · Phacility, Bug Report
epriestley added a comment to T12603: Exception visible when sshing to phacility.

Thanks, this is fallout from an incident last night. The particulars involved instance and user details so the discussion was kept private. I'll fix this shortly.

Apr 20 2017, 1:33 PM · Phacility, Bug Report
kislinsk added a comment to T12374: Saved Workboard Queries.

I'm going to merge this into T12374.

If you have time, answering the questions in T12374#214870 on that task might be helpful. There are many possible implementations of this feature (e.g., per user/per workboard/global) and it's not clear to me which are desired from the use cases. It would also be helpful to understand what the major stumbling blocks are for using "bookmarks" and "saving queries to the menu" as workarounds (just cumbersome? Not the right scope/audience?).

Apr 20 2017, 7:48 AM · Workboards, Feature Request
avivey created T12603: Exception visible when sshing to phacility.
Apr 20 2017, 7:47 AM · Phacility, Bug Report
chad added a comment to T12600: Update Hovercards.

I'd just redo them on a case by case basic. Too many variables.

Apr 20 2017, 1:53 AM · Restricted Project, Hovercards
wjiang added a comment to T12601: Set default arguments of `ArcanistWorkflow`.

The only behavior of --lintall is to make warnings act like errors. Just raise everything at error severity to achieve the same thing without patching anything.

Apr 20 2017, 1:29 AM · Feature Request
epriestley added a comment to T12601: Set default arguments of `ArcanistWorkflow`.

The only behavior of --lintall is to make warnings act like errors. Just raise everything at error severity to achieve the same thing without patching anything.

Apr 20 2017, 1:15 AM · Feature Request
wjiang added a comment to T12601: Set default arguments of `ArcanistWorkflow`.

You are probably raising messages at "warning" severity, but want to raise them at "error" severity. See, e.g., here for a description:

T4287#47494

Apr 20 2017, 1:13 AM · Feature Request
• sshannin created T12602: Assignees of tasks don't count as subscribers in maniphest search.
Apr 20 2017, 1:12 AM · Maniphest, Bug Report
epriestley added a comment to T12601: Set default arguments of `ArcanistWorkflow`.

You are probably raising messages at "warning" severity, but want to raise them at "error" severity. See, e.g., here for a description:

Apr 20 2017, 1:02 AM · Feature Request
wjiang added a revision to T12601: Set default arguments of `ArcanistWorkflow`: Unknown Object (Differential Revision).
Apr 20 2017, 1:01 AM · Feature Request
wjiang updated subscribers of T12601: Set default arguments of `ArcanistWorkflow`.
Apr 20 2017, 12:57 AM · Feature Request
wjiang created T12601: Set default arguments of `ArcanistWorkflow`.
Apr 20 2017, 12:57 AM · Feature Request
epriestley added a comment to T12600: Update Hovercards.

@chad, a lot of this is probably ultimately design -- how much passion do you feel for hovercards? The infrastructure is in good shape and I can add the "context hint" piece pretty easily if we want to look at that. Not sure if this is a bigger/more complicated project that you don't want to touch for the moment or whatever, though.

Apr 20 2017, 12:25 AM · Restricted Project, Hovercards
epriestley created T12600: Update Hovercards.
Apr 20 2017, 12:21 AM · Restricted Project, Hovercards
epriestley moved T12574: Allow Conpherence rooms to be put into an "only email me when I'm mentioned" mode from Backlog to New Feature on the Conpherence (v4) board.
Apr 20 2017, 12:07 AM · Conpherence (v4)
epriestley moved T12591: Dismantle ConpherenceUpdateController into more logical controllers from Backlog to Modernization on the Conpherence (v4) board.
Apr 20 2017, 12:07 AM · Conpherence (v4)
epriestley added a revision to T12562: Make substantially more Conpherence thread rendering occur in Javascript: Unknown Object (Differential Revision).
Apr 20 2017, 12:07 AM · Conpherence (v4)

Apr 19 2017

chad added a revision to T12591: Dismantle ConpherenceUpdateController into more logical controllers: Unknown Object (Differential Revision).
Apr 19 2017, 11:23 PM · Conpherence (v4)
epriestley closed T12599: Diffusion "Locate File" typeahead fails to trigger when pasting a filename into the input field as Resolved by committing Restricted Diffusion Commit.
Apr 19 2017, 11:14 PM · Diffusion
epriestley added a revision to T12599: Diffusion "Locate File" typeahead fails to trigger when pasting a filename into the input field: Unknown Object (Differential Revision).
Apr 19 2017, 11:12 PM · Diffusion
epriestley claimed T12599: Diffusion "Locate File" typeahead fails to trigger when pasting a filename into the input field.
Apr 19 2017, 11:11 PM · Diffusion
epriestley added a revision to T11476: Record transaction histories when users edit application capabilities: Unknown Object (Differential Revision).
Apr 19 2017, 10:58 PM · Contributor Onboarding, Restricted Project, Applications, Feature Request
epriestley added a comment to T12599: Diffusion "Locate File" typeahead fails to trigger when pasting a filename into the input field.

(I assumed it was a keydown vs keypress vs whatever event sort of thing but haven't actually looked into it.)

Apr 19 2017, 10:32 PM · Diffusion
epriestley added a comment to T12599: Diffusion "Locate File" typeahead fails to trigger when pasting a filename into the input field.

Yeah, this bites me half the time too.

Apr 19 2017, 10:32 PM · Diffusion
amckinley created T12599: Diffusion "Locate File" typeahead fails to trigger when pasting a filename into the input field.
Apr 19 2017, 10:31 PM · Diffusion
amckinley added a revision to T11476: Record transaction histories when users edit application capabilities: Unknown Object (Differential Revision).
Apr 19 2017, 10:21 PM · Contributor Onboarding, Restricted Project, Applications, Feature Request
chad added a comment to T12550: Move Conpherence to Modular Transactions.

itshappening

Apr 19 2017, 9:09 PM · Conpherence (v4)
epriestley closed T12550: Move Conpherence to Modular Transactions as Resolved by committing Restricted Diffusion Commit.
Apr 19 2017, 9:01 PM · Conpherence (v4)
epriestley added a comment to T10448: Modularize mail tags.

One spanner in the works here is that not all applications with mail preferences are on Modular Transactions yet. I think these are missing:

Apr 19 2017, 6:19 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley closed T12596: Fulltext stopword filtering is applying before stemming and failing to filter forms of words which stem to stopwords as Resolved by committing Restricted Diffusion Commit.
Apr 19 2017, 5:02 PM · Search, Customer Impact
chad added a comment to T12594: Scrolling to the right-hand side locks the mouse arrow to the orizonatal scroll bar and prevents navigation.

(there are some other wierd issues in IE11, so I expect I'll clean up some of the UI issues I see).

Apr 19 2017, 5:01 PM · Bug Report
chad added a comment to T12594: Scrolling to the right-hand side locks the mouse arrow to the orizonatal scroll bar and prevents navigation.

We require reporters file complete steps to reproduce the issue. If we can't based on the information provided, it's still on you to provide an updated, more specific set of steps. Also, we don't support third party extenstions like sprint. Feel free to reproduce against a clean install on phacility.com

Apr 19 2017, 5:00 PM · Bug Report
RikiWiki added a comment to T12594: Scrolling to the right-hand side locks the mouse arrow to the orizonatal scroll bar and prevents navigation.

is there something I can do to help you? or some suggestions regarding the browser that better supports the tool?

Apr 19 2017, 4:48 PM · Bug Report
epriestley closed T12598: create a milestone of milestone as Wontfix.

We don't plan to implement this.

Apr 19 2017, 4:47 PM · Feature Request
epriestley merged T12597: Change the position of the "milestone" columns in a workboard into T12144: Ability to reorder milestones on a project's workboard.
Apr 19 2017, 4:46 PM · Projects, Feature Request
epriestley merged task T12597: Change the position of the "milestone" columns in a workboard into T12144: Ability to reorder milestones on a project's workboard.
Apr 19 2017, 4:46 PM · Feature Request
RikiWiki created T12598: create a milestone of milestone.
Apr 19 2017, 4:46 PM · Feature Request
chad added a comment to T12594: Scrolling to the right-hand side locks the mouse arrow to the orizonatal scroll bar and prevents navigation.

I can't reproduce this.

Apr 19 2017, 4:45 PM · Bug Report
RikiWiki created T12597: Change the position of the "milestone" columns in a workboard.
Apr 19 2017, 4:43 PM · Feature Request
epriestley added a revision to T12596: Fulltext stopword filtering is applying before stemming and failing to filter forms of words which stem to stopwords: Unknown Object (Differential Revision).
Apr 19 2017, 4:00 PM · Search, Customer Impact
epriestley updated the task description for T12596: Fulltext stopword filtering is applying before stemming and failing to filter forms of words which stem to stopwords.
Apr 19 2017, 3:33 PM · Search, Customer Impact
epriestley created T12596: Fulltext stopword filtering is applying before stemming and failing to filter forms of words which stem to stopwords.
Apr 19 2017, 3:31 PM · Search, Customer Impact
RikiWiki added a comment to T12594: Scrolling to the right-hand side locks the mouse arrow to the orizonatal scroll bar and prevents navigation.

On the 26th we will update the version to the new one, I have been told.

Apr 19 2017, 3:19 PM · Bug Report
epriestley added a comment to T12588: create subtask side menu to allow creation of subtasks of different types to the parent task.

Allowing users to select a subform from "Create Subtask" isn't technically very difficult, but it starts to potentially make the UI pretty messy and complicated. Some possible implementations are:

Apr 19 2017, 3:16 PM · Feature Request
RikiWiki added a comment to T12594: Scrolling to the right-hand side locks the mouse arrow to the orizonatal scroll bar and prevents navigation.

TEST:
Version Information

Apr 19 2017, 3:05 PM · Bug Report
epriestley added a comment to T12592: User awaiting approval has no image.

For my own reference, T12570 isn't exactly related but can probably be tested/fixed at the same time.

Apr 19 2017, 2:35 PM · Bug Report, Auth
epriestley claimed T12592: User awaiting approval has no image.

Stealing this since I think it's session/auth related, not profile picture related: I think the user has a legitimate picture, they just aren't allowed to download it since they have a partial session.

Apr 19 2017, 2:35 PM · Bug Report, Auth
epriestley added a comment to T12592: User awaiting approval has no image.

T8918 is related.

Apr 19 2017, 2:33 PM · Bug Report, Auth
epriestley merged T12593: Allow to save custom workboard filters other than "default" into T12374: Saved Workboard Queries.
Apr 19 2017, 2:22 PM · Workboards, Feature Request
epriestley merged task T12593: Allow to save custom workboard filters other than "default" into T12374: Saved Workboard Queries.
Apr 19 2017, 2:22 PM · Feature Request
epriestley added a comment to T12593: Allow to save custom workboard filters other than "default".

I'm going to merge this into T12374.

Apr 19 2017, 2:22 PM · Feature Request
chad added a comment to T12594: Scrolling to the right-hand side locks the mouse arrow to the orizonatal scroll bar and prevents navigation.

Please read and follow Contributing Bug Reports. Specifically this does not state which version of Phabricator you are running.

Apr 19 2017, 2:18 PM · Bug Report
RikiWiki created T12594: Scrolling to the right-hand side locks the mouse arrow to the orizonatal scroll bar and prevents navigation.
Apr 19 2017, 1:51 PM · Bug Report
arcadien awarded T5229: Fixing up invalid encoding confuses archanists utf8-check a Like token.
Apr 19 2017, 1:10 PM · Bug Report, Arcanist
arcadien added a comment to T5229: Fixing up invalid encoding confuses archanists utf8-check.

Is Arcanist saving information about files somewhere? or is it just a problem with the utf8 validator?

Apr 19 2017, 1:10 PM · Bug Report, Arcanist
kislinsk created T12593: Allow to save custom workboard filters other than "default".
Apr 19 2017, 10:23 AM · Feature Request
Nick.Sephton added a comment to T12314: Support formal task subtypes (like "bug" vs "feature").

How can I change the subtype of an existing task? This only allows me to load tasks into a form specific to their existing subtype. (i.e. I have an animal, I want to edit it and change it into a plant.)

Apr 19 2017, 9:44 AM · EditEngine, Maniphest, Custom Fields, Feature Request
Pawka edited P2041 Masterwork From Distant Lands.
Apr 19 2017, 5:54 AM
chad created T12592: User awaiting approval has no image.
Apr 19 2017, 4:29 AM · Bug Report, Auth
chad created T12591: Dismantle ConpherenceUpdateController into more logical controllers.
Apr 19 2017, 2:41 AM · Conpherence (v4)
chad added a revision to T7567: Support sound in Conpherence: Unknown Object (Differential Revision).
Apr 19 2017, 12:32 AM · Conpherence (v4)
mreeder awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Manufacturing Defect? token.
Apr 19 2017, 12:02 AM · Workboards (v3), Restricted Project

Apr 18 2017

uraveragechump added a comment to T12495: Provide a conduit method to retrieve inline comments associated with a diff.

Thanks epriestley!

Apr 18 2017, 11:41 PM · Feature Request
epriestley created T12590: Owners expects users to choose a repository with a <select /> that lists every repository in ID order.
Apr 18 2017, 11:12 PM · Owners
chad added a comment to T12589: Add yourself to corporate website /about/.

On meta

Apr 18 2017, 10:29 PM · Public & Media Relations
chad added a comment to T12589: Add yourself to corporate website /about/.

Corgi

Apr 18 2017, 10:28 PM · Public & Media Relations
amckinley added a comment to T12589: Add yourself to corporate website /about/.

Yeah, I was surprised neither of you jumped on "phounder". Where does that content live? I can't seem to find it in any of the repos I already have checked out.

Apr 18 2017, 10:26 PM · Public & Media Relations
chad added a comment to T12589: Add yourself to corporate website /about/.

(choose whatever you like)

Apr 18 2017, 10:15 PM · Public & Media Relations
chad added a comment to T12589: Add yourself to corporate website /about/.

I think we should all pick "Ph" titles.

Apr 18 2017, 10:15 PM · Public & Media Relations
amckinley added a comment to T12589: Add yourself to corporate website /about/.

Only if I get a cool title.

Apr 18 2017, 10:13 PM · Public & Media Relations
amckinley changed the image for Image Macro "hackerman".
Apr 18 2017, 10:13 PM
chad created T12589: Add yourself to corporate website /about/.
Apr 18 2017, 10:05 PM · Public & Media Relations
epriestley added a comment to T11476: Record transaction histories when users edit application capabilities.

@amckinley Let me know if you need more to go on than the description above or get stuck anywhere.

Apr 18 2017, 9:35 PM · Contributor Onboarding, Restricted Project, Applications, Feature Request