Page MenuHomePhabricator
Feed All Stories

Sep 1 2016

jessjohnson added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

I've been running load tests for the past 2-3 hours and for some reason, I can't bring it down anymore. You can probably mark this bug as 'unable to reproduce'. I'll continue looking into the issue and see if there's a definitive way to reproduce.

Sep 1 2016, 8:36 PM · Bug Report
venky created T11574: Consider making "Page updated, reload" notification more prominent.
Sep 1 2016, 8:33 PM · Feature Request
venky added a comment to T11530: Conduit query for Differential revisions mentioning a project.
In T11530#192966, @chad wrote:

Maybe create a bot user called @shipit to trigger herald? Mentioning users CCs them to the object, but mentioning projects does nothing currently.

Sep 1 2016, 8:29 PM · Herald, Conduit, Differential, Feature Request
chad added a revision to T11132: New Phabricator NUX: Unknown Object (Differential Revision).
Sep 1 2016, 8:07 PM · Design, Phacility, NUX
epriestley added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

I'm not immediately sure about the daemon confusion, although I suspect it's not likely to be a hint at the root issue. Caching for setup issues falls back to some pretty whacky shenanigans with APC/APCu disabled.

Sep 1 2016, 7:08 PM · Bug Report
epriestley added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

That's probably a webhook URI configured in feed.http-hooks (which may no longer be configured).

Sep 1 2016, 7:05 PM · Bug Report
jessjohnson added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

I've started the load tests without APC. One odd item I didn't notice before that may or may not be related is that Phabricator is having a hard time knowing that daemons are running (e.g. you have 2 unresolved setup issues instead of just 1 because APC is turned off). I checked the daemon logs and see they are flooded with this with one entry occurring a lot. I can't track down the source because I don't know what address it's trying to reach out to (is this a repository pull or a herald rule?). Again, this may be completely unrelated and a different issue all together.

Sep 1 2016, 6:59 PM · Bug Report
epriestley added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

I don't see anything interesting in Multimeter, it just shows that the host doesn't see much traffic and that we probably need to update some package definitions.

Sep 1 2016, 6:40 PM · Bug Report
jessjohnson added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

Are you running APC (Config → Cache Status shows APC as the active "Data Cache")?

If so, can you reproduce it if you disable APC (apc.enabled=0 in php.ini), restart apache, verify that no "Data Cache" is available any more in Config → Cache Status, and then use the takedown script?

Sep 1 2016, 6:36 PM · Bug Report
jessjohnson added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

Here's the output. I removed "events" from some of them to improve formatting.

Sep 1 2016, 6:33 PM · Bug Report
epriestley added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

Are you running APC (Config → Cache Status shows APC as the active "Data Cache")?

Sep 1 2016, 6:29 PM · Bug Report
jessjohnson added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

I've added a simple javascript file on the installation I grabbed this report from. As part of the troubleshooting process, I installed a vanilla installation of Phabricator on a separate machine with no modifications (version referenced in the bug report) and was able to reproduce the problem.

Sep 1 2016, 6:24 PM · Bug Report
epriestley added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

Also, can you show me what these pages look like?

Sep 1 2016, 6:23 PM · Bug Report
caov297 closed Q484: Does phabricator team do static code analysis on phabricator code base? as resolved.
Sep 1 2016, 6:23 PM
caov297 added Q484: Does phabricator team do static code analysis on phabricator code base? (Answer 454).
Sep 1 2016, 6:22 PM
epriestley added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

GET /res/phabricator/86668b8e/rsrc/js/phui/rdar.js HTTP/1.1

Sep 1 2016, 6:20 PM · Bug Report
jessjohnson created T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.
Sep 1 2016, 6:12 PM · Bug Report
epriestley updated the answer details for Q484: Does phabricator team do static code analysis on phabricator code base? (Answer 453).
Sep 1 2016, 6:03 PM
epriestley added Q484: Does phabricator team do static code analysis on phabricator code base? (Answer 453).
Sep 1 2016, 6:03 PM
caov297 updated Q484: Does phabricator team do static code analysis on phabricator code base? from to Does phabricator team do static code analysis on phabricator code base?.
Sep 1 2016, 5:45 PM
avivey added Q482: Any plan to add mobile clients? (Answer 452).
Sep 1 2016, 5:38 PM
avivey updated the question details for Q481: base URI & Allowed URI change issues .
Sep 1 2016, 5:31 PM
avivey added Q481: base URI & Allowed URI change issues (Answer 451).
Sep 1 2016, 5:31 PM
avivey updated the question details for Q481: base URI & Allowed URI change issues .
Sep 1 2016, 5:28 PM
epriestley added a comment to T11572: Herald Rule not inheriting Object policy from Project in a way I understand.

This is a bug with how relative/object policies and inherited/indirect policies interact.

Sep 1 2016, 4:39 PM · Bug Report
ephemeris created T11572: Herald Rule not inheriting Object policy from Project in a way I understand.
Sep 1 2016, 4:33 PM · Bug Report
chad added a comment to T11530: Conduit query for Differential revisions mentioning a project.

Maybe create a bot user called @shipit to trigger herald? Mentioning users CCs them to the object, but mentioning projects does nothing currently.

Sep 1 2016, 3:44 PM · Herald, Conduit, Differential, Feature Request
andl added a comment to T11570: `arc patch` download empty binary file from hosted svn repository.

looks like a duplicate of T8647

Sep 1 2016, 2:34 PM · Arcanist, Bug Report
aubort added a comment to T11568: Daemons queue usage is low leading to slow imports.

Okay, thank you for the pointers, we have indeed a huge performance improvement using standard mysql replication, which seems to increase the queue usage.

Sep 1 2016, 2:32 PM · Diffusion, Bug Report
epriestley added a project to T11547: Paste query results do not display actual length of listed Pastes (but always "5 lines" if Paste is longer): Contributor Onboarding.
Sep 1 2016, 2:29 PM · Contributor Onboarding, Paste, Bug Report
epriestley renamed T11566: Provide more complete guidance on using regular expressions in Herald from Herald docs require better information around how to use contains, matches regexp, matches regexp pairs...etc to Provide more complete guidance on using regular expressions in Herald.
Sep 1 2016, 2:26 PM · Herald, Documentation
epriestley created T11571: Consider benchmarking hardware during setup.
Sep 1 2016, 2:24 PM · Setup
epriestley closed T11568: Daemons queue usage is low leading to slow imports as Resolved.

I'm going to close this for now since I don't plan to take any further action as the upstream; this appears to be an environmental issue (which we don't offer support for) rather than a scalability limitation (which we do).

Sep 1 2016, 2:21 PM · Diffusion, Bug Report
epriestley added a comment to T11570: `arc patch` download empty binary file from hosted svn repository.

I've just dumped this on the pile of arc patch-related bugs. Some of them are likely duplicates, possibly including this one, but I don't expect to dig through that pile until the next major iteration on arc, since at least some of them are likely not addressable without other changes. T11429 has a rough overview of upcoming plans.

Sep 1 2016, 2:12 PM · Arcanist, Bug Report
epriestley moved T11570: `arc patch` download empty binary file from hosted svn repository from Backlog to arc patch on the Arcanist board.
Sep 1 2016, 2:08 PM · Arcanist, Bug Report
epriestley added a project to T11570: `arc patch` download empty binary file from hosted svn repository: Arcanist.
Sep 1 2016, 2:08 PM · Arcanist, Bug Report
epriestley triaged T11567: Allow dashes in monospace font preferences as Low priority.
Sep 1 2016, 2:07 PM · Contributor Onboarding, User Preferences
epriestley moved T11567: Allow dashes in monospace font preferences from Backlog to Basic on the Contributor Onboarding board.
Sep 1 2016, 2:06 PM · Contributor Onboarding, User Preferences
epriestley assigned T11567: Allow dashes in monospace font preferences to jcox.
  • Try to come up with a way that - can do something dangerous when injected into a CSS rule.
    • See D7274#47131 for a template of how to attack this.
    • If you can come up with any attacks, don't implement this.
  • Adjust the regular expression in PhabricatorMonospacedFontSetting::filterMonospacedCSSRule() to include -.
  • Adjust the error text in PhabricatorMonospacedFontSetting->validateTransactionValue() to say "..., hyphens, ..." or similar.
Sep 1 2016, 2:05 PM · Contributor Onboarding, User Preferences
• damio added a comment to Q483: Why is the "Need Triage" priority higher than all the others ? (Answer 449).

Thanks a lot, that's what I was looking for :)

Sep 1 2016, 1:57 PM
chad added a comment to Q483: Why is the "Need Triage" priority higher than all the others ? (Answer 449).

Most of my "Needs Triage" tickets are people randomly putting things

Sep 1 2016, 1:52 PM
kristo.mario added Q483: Why is the "Need Triage" priority higher than all the others ? (Answer 450).
Sep 1 2016, 1:48 PM
kristo.mario added a comment to Q483: Why is the "Need Triage" priority higher than all the others ?.
Sep 1 2016, 1:48 PM · Maniphest
shuLhan added a comment to T3179: Importing data from external systems (like GitHub, JIRA, Trac, Asana, Trello, etc.).

Hello to all,

Sep 1 2016, 12:57 PM · Guides, Doorkeeper
• damio added a comment to Q483: Why is the "Need Triage" priority higher than all the others ? (Answer 449).

Most of my "Needs Triage" tickets are people randomly putting things (it's really like a wishlist), if something is really urgent it's either marked with "Unbreak Now" (99% of the time) or people spam everybody with it.

Sep 1 2016, 12:51 PM
epriestley added Q483: Why is the "Need Triage" priority higher than all the others ? (Answer 449).
Sep 1 2016, 12:24 PM
• damio added a project to Q483: Why is the "Need Triage" priority higher than all the others ?: Maniphest.
Sep 1 2016, 11:40 AM · Maniphest
• damio updated Q483: Why is the "Need Triage" priority higher than all the others ? from to Why is the "Need Triage" priority higher than all the others ?.
Sep 1 2016, 11:40 AM · Maniphest
andl created T11570: `arc patch` download empty binary file from hosted svn repository.
Sep 1 2016, 11:18 AM · Arcanist, Bug Report
benjumanji added a comment to T10456: Conduit interprets all arguments from curl requests as strings.
params="                                                                                                                                                                                   
    {                                                                                                                                                                                      
        \"buildTargetPHID\": \"$PHID\",                                                                                                                                                    
        \"artifactKey\": \"jenkins.uri.$PHID\",                                                                                                                                            
        \"artifactType\": \"uri\",                                                                                                                                                         
        \"artifactData\": {                                                                                                                                                                
            \"uri\": \"http://build:8080/job/$JOB_NAME/$BUILD_NUMBER\",                                                                                                                    
            \"name\": \"Jenkins Build\",                                                                                                                                                   
            \"ui.external\": true                                                                                                                                                          
        },                                                                                                                                                                                 
        \"__conduit__\": { \"token\": \"$CONDUIT_API_TOKEN\" }                                                                                                                             
    }"
Sep 1 2016, 9:25 AM · Restricted Project, Conduit, Bug Report
huangsj updated Q482: Any plan to add mobile clients? from to Any plan to add mobile clients?.
Sep 1 2016, 8:01 AM
lostinspace updated Q481: base URI & Allowed URI change issues from to base URI & Allowed URI change issues .
Sep 1 2016, 6:31 AM

Aug 31 2016

donaldguy awarded T10456: Conduit interprets all arguments from curl requests as strings a Dislike token.
Aug 31 2016, 11:24 PM · Restricted Project, Conduit, Bug Report
donaldguy added a comment to T10456: Conduit interprets all arguments from curl requests as strings.

if it helps anyone, the workaround "fix" is to place the following code in the file "src/applications/conduit/parametertype/ConduitBoolParameterType.php "

$value = (boolean) $value;

at about line 9 just before the following piece of code:

if (!is_bool($value)) {

Its a bit of a hack, so I'm not sure how much to trust this workaround for a production instance of Phabricator, but hopefully, it helps someone out there. The issue is (I think) basically related to http://stackoverflow.com/questions/27446946/preserve-data-type-of-post-fields-when-sending-data-using-php-and-curl where PHP converts the curl input as a string.

Aug 31 2016, 11:15 PM · Restricted Project, Conduit, Bug Report
epriestley added a comment to T11568: Daemons queue usage is low leading to slow imports.

I'm not entirely sure, but it seems plausible. We compute "Queue Utilization" as basically:

Aug 31 2016, 10:43 PM · Diffusion, Bug Report
aubort added a comment to T11568: Daemons queue usage is low leading to slow imports.

Okay, seems bad indeed, do you think it might explain why the queue is capped at 20-30% ?

Aug 31 2016, 10:18 PM · Diffusion, Bug Report
epriestley added a revision to T7924: Unprototype Calendar (v1): Unknown Object (Differential Revision).
Aug 31 2016, 10:13 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T11569: Nuance is fataling with calls to setIcon().

No, not updated yet.

Aug 31 2016, 9:59 PM · Nuance
Luke081515.2 added a comment to T11569: Nuance is fataling with calls to setIcon().

This instance isn't updated yet, is it? We got that error still....

Aug 31 2016, 9:57 PM · Nuance
epriestley added a comment to T7924: Unprototype Calendar (v1).

Well, "trivial" might be a little ambitious.

Aug 31 2016, 9:54 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T7924: Unprototype Calendar (v1).

Ah, thanks! That's a bug which we hadn't run into yet, but it's trivial to fix.

Aug 31 2016, 9:50 PM · Restricted Project, Prioritized, Calendar
avivey placed T10746: Aborted build in Harbormaster still shows as building in Diffusion up for grabs.

"Failed builds show as building" is actually very different from "Aborted builds show as building". Handling the Aborting one is a more involved than I'd like to dig into right now.

Aug 31 2016, 9:38 PM · Restricted Project, Harbormaster, Bug Report
polybuildr added a comment to T7924: Unprototype Calendar (v1).

When tasks are mentioned in calendar descriptions (afaik very common for meeting agendas), the usual "<user> mentioned this in <place>" does not show up on the task. Is this part of the unprototyping effort?

Aug 31 2016, 9:34 PM · Restricted Project, Prioritized, Calendar
avivey added a revision to T10746: Aborted build in Harbormaster still shows as building in Diffusion: Unknown Object (Differential Revision).
Aug 31 2016, 9:29 PM · Restricted Project, Harbormaster, Bug Report
avivey claimed T10746: Aborted build in Harbormaster still shows as building in Diffusion.
Aug 31 2016, 9:23 PM · Restricted Project, Harbormaster, Bug Report
epriestley added a comment to T11568: Daemons queue usage is low leading to slow imports.
...
13. >>> [4] <query> INSERT INTO `daemon_log` ...
14. <<< [4] <query> 870,858 us
...
Aug 31 2016, 8:46 PM · Diffusion, Bug Report
aubort added a comment to T11568: Daemons queue usage is low leading to slow imports.

Yes, here it is.

Aug 31 2016, 8:38 PM · Diffusion, Bug Report
chad added a revision to T11132: New Phabricator NUX: Unknown Object (Differential Revision).
Aug 31 2016, 8:11 PM · Design, Phacility, NUX
epriestley added a comment to T11568: Daemons queue usage is low leading to slow imports.

Okay. Can you run this command?

Aug 31 2016, 8:00 PM · Diffusion, Bug Report
aubort added a comment to T11568: Daemons queue usage is low leading to slow imports.

Ah yes sorry, I saw some other reference to Nuance today and thought it was for that.

Aug 31 2016, 7:31 PM · Diffusion, Bug Report
epriestley added a comment to T11568: Daemons queue usage is low leading to slow imports.

Oh, no, this is the right task. Your logs:

Aug 31 2016, 6:45 PM · Diffusion, Bug Report
chad triaged T11542: Make remarkup checklists interactive as Wishlist priority.
Aug 31 2016, 6:21 PM · Remarkup, Feature Request
avivey renamed T11567: Allow dashes in monospace font preferences from Allow dashes in monospace font to Allow dashes in monospace font preferences.
Aug 31 2016, 5:52 PM · Contributor Onboarding, User Preferences
aubort added a comment to T11568: Daemons queue usage is low leading to slow imports.

I think you may have answered to the wrong task :)

Aug 31 2016, 5:29 PM · Diffusion, Bug Report
epriestley added a comment to T11568: Daemons queue usage is low leading to slow imports.

Someone has configured a bad Nuance source, so let's start by fixing that.

Aug 31 2016, 5:09 PM · Diffusion, Bug Report
kislinsk awarded T10500: When diffing B against A in Differential, files touched in A but not B should be finessed better a Like token.
Aug 31 2016, 5:00 PM · Restricted Project, Differential
epriestley closed T11569: Nuance is fataling with calls to setIcon() as Resolved by committing Restricted Diffusion Commit.
Aug 31 2016, 5:00 PM · Nuance
chad added a project to T11568: Daemons queue usage is low leading to slow imports: Diffusion.
Aug 31 2016, 4:54 PM · Diffusion, Bug Report
chad added a project to T11567: Allow dashes in monospace font preferences: User Preferences.
Aug 31 2016, 4:54 PM · Contributor Onboarding, User Preferences
epriestley added a revision to T11569: Nuance is fataling with calls to setIcon(): Unknown Object (Differential Revision).
Aug 31 2016, 4:51 PM · Nuance
chad added a comment to T11569: Nuance is fataling with calls to setIcon().

i should have kept a helper function in, but was worried we'd never find the callsites.

Aug 31 2016, 4:11 PM · Nuance
chad added a comment to T11569: Nuance is fataling with calls to setIcon().

sadpanda

Aug 31 2016, 4:10 PM · Nuance
epriestley added a project to T11569: Nuance is fataling with calls to setIcon(): Nuance.
Aug 31 2016, 4:08 PM · Nuance
epriestley created T11569: Nuance is fataling with calls to setIcon().
Aug 31 2016, 4:08 PM · Nuance
aubort updated the task description for T11568: Daemons queue usage is low leading to slow imports.
Aug 31 2016, 3:57 PM · Diffusion, Bug Report
aubort updated the task description for T11568: Daemons queue usage is low leading to slow imports.
Aug 31 2016, 3:51 PM · Diffusion, Bug Report
aubort created T11568: Daemons queue usage is low leading to slow imports.
Aug 31 2016, 3:47 PM · Diffusion, Bug Report
epriestley added Q419: Slow imports of commit and how to scale up (Answer 448).
Aug 31 2016, 2:55 PM
epriestley added a parent task for T11566: Provide more complete guidance on using regular expressions in Herald: T8644: Herald template / recipe book / examples / quick-create tool.
Aug 31 2016, 2:32 PM · Herald, Documentation
epriestley added a subtask for T8644: Herald template / recipe book / examples / quick-create tool: T11566: Provide more complete guidance on using regular expressions in Herald.
Aug 31 2016, 2:32 PM · Restricted Project, Herald
epriestley triaged T11566: Provide more complete guidance on using regular expressions in Herald as Low priority.
Aug 31 2016, 2:32 PM · Herald, Documentation
epriestley added a comment to T11566: Provide more complete guidance on using regular expressions in Herald.

The reason we suggest @ as a delimiter is that you don't have to escape forward slashes if you use a delimiter other than /, so you get a more readable regexp.

Aug 31 2016, 2:31 PM · Herald, Documentation
MattSeen added a comment to T11566: Provide more complete guidance on using regular expressions in Herald.

I think I'm going insane. I was wrangling with that for ages and as you pointed out /\.js$/ does in fact work. I have no idea how I did every permutations of that regex except that one.

Aug 31 2016, 1:38 PM · Herald, Documentation
drinic.bojan added a comment to T5368: Update page title to display notification count.

Hello
I agree with @richardvanvelzen this is very very useful option.
Especially in scenarios like this, for people that like to have important tasks open in tabs.

pasted_file (44×1 px, 6 KB)

Also in this example you can see how slack uses favicon change to notify about new message.
It can be option in phabricator configuration, and also phabricator already supports similar notification but only after you view tab with task?
pasted_file (588×337 px, 13 KB)

Aug 31 2016, 1:11 PM · Badge Awarded, Aphlict
aubort marked Q419: Slow imports of commit and how to scale up (Answer 394) as visible.
Aug 31 2016, 12:49 PM
aubort marked Q419: Slow imports of commit and how to scale up (Answer 394) as hidden.
Aug 31 2016, 12:49 PM
aubort added a comment to Q419: Slow imports of commit and how to scale up.

Hi, we're still strugling with this issue, anybody had to deal with this already ? Is there a plan on optimizing commit parsing and daemons scalability ?

Aug 31 2016, 12:49 PM · Daemons
epriestley added a comment to T11567: Allow dashes in monospace font preferences.

I believe this is fine; I can't immediately come up with an attack using -.

Aug 31 2016, 12:35 PM · Contributor Onboarding, User Preferences
• jgdye created T11567: Allow dashes in monospace font preferences.
Aug 31 2016, 12:30 PM · Contributor Onboarding, User Preferences
epriestley added a comment to T11566: Provide more complete guidance on using regular expressions in Herald.

Form (1) is expected to work, which is why we don't document a need for form (7): one is not expected to exist. If form (1) does not work, this is a bug with Herald itself, not with the Herald documentation.

Aug 31 2016, 12:25 PM · Herald, Documentation