Page MenuHomePhabricator
Feed All Stories

Feb 3 2016

chad added a comment to T10273: Viewing any file (regardless of size) in Diffusion throws Unhandled Exception..

https://secure.phabricator.com/book/phabricator/article/configuring_file_storage/ explains file storage in Phabricator.

Feb 3 2016, 9:32 PM · Diffusion, Bug Report
chad added a comment to T10273: Viewing any file (regardless of size) in Diffusion throws Unhandled Exception..

Maybe I'm missing something obvious, You say if you set the local-disk path the error goes away. So what is the bug you are reporting, specifically, and how can we reproduce it.

Feb 3 2016, 9:29 PM · Diffusion, Bug Report
perezd added a comment to T10273: Viewing any file (regardless of size) in Diffusion throws Unhandled Exception..

Yes?

Feb 3 2016, 9:28 PM · Diffusion, Bug Report
chad added a comment to T10273: Viewing any file (regardless of size) in Diffusion throws Unhandled Exception..

Is this a bug report?

Feb 3 2016, 9:27 PM · Diffusion, Bug Report
avivey updated the task description for T10273: Viewing any file (regardless of size) in Diffusion throws Unhandled Exception..
Feb 3 2016, 9:15 PM · Diffusion, Bug Report
perezd created T10273: Viewing any file (regardless of size) in Diffusion throws Unhandled Exception..
Feb 3 2016, 9:13 PM · Diffusion, Bug Report
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Feb 3 2016, 9:07 PM · Projects (v3)
epriestley added a comment to T10000: Consider restoring Clowncopterize.

It can't currently move to translations or be per-user because it has global effects, notably the availability of "silly" statuses in Maniphest. We can't show different users different sets of available task statuses.

Feb 3 2016, 8:38 PM · Differential, Feature Request
chad added a comment to T10000: Consider restoring Clowncopterize.

I imagine it will move to translations at some point, like Doge and Pirate.

Feb 3 2016, 8:32 PM · Differential, Feature Request
spawnlt added a comment to T10000: Consider restoring Clowncopterize.

Yes @epriestley, but it is a global setting and when you mentioned this Corpo-Vision® thing I though of it as a user setting, because all of us see the world differently.

Feb 3 2016, 8:32 PM · Differential, Feature Request
chad changed the visibility for T1960: Breadcrumbs or similar UI-navigation for getting back to the ticket overview.
Feb 3 2016, 8:32 PM · Maniphest
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Feb 3 2016, 8:14 PM · Projects (v3)
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Feb 3 2016, 8:03 PM · Projects (v3)
epriestley added a comment to T10000: Consider restoring Clowncopterize.

Such a setting already exists: Config → phabricator.serious-business

Feb 3 2016, 7:42 PM · Differential, Feature Request
spawnlt added a comment to T10000: Consider restoring Clowncopterize.

....
In contrast, I can't offhand recall anyone ever complaining that the header text says "Weigh In" instead of "Add Comments".

Feb 3 2016, 7:35 PM · Differential, Feature Request
award created T10272: Expose "branched from" information in conduit differential API.
Feb 3 2016, 7:15 PM · Restricted Project, Conduit, Feature Request
michaeljs1990 added a comment to T10260: Harbormaster Herald Rules.

Our use case is fairly atypical unfortunately. We have builds setup to run every time a diff is pushed. These diffs run integration tests that could take anywhere from 30minutes to a few hours and we don't require them passing since it's an extra step on top of unit tests running. However in the event that a longer running test breaks after a diff is landed we want to be able to alert not only the user who broke the integration test but also a group of users who are actively maintaining them incase they need to coordinate work.

Feb 3 2016, 7:08 PM · Haskell.org, Restricted Project, Harbormaster, Feature Request
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Feb 3 2016, 7:08 PM · Projects (v3)
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Feb 3 2016, 5:52 PM · Projects (v3)
spawnlt awarded T6526: Implement "Badges" or "Medals", for annotating special users a Like token.
Feb 3 2016, 5:43 PM · Restricted Project, Badges (v0), People
epriestley added a comment to T10260: Harbormaster Herald Rules.

To be more specific, I just mean:

Feb 3 2016, 5:31 PM · Haskell.org, Restricted Project, Harbormaster, Feature Request
michaeljs1990 added a comment to T10260: Harbormaster Herald Rules.

Good point. When i was testing this i hooked into the Test Consul and allowed buildables to be passed in so everything was seemingly working for me. I am guessing i need to dig a littler deeper into the harbormaster transactions to get this working properly.

Feb 3 2016, 5:18 PM · Haskell.org, Restricted Project, Harbormaster, Feature Request
epriestley edited projects for T10264: git clone using http hangs after update, added: Bug Report (Needs Information); removed Bug Report.

I'm out of ideas and can't reproduce this problem, then, so we can't move forward (see Contributing Bug Reports). Here's, e.g., this working fine for me against this server:

Feb 3 2016, 4:52 PM · Bug Report, Diffusion
arandrea added a comment to T10264: git clone using http hangs after update.

I updated to get rP9d125b45 and there is no change. Cloning a repo using http still hangs. I then reverted the change in rP8269fd6 and that did not fix the problem either.

Feb 3 2016, 4:49 PM · Bug Report, Diffusion
andyboeh added a comment to T9639: Unable to push to hosted Mercurial repository over SSH with new upstream bookmark position.

@cspeckmim I just fixed that, unfortunately, it doesn't help. Here is a complete debug output when trying to push:

Feb 3 2016, 3:30 PM · Diffusion, Mercurial
marcel.baracchi added a comment to T10265: VCS password using LDAP.

Thanks for the update of the documentation and the explanation. Perfectly fine for me.

Feb 3 2016, 3:25 PM · Diffusion, Feature Request
epriestley changed the status of T10265: VCS password using LDAP from Wontfix to Resolved by committing Restricted Diffusion Commit.
Feb 3 2016, 3:23 PM · Diffusion, Feature Request
epriestley closed T10054: Define product direction for Project/Profile UIs as Resolved.

I think this has served its purpose, so I'm going to close it out. Results:

Feb 3 2016, 2:50 PM · Projects
epriestley closed T10054: Define product direction for Project/Profile UIs, a subtask of T10010: Implement Subprojects, as Resolved.
Feb 3 2016, 2:50 PM · Projects (v3)
cspeckmim added a comment to T9639: Unable to push to hosted Mercurial repository over SSH with new upstream bookmark position.

@andyboeh - I think there might be an issue with some of the fixes I was looking at. When removing the bundle2 capability from reply, the message preceding the capabilities output is a length of the following line, usually something like

242
capabilities: a, b, c, d, bundle2=http%%%%%...

By just removing bundle2 it causes the preceding number to be off, which is what the client uses for parsing the stream. I haven't gotten back to looking at this but I think that's the issue you're seeing.

Feb 3 2016, 2:40 PM · Diffusion, Mercurial
epriestley closed T10271: Test bug as Spite.
Feb 3 2016, 2:37 PM · Bug Report
• prab.raja created T10271: Test bug.
Feb 3 2016, 2:32 PM · Bug Report
epriestley added a comment to T10260: Harbormaster Herald Rules.

How are these tests executing?

Feb 3 2016, 2:14 PM · Haskell.org, Restricted Project, Harbormaster, Feature Request
epriestley added a comment to T10264: git clone using http hangs after update.

I'm unable to reproduce this against this host or hosts in the Phacility cluster.

Feb 3 2016, 2:12 PM · Bug Report, Diffusion
epriestley closed T10265: VCS password using LDAP as Wontfix.

D15173 updates the documentation.

Feb 3 2016, 2:02 PM · Diffusion, Feature Request
epriestley added a revision to T10265: VCS password using LDAP: Unknown Object (Differential Revision).
Feb 3 2016, 1:58 PM · Diffusion, Feature Request
storrgie added a comment to T4947: SELinux / AppArmor ruin everything all the time.

It wasn't too much of a hunt, but I did go easy mode towards the end (audit2allow). For others he is my basic install notes on Fedora 23 server:

Feb 3 2016, 1:54 PM · Setup
epriestley closed T10270: Permissions posture for Database as Invalid.

doesn't seem like good practice

Feb 3 2016, 1:48 PM · Installing & Upgrading
storrgie created T10270: Permissions posture for Database.
Feb 3 2016, 1:33 PM · Installing & Upgrading
storrgie added a comment to T4181: Document (the lack of) init scripts for phd, and be more explicit about `phd launch`.

I'm using this unit file, which works when I manually start it or restart it. However, if I do a cold boot of the system the unit fails and I have to ssh in and manually restart it.

Feb 3 2016, 1:11 PM · Phabricator
rphl awarded M1458: Homepage 2016 a Like token.
Feb 3 2016, 12:42 PM
joshuaspence added a comment to T10268: "Batch Edit" from workboards uses "?ids=X,Y,Z" which can exceed "Location" header or URL byte limits for large task sets.

Yeah, I suspect that the length of the header is the issue.

Feb 3 2016, 12:10 PM · Customer Impact, Workboards, Maniphest
andyboeh added a comment to T9639: Unable to push to hosted Mercurial repository over SSH with new upstream bookmark position.

I am on Mercurial 3.6 on both, the server and the client, and just tried what @cspeckmim suggested: Removing bundle2 from the capabilities in reply to the hello command. Now my client gets one step further, but still fails to push most of the time with remote: abort: stream ended unexpectedly (got 0 bytes, expected 4)

Feb 3 2016, 10:13 AM · Diffusion, Mercurial
maxie closed Q295: Template repository? as resolved.
Feb 3 2016, 9:25 AM · Diffusion
cspeckmim awarded M1458: Homepage 2016 a Love token.
Feb 3 2016, 6:20 AM
chad set the image for Bug Report (Needs Information) to Unknown Object (File).
Feb 3 2016, 6:11 AM
chad edited Description on Bug Report (Needs Information).
Feb 3 2016, 6:11 AM
bonede awarded Welcome a Doubloon token.
Feb 3 2016, 5:47 AM
ohler awarded T10246: Deploy Drydock in the Phacility cluster a Orange Medal token.
Feb 3 2016, 4:45 AM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
chad created M1458: Homepage 2016.
Feb 3 2016, 4:18 AM
joshuaspence added a comment to T9348: No way to kick users out of a Conpherence.

I tried doing an arc diff to submit my patch but ran into this,

[2016-02-02 21:15:55] EXCEPTION: (PhutilTypeExtraParametersException) Got unexpected parameters: standard at [<phutil>/src/parser/PhutilTypeSpec.php:150]
arcanist(), phabricator(head=master, ref.master=3264d9f680cb), phutil()
  #0 PhutilTypeSpec::checkMap(array, array) called at [<arcanist>/src/lint/engine/ArcanistConfigurationDrivenLintEngine.php:90]
  #1 ArcanistConfigurationDrivenLintEngine::buildLinters() called at [<arcanist>/src/workflow/ArcanistLintersWorkflow.php:44]
  #2 ArcanistLintersWorkflow::run() called at [<arcanist>/scripts/arcanist.php:382]

I could run through it by removing the following section in .arclint file,

,
    "xhpast": {
      "type": "xhpast",
      "include": "(\\.php$)"
    }

But it wouldn't let me commit.

Feb 3 2016, 12:28 AM · Conpherence (v4)

Feb 2 2016

epriestley added a comment to T10268: "Batch Edit" from workboards uses "?ids=X,Y,Z" which can exceed "Location" header or URL byte limits for large task sets.

If that's the case, a workaround is to query for the tasks in Maniphest with page size > 865 instead, then "Select All" and "Batch Edit Selected".

Feb 2 2016, 11:44 PM · Customer Impact, Workboards, Maniphest
epriestley added a comment to T10268: "Batch Edit" from workboards uses "?ids=X,Y,Z" which can exceed "Location" header or URL byte limits for large task sets.

Oh, maybe the issue is actually the redirect. Specifically, we'll end up issuing this:

Feb 2 2016, 11:43 PM · Customer Impact, Workboards, Maniphest
epriestley added a comment to T10268: "Batch Edit" from workboards uses "?ids=X,Y,Z" which can exceed "Location" header or URL byte limits for large task sets.

I can't immediately reproduce this by issuing a query for 1,000 tasks, then doing "Select All > Batch Edit Selected". The page takes a couple seconds, but loads fine.

Feb 2 2016, 11:41 PM · Customer Impact, Workboards, Maniphest
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Feb 2 2016, 11:36 PM · Projects (v3)
joshuaspence added a comment to T10269: Duplicate entry for key "key_object".

sorry that I can't provide reproduction steps

Historically, I don't think these tasks (error logs with no obvious negative effects and no reproduction steps) are very useful. I don't immediately know what's going on here, nor plan to dig into it unless it creates an observable problem.

Feb 2 2016, 11:36 PM · Maniphest
joshuaspence added a comment to T10268: "Batch Edit" from workboards uses "?ids=X,Y,Z" which can exceed "Location" header or URL byte limits for large task sets.

Well I don't choose any tasks, I guess it defaults to all objects visible on the workboard (of which there are 865).

Feb 2 2016, 11:34 PM · Customer Impact, Workboards, Maniphest
epriestley added a comment to T10268: "Batch Edit" from workboards uses "?ids=X,Y,Z" which can exceed "Location" header or URL byte limits for large task sets.

How many tasks are you attempting to batch edit?

Feb 2 2016, 10:33 PM · Customer Impact, Workboards, Maniphest
epriestley closed T10269: Duplicate entry for key "key_object" as Invalid.

sorry that I can't provide reproduction steps

Feb 2 2016, 10:32 PM · Maniphest
joshuaspence added a comment to T10269: Duplicate entry for key "key_object".

(This isn't a once off, there are a bunch of these errors)

Feb 2 2016, 10:07 PM · Maniphest
joshuaspence created T10269: Duplicate entry for key "key_object".
Feb 2 2016, 10:07 PM · Maniphest
joshuaspence created T10268: "Batch Edit" from workboards uses "?ids=X,Y,Z" which can exceed "Location" header or URL byte limits for large task sets.
Feb 2 2016, 10:05 PM · Customer Impact, Workboards, Maniphest
epriestley added a comment to T10266: Firefox body scroll fails when dragging tasks.

(Specifically, the scrolling is a feature which I added in D10188 but punted on making work in Firefox.)

Feb 2 2016, 9:57 PM · Firefox, Projects
epriestley closed T10267: Ancestral review dependency as Resolved.

Write Depends on D123. in the summary of B.

Feb 2 2016, 9:56 PM · Feature Request
exp10r3r added a revision to T9348: No way to kick users out of a Conpherence: Unknown Object (Differential Revision).
Feb 2 2016, 9:29 PM · Conpherence (v4)
exp10r3r added a comment to T9348: No way to kick users out of a Conpherence.

I tried doing an arc diff to submit my patch but ran into this,

Feb 2 2016, 9:29 PM · Conpherence (v4)
actuallymrj updated the task description for T10267: Ancestral review dependency.
Feb 2 2016, 9:23 PM · Feature Request
actuallymrj created T10267: Ancestral review dependency.
Feb 2 2016, 9:19 PM · Feature Request
• pmoreau added a comment to T10259: fetch log crashes when using IP v6 (http), fetch fails.

Tested with rP9d125b459ea8, and it's working properly: thanks for the quick fix!

Feb 2 2016, 9:18 PM · Diffusion, Bug Report
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Feb 2 2016, 9:07 PM · Projects (v3)
chad closed T10256: Unable to set default page for some projects as Resolved by committing Restricted Diffusion Commit.
Feb 2 2016, 8:45 PM · Projects, Bug Report
chad added a revision to T10256: Unable to set default page for some projects: Unknown Object (Differential Revision).
Feb 2 2016, 8:44 PM · Projects, Bug Report
chad added a comment to T10256: Unable to set default page for some projects.

Seems like once you mess with the order of the tabs, the default doesn't work.

Feb 2 2016, 8:11 PM · Projects, Bug Report
epriestley added a comment to T10256: Unable to set default page for some projects.

Nice. This is likely something easy/simple/silly, I just haven't been able to reproduce it locally and the answer has yet to come to me in a dream.

Feb 2 2016, 8:08 PM · Projects, Bug Report
chad added a comment to T10256: Unable to set default page for some projects.

I have a repro in my sandbox, will dig around.

Feb 2 2016, 8:04 PM · Projects, Bug Report
exp10r3r added a comment to T9348: No way to kick users out of a Conpherence.

I'm on the freenode IRC channel. Studying the code now. If I need any help and assuming I don't give up in between, I'll ask my questions.
And as for this thread, I think I've understood both your points.
Being an admirer of Phab's current documentation, I'll try imitating it in my work as well.

Feb 2 2016, 7:44 PM · Conpherence (v4)
chad updated the image for Mail from F235537: profile-project.png to F1087792: profile.
Feb 2 2016, 7:39 PM
CodeMouse92 added a comment to T9348: No way to kick users out of a Conpherence.

Right, yeah. CSI is somewhat separate, since most of it isn't intended to be picked up by autodoc tools, but it is also designed to not conflict with those. (I should have the published standard up on my site in the next week.) Docs are "what does the code do" and "how do I use it", CSI is "why is the code like this and what is it doing?"

Feb 2 2016, 7:36 PM · Conpherence (v4)
chad added a comment to T9348: No way to kick users out of a Conpherence.

I'm referring to that as well. Diviner builds docs from his comment blocks. Most of it is only on abstractions though like libphutil.

Feb 2 2016, 7:35 PM · Conpherence (v4)
CodeMouse92 added a comment to T9348: No way to kick users out of a Conpherence.

I'll admit, his docs are quite impressive. What I'm referring to is effectively inline-documentation of the code's intent itself, which is inherently separate from docs, and is solely to make maintenance by any programmer who takes the code on possible, without involving the previous dev in person, and largely without invoking the consequences of Brooks' Law.

Feb 2 2016, 7:33 PM · Conpherence (v4)
chad added a comment to T9348: No way to kick users out of a Conpherence.

In general @epriestley writes more documentation than any engineer I've ever met. At least, most abstractions are well documented.

Feb 2 2016, 7:31 PM · Conpherence (v4)
CodeMouse92 added a comment to T9348: No way to kick users out of a Conpherence.

I'd have to agree not to write things twice. That said, I do know that when we undertook starting our own animation system, we first dismantled the open source one we were considering prior (that's where we commented everything), and figured out the inherent problems at its core, which in turn prevented making the same mistakes in our system. Plus, some approaches may be at least partially salvageable for v2, tying back in with the basic idea of "don't code things twice".

Feb 2 2016, 7:30 PM · Conpherence (v4)
chad added a comment to T9348: No way to kick users out of a Conpherence.

For the record I did try to do this myself with my limited eng skills, and I gave up. If you're a natural with JavaScript, it's likely an easy task. I'm not.

Feb 2 2016, 7:29 PM · Conpherence (v4)
chad added a comment to T9348: No way to kick users out of a Conpherence.

There are two main issues. First being we prefer not to context switch ourselves to whatever the issue-du-jour is. That is, we're a very small team (2 people) on a very large project. We maintain throughput by being focused on the current task. We're not currently focused on Conpherence.

Feb 2 2016, 7:26 PM · Conpherence (v4)
CodeMouse92 added a comment to T9348: No way to kick users out of a Conpherence.

Right about now, it might be worth mentioning that my company instituted a standard of commenting every single logical statement in code, stating the intent of the logical statement (not just restating the code).

Feb 2 2016, 7:10 PM · Conpherence (v4)
chad added a comment to T9348: No way to kick users out of a Conpherence.

But maybe you are an adventurous soul! Code is reasonably organized by application, so src/applications/conpherence/ contains PHP and webroot/rsrc/js/application/conpherence/ contains the JavaScript.

Feb 2 2016, 7:06 PM · Conpherence (v4)
chad added a comment to T9348: No way to kick users out of a Conpherence.

The engineer who built Conpherence is no longer contributing code, which means another developer would have to learn it first to give you pointers on where to start. This isn't a great use of our time. I expect Conpherence to get overhauled sometime in the next 3-6 months.

Feb 2 2016, 6:56 PM · Conpherence (v4)
exp10r3r added a comment to T9348: No way to kick users out of a Conpherence.

Why is that?

Feb 2 2016, 6:53 PM · Conpherence (v4)
chad added a comment to T9348: No way to kick users out of a Conpherence.

This isn't a good task to learn how to contribute to Phabricator.

Feb 2 2016, 6:17 PM · Conpherence (v4)
exp10r3r added a comment to T9348: No way to kick users out of a Conpherence.

I'd like to contribute and help in finishing this. Where do I go?

Feb 2 2016, 6:16 PM · Conpherence (v4)
exp10r3r awarded T9348: No way to kick users out of a Conpherence a Love token.
Feb 2 2016, 6:14 PM · Conpherence (v4)
exp10r3r moved T3165: Provide Search in Conpherence from Future to v3 on the Conpherence board.
Feb 2 2016, 6:13 PM · Conpherence (v4)
exp10r3r moved T3165: Provide Search in Conpherence from v3 to Future on the Conpherence board.
Feb 2 2016, 6:13 PM · Conpherence (v4)
epriestley closed T10259: fetch log crashes when using IP v6 (http), fetch fails as Resolved by committing Restricted Diffusion Commit.
Feb 2 2016, 6:13 PM · Diffusion, Bug Report
chad updated the image for Wikimedia from F174386: profile-145px-Wikimedia_Foundation_RGB_logo_with_text.svg.png to F1087520: profile.
Feb 2 2016, 6:12 PM
epriestley added a revision to T10259: fetch log crashes when using IP v6 (http), fetch fails: Unknown Object (Differential Revision).
Feb 2 2016, 6:09 PM · Diffusion, Bug Report
michaeljs1990 updated the task description for T10260: Harbormaster Herald Rules.
Feb 2 2016, 6:07 PM · Haskell.org, Restricted Project, Harbormaster, Feature Request
epriestley added a comment to T10259: fetch log crashes when using IP v6 (http), fetch fails.

ip2long can also return negative values (see rP30473549).

Feb 2 2016, 5:52 PM · Diffusion, Bug Report
chad updated the image for Internet Explorer from F1064821: profile to F1087404: profile.
Feb 2 2016, 5:21 PM
chad added a project to T10264: git clone using http hangs after update: Diffusion.
Feb 2 2016, 5:03 PM · Bug Report, Diffusion