Page MenuHomePhabricator
Feed All Stories

Dec 4 2015

chad moved T4214: Allow installs to change or supplement the "Phabricator" icon from 2015 Redesign to Backlog on the Design board.
Dec 4 2015, 2:16 AM · Design
chad moved T8646: Provide more context for search results, particularly wiki documents from 2015 Redesign to Backlog on the Design board.
Dec 4 2015, 2:16 AM · Design, Search, Restricted Project
epriestley added a comment to T9898: `git branch --contains X` has cost in the realm of O(commits * branches).

(I think that --not construct is wrong, and we'd just have to enumerate every branch explicitly.)

Dec 4 2015, 2:08 AM · Restricted Project, Restricted Project, Arcanist
epriestley added a comment to T9898: `git branch --contains X` has cost in the realm of O(commits * branches).

It's also possible that we can run git log --all --format='%H %P' and git for-each-ref and implement --contains ourselves in less than 2 seconds in PHP, although this is hugely ridiculous and clearly a problem with Git if true.

Dec 4 2015, 2:01 AM · Restricted Project, Restricted Project, Arcanist
epriestley added a comment to T9898: `git branch --contains X` has cost in the realm of O(commits * branches).

If you run those commands on their own, they're also slow? Even just this?

Dec 4 2015, 1:57 AM · Restricted Project, Restricted Project, Arcanist
dgoldstein added a comment to T9898: `git branch --contains X` has cost in the realm of O(commits * branches).

Here's the first part of a trace of an arc diff for me (includes most of
the pre-commit-message work):

Dec 4 2015, 1:49 AM · Restricted Project, Restricted Project, Arcanist
dgoldstein added a comment to T9898: `git branch --contains X` has cost in the realm of O(commits * branches).

this repros reliably for me - 100% of the time.

Dec 4 2015, 1:46 AM · Restricted Project, Restricted Project, Arcanist
epriestley added a comment to T9898: `git branch --contains X` has cost in the realm of O(commits * branches).

I can't reproduce this. Here's what I did:

Dec 4 2015, 1:34 AM · Restricted Project, Restricted Project, Arcanist
joshuaspence created T9899: Chatbot requires access to the database.
Dec 4 2015, 1:30 AM · Phabot
dgoldstein created T9898: `git branch --contains X` has cost in the realm of O(commits * branches).
Dec 4 2015, 1:19 AM · Restricted Project, Restricted Project, Arcanist

Dec 3 2015

chad updated the task description for T9897: Unbeta Feedback on Phame.
Dec 3 2015, 11:49 PM · Phame
chad added a revision to T9897: Unbeta Feedback on Phame: Unknown Object (Differential Revision).
Dec 3 2015, 11:22 PM · Phame
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 3 2015, 11:19 PM · Restricted Project, ApplicationEditor, Transactions
cesarliws edited the content of Organizations Using Phabricator.
Dec 3 2015, 11:11 PM
CraigBoyd added a comment to Q182: Why git clone return 403 error when through http?.

I am getting the exact same issue.
I am prompted for a user id and password so I use the appropriate ones:
user: user_name_in_phab
password: users_password_in_phab

Dec 3 2015, 10:52 PM · Diffusion, Git
jsturgeon updated Q232: How do you import xctool unit test results into phabricator (via the -reporter 'phabricator' option) from to How do you import xctool unit test results into phabricator (via the -reporter 'phabricator' option).
Dec 3 2015, 10:46 PM
chad added a comment to T9441: Cygwin PHP segfaults with arcanist.

+1 for cygwin/babun support.

Dec 3 2015, 10:43 PM · Windows, Arcanist
franshamk added a comment to T9441: Cygwin PHP segfaults with arcanist.

+1 for cygwin/babun support.

Dec 3 2015, 10:33 PM · Windows, Arcanist
chad added a revision to T9897: Unbeta Feedback on Phame: Unknown Object (Differential Revision).
Dec 3 2015, 10:29 PM · Phame
chad updated the task description for T9897: Unbeta Feedback on Phame.
Dec 3 2015, 10:08 PM · Phame
chad added a comment to T9897: Unbeta Feedback on Phame.

For Home I expect 90%-98% of people to not be blog post authors, so visiting /phame/ would be best served getting content to them from whatever Blogs they want to follow. I am partial to providing to quicker access to posting new posts though, so I want to think about that some more (and EditEngine might be the actual answer).

Dec 3 2015, 9:56 PM · Phame
chad added a revision to T9897: Unbeta Feedback on Phame: Unknown Object (Differential Revision).
Dec 3 2015, 9:55 PM · Phame
chad updated the task description for T9897: Unbeta Feedback on Phame.
Dec 3 2015, 9:46 PM · Phame
chad updated the task description for T9897: Unbeta Feedback on Phame.
Dec 3 2015, 9:45 PM · Phame
chad added a revision to T9897: Unbeta Feedback on Phame: Unknown Object (Differential Revision).
Dec 3 2015, 9:44 PM · Phame
chad added a revision to T9360: Unbeta Phame: Unknown Object (Differential Revision).
Dec 3 2015, 9:42 PM · Phame
chad added a comment to T9360: Unbeta Phame.

DocumentPro is way better than Oblivious

Dec 3 2015, 9:41 PM · Phame
epriestley added a comment to T9360: Unbeta Phame.

Yeah, let me dig into that a bit and come up with some options. I have to go look at what the skin code is doing.

Dec 3 2015, 9:40 PM · Phame
chad created T9897: Unbeta Feedback on Phame.
Dec 3 2015, 9:38 PM · Phame
chad added a comment to T9360: Unbeta Phame.

Oblivious skin is terrible and we should just get rid of it. The internal skin is a million times better.

Dec 3 2015, 9:37 PM · Phame
epriestley added a comment to T9360: Unbeta Phame.

I don't think it costs us very much to keep it around, and it does make some stuff nicer/easier. For example, we'd have no way to link to the live blog or live post if we don't know what domain it's on, and I like checking the live post after publishing something.

Dec 3 2015, 9:36 PM · Phame
chad added a comment to T9360: Unbeta Phame.

Do you see any point to doing "Custom Domain" stuff? That is, with EditEngine and Conduit, should that use case just be on the end user?

Dec 3 2015, 9:26 PM · Phame
avivey created T9896: make images from comments visible in email.
Dec 3 2015, 9:18 PM · Restricted Project, Remarkup, Mail
epriestley added a comment to T9360: Unbeta Phame.

Some thoughts from banging on this, not sure how much you want to deal with:

Dec 3 2015, 9:09 PM · Phame
jb55 edited the content of Organizations Using Phabricator.
Dec 3 2015, 9:00 PM
chad added a revision to T9895: Update Phame Documentation: Unknown Object (Differential Revision).
Dec 3 2015, 8:36 PM · Phame
chad added a revision to T9360: Unbeta Phame: Unknown Object (Differential Revision).
Dec 3 2015, 8:36 PM · Phame
chad removed a subtask for T9360: Unbeta Phame: T9546: Phame "Oblivious" skin a few rough edges.
Dec 3 2015, 8:08 PM · Phame
chad removed a parent task for T9546: Phame "Oblivious" skin a few rough edges: T9360: Unbeta Phame.
Dec 3 2015, 8:08 PM · Phame
chad created T9895: Update Phame Documentation.
Dec 3 2015, 8:08 PM · Phame
chad moved T9546: Phame "Oblivious" skin a few rough edges from Unbeta (v1) to Backlog on the Phame board.
Dec 3 2015, 8:07 PM · Phame
avivey updated subscribers of T9892: I want to be sent email when a build fails for any commit in a repository.
Dec 3 2015, 7:56 PM · Restricted Project, Harbormaster
avivey added a comment to T5491: Harbormaster Build Notification Status.

Is this a generic "notify users about failed builds" ticket, or a request for "webhook about build status"?

Dec 3 2015, 7:52 PM · Restricted Project, Harbormaster
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Restricted Differential Revision.
Dec 3 2015, 7:38 PM · Restricted Project, ApplicationEditor, Transactions
joshuaspence added a comment to T9855: DifferentialChangesSinceLastUpdateField may fail policy checks and prevent mail from sending.

I'll see if I can come up with a reproduction case.

Dec 3 2015, 7:23 PM · Daemons, Differential
chad added a comment to T9894: Object selector dialog does not work in Elasticsearch 1.7.2.

Specifically, we need full steps to reproduce the issue. These need to be, from start to finish, full steps any engineer either one day or one year from now can follow and achieve the same error:
https://secure.phabricator.com/book/phabcontrib/article/bug_reports/#include-reproduction-ste

Dec 3 2015, 4:56 PM · Elasticsearch
chad updated subscribers of T9894: Object selector dialog does not work in Elasticsearch 1.7.2.
Dec 3 2015, 4:51 PM · Elasticsearch
chad removed a parent task for T9894: Object selector dialog does not work in Elasticsearch 1.7.2: T9889: Object selector dialog does not work in Elasticsearch 2.0.
Dec 3 2015, 4:50 PM · Elasticsearch
chad removed a subtask for T9889: Object selector dialog does not work in Elasticsearch 2.0: T9894: Object selector dialog does not work in Elasticsearch 1.7.2.
Dec 3 2015, 4:50 PM · Elasticsearch
chad added a comment to T9894: Object selector dialog does not work in Elasticsearch 1.7.2.

This ticket doesn't provide steps to reproduce the issue. Is Contributing Bug Reports unclear on this matter? Can we provide better documentation somehow?

Dec 3 2015, 4:46 PM · Elasticsearch
• Basheer created T9894: Object selector dialog does not work in Elasticsearch 1.7.2.
Dec 3 2015, 4:39 PM · Elasticsearch
chad added a comment to T9889: Object selector dialog does not work in Elasticsearch 2.0.

Thanks for the reply. I have downgraded Elasticsearch to 1.7.2 still it not working. Now it shows as "Loading..." rather than getting "No Data".

Dec 3 2015, 4:26 PM · Elasticsearch
• Basheer added a comment to T9889: Object selector dialog does not work in Elasticsearch 2.0.

Thanks for the reply. I have downgraded Elasticsearch to 1.7.2 still it not working. Now it shows as "Loading..." rather than getting "No Data".

Dec 3 2015, 4:24 PM · Elasticsearch
epriestley reopened T9893: Support ElasticSearch 2.0 - 5.1 as "Open".
Dec 3 2015, 3:53 PM · Elasticsearch, Search
epriestley reopened T9890: Version and lock search index rebuilds to reduce the cost of runaway writes as "Open".
Dec 3 2015, 3:53 PM · Search
epriestley reopened T9891: Verify WMF use cases are accommodated after Herald Outbound Rules resolves as "Open".
Dec 3 2015, 3:53 PM · Mail, Differential
• nwaf1990 merged task T9890: Version and lock search index rebuilds to reduce the cost of runaway writes into T9892: I want to be sent email when a build fails for any commit in a repository.
Dec 3 2015, 3:50 PM · Search
• nwaf1990 merged task T9891: Verify WMF use cases are accommodated after Herald Outbound Rules resolves into T9892: I want to be sent email when a build fails for any commit in a repository.
Dec 3 2015, 3:50 PM · Mail, Differential
• nwaf1990 updated subscribers of T9892: I want to be sent email when a build fails for any commit in a repository.
Dec 3 2015, 3:50 PM · Restricted Project, Harbormaster
• nwaf1990 merged task T9893: Support ElasticSearch 2.0 - 5.1 into T9892: I want to be sent email when a build fails for any commit in a repository.
Dec 3 2015, 3:50 PM · Elasticsearch, Search
epriestley closed T5031: Draft Comment Persists After Submission as Resolved by committing Restricted Diffusion Commit.
Dec 3 2015, 3:07 PM · Restricted Project, Support Impact, Mobile
epriestley closed T5031: Draft Comment Persists After Submission, a subtask of T5811: Phriction does not correctly save and restore document drafts of in-progress edits, as Resolved.
Dec 3 2015, 3:07 PM · Phriction
epriestley closed T5031: Draft Comment Persists After Submission, a subtask of T7794: Differential revision list "draft notification" bubble should ignore deleted drafts, as Resolved.
Dec 3 2015, 3:07 PM · Differential, Audit
epriestley added a comment to T9855: DifferentialChangesSinceLastUpdateField may fail policy checks and prevent mail from sending.

It would be helpful to understand how to reproduce this. Specifically, I think what's happening is something like this:

Dec 3 2015, 2:54 PM · Daemons, Differential
epriestley renamed T9855: DifferentialChangesSinceLastUpdateField may fail policy checks and prevent mail from sending from Perpetually failing daemon task to DifferentialChangesSinceLastUpdateField may fail policy checks and prevent mail from sending.
Dec 3 2015, 2:50 PM · Daemons, Differential
epriestley closed T9867: Articulate meaningful corporate values as Wontfix.

I'm just going to close this, I can dig it up later if I want to reference it.

Dec 3 2015, 2:48 PM · Phacility
epriestley added a subtask for T9640: Make Phabricator compatible with PHP7: T9888: Provide guidance in the documentation about PHP7.
Dec 3 2015, 2:47 PM · Prioritized, Restricted Project, Infrastructure
epriestley added a parent task for T9888: Provide guidance in the documentation about PHP7: T9640: Make Phabricator compatible with PHP7.
Dec 3 2015, 2:47 PM · Documentation
epriestley triaged T9889: Object selector dialog does not work in Elasticsearch 2.0 as Low priority.
Dec 3 2015, 2:47 PM · Elasticsearch
epriestley added a parent task for T5791: Write Herald rules for outbound mail: T9891: Verify WMF use cases are accommodated after Herald Outbound Rules resolves.
Dec 3 2015, 2:46 PM · Restricted Project, Restricted Project, FreeBSD, Mail
epriestley added a subtask for T9891: Verify WMF use cases are accommodated after Herald Outbound Rules resolves: T5791: Write Herald rules for outbound mail.
Dec 3 2015, 2:46 PM · Mail, Differential
epriestley renamed T9891: Verify WMF use cases are accommodated after Herald Outbound Rules resolves from Differential notification emails lack headers for repository and state change to Verify WMF use cases are accommodated after Herald Outbound Rules resolves.
Dec 3 2015, 2:46 PM · Mail, Differential
epriestley added a comment to T9891: Verify WMF use cases are accommodated after Herald Outbound Rules resolves.

This is basically all reasonable but entangled with the giant mess in T5791 and T9161.

Dec 3 2015, 2:46 PM · Mail, Differential
epriestley added a project to T9893: Support ElasticSearch 2.0 - 5.1: Elasticsearch.
Dec 3 2015, 2:21 PM · Elasticsearch, Search
epriestley renamed T9889: Object selector dialog does not work in Elasticsearch 2.0 from Phabricator search is not working perfectly after upgrading search features to elasticsearch to Object selector dialog does not work in Elasticsearch 2.0.
Dec 3 2015, 2:21 PM · Elasticsearch
epriestley added a comment to T9893: Support ElasticSearch 2.0 - 5.1.

Broadly, to set expectations, this is a very low priority for the upstream and neither of us really have any familiarity with Elasticsearch, so I don't expect to move this forward for a long time.

Dec 3 2015, 2:21 PM · Elasticsearch, Search
epriestley added a comment to T9889: Object selector dialog does not work in Elasticsearch 2.0.

We don't currently support ElasticSearch 2.0. I'm collecting issues we've seen with it in T9893.

Dec 3 2015, 2:17 PM · Elasticsearch
epriestley updated the task description for T5282: Provide documentation on setting up ElasticSearch.
Dec 3 2015, 2:16 PM · Elasticsearch, Documentation
epriestley added a comment to T9893: Support ElasticSearch 2.0 - 5.1.

As an alternative, I'd like to consider dropping upstream support for ElasticSearch entirely. We originally implemented it because Facebook wanted it and the project was more willing to implement and maintain things. However:

Dec 3 2015, 2:16 PM · Elasticsearch, Search
epriestley added a comment to T9670: Conflicting field mappings for phabricator index when upgrading to Elasticsearch 2.0.

@ru31337, that issue isn't related to this one and isn't "wontfix". Please see Contributing Bug Reports for instructions on how to report bugs. Choosing an existing similar task, changing it to "wontfix" and dumping your issue into it won't get it fixed.

Dec 3 2015, 2:09 PM · Elasticsearch
epriestley added a parent task for T9670: Conflicting field mappings for phabricator index when upgrading to Elasticsearch 2.0: T9893: Support ElasticSearch 2.0 - 5.1.
Dec 3 2015, 2:08 PM · Elasticsearch
epriestley added a subtask for T9893: Support ElasticSearch 2.0 - 5.1: T9670: Conflicting field mappings for phabricator index when upgrading to Elasticsearch 2.0.
Dec 3 2015, 2:08 PM · Elasticsearch, Search
epriestley added a parent task for T9779: ./bin/search init error with elasticsearch 2.0: T9893: Support ElasticSearch 2.0 - 5.1.
Dec 3 2015, 2:08 PM · Elasticsearch
epriestley added subtasks for T9893: Support ElasticSearch 2.0 - 5.1: T9889: Object selector dialog does not work in Elasticsearch 2.0, T9779: ./bin/search init error with elasticsearch 2.0.
Dec 3 2015, 2:08 PM · Elasticsearch, Search
epriestley added a parent task for T9889: Object selector dialog does not work in Elasticsearch 2.0: T9893: Support ElasticSearch 2.0 - 5.1.
Dec 3 2015, 2:08 PM · Elasticsearch
epriestley created T9893: Support ElasticSearch 2.0 - 5.1.
Dec 3 2015, 2:07 PM · Elasticsearch, Search
hach-que created T9892: I want to be sent email when a build fails for any commit in a repository.
Dec 3 2015, 2:05 PM · Restricted Project, Harbormaster
epriestley claimed T9873: arc alias outputs a confusing message when adding a shell command alias.
Dec 3 2015, 2:04 PM · Arcanist
epriestley added a revision to T9873: arc alias outputs a confusing message when adding a shell command alias: Unknown Object (Differential Revision).
Dec 3 2015, 2:04 PM · Arcanist
epriestley closed T9876: Arcanist filename linter's regex should be configurable as Wontfix.

I don't think telling users that their filenames must match a complicated regexp and expecting them to figure it out is a reasonable behavior for a linter to have. I think I'm fairly comfortable with regular expressions and not confident I could figure out what the message meant quickly, and I know at least some engineers just don't have regexp literacy as part of their toolset.

Dec 3 2015, 1:42 PM · Lint, Arcanist
epriestley renamed T9887: Builds do not recover properly if a build step has an invalid build plan (e.g., a removed class) from When a build encounters an "Unexpected Error", the buildable remains in a "Building" state to Builds do not recover properly if a build step has an invalid build plan (e.g., a removed class).
Dec 3 2015, 1:15 PM · Restricted Project, Harbormaster
epriestley updated the task description for T9890: Version and lock search index rebuilds to reduce the cost of runaway writes.
Dec 3 2015, 1:11 PM · Search
epriestley added a comment to T9890: Version and lock search index rebuilds to reduce the cost of runaway writes.

I suppose the "version number" I propose is a little tricky, because it won't be incremented if a user edits a comment -- this does not apply a new transaction. We could use a <MAX(transactionID), MAX(commentID)> version instead to catch edits.

Dec 3 2015, 1:08 PM · Search
epriestley renamed T9890: Version and lock search index rebuilds to reduce the cost of runaway writes from Make parallel taskmaster daemons efficient by not letting them executing the same tasks to Version and lock search index rebuilds to reduce the cost of runaway writes.
Dec 3 2015, 1:07 PM · Search
epriestley added a comment to T9890: Version and lock search index rebuilds to reduce the cost of runaway writes.

Ah! That could definitely explain it.

Dec 3 2015, 1:06 PM · Search
koenkivits added a comment to T9890: Version and lock search index rebuilds to reduce the cost of runaway writes.

Hi, a co-worker of @vintrax here.
It seems this happened because I messed up. I wrote a bot that accidentally left hundreds of comments in a single task in the span of 20 minutes. The large amount of comments caused both the a lot of search index jobs to be slow (DELETEs/UPDATEs on a big MYSQL record) and big in amount (an index job per comment). To top it off these jobs couldn't be run in parallel efficiently because of search_documentfield table locks (because it's MyISAM). This caused the queue to still be clogged more than 24 hours after the 'bot mishap' happened, which is why I initially did not think this had caused the issues

Dec 3 2015, 12:02 PM · Search
tolbrino renamed T9797: Add unit testing support for Elixir from Add Elixir unit testing support to Add unit testing support for Elixir.
Dec 3 2015, 10:22 AM · Unit, Arcanist
tolbrino renamed T9796: Add linting support for Elixir from Add Elixir Linter to Add linting support for Elixir.
Dec 3 2015, 10:22 AM · Lint, Arcanist
tolbrino edited the content of Community Resources.
Dec 3 2015, 10:19 AM
hach-que abandoned D13421: Prevent rapid AWS calls being made due to SSH test returning quickly.
Dec 3 2015, 8:56 AM