Page MenuHomePhabricator
Feed All Stories

Dec 3 2015

hach-que abandoned D13639: Prevent 'Start or Wait for Build Plan' from running disabled build plans.

Presumably this will be addressed when upstream implements running or embedding build plans.

Dec 3 2015, 8:52 AM
hach-que abandoned D13685: Make sure failure to remove temporary files does not cause error exit codes.

We'll keep this patched locally while-ever we keep encountering the issue.

Dec 3 2015, 8:50 AM
hach-que abandoned D13525: [drydock/aws] Check that the instance started by a spot request is API consistent.
Dec 3 2015, 8:48 AM
hach-que abandoned D13522: [drydock/aws] Check for the presence of the storage path before finalizing allocation.
Dec 3 2015, 8:47 AM
hach-que abandoned D13508: [drydock/aws/working-copies-caching] Update AWS EC2 blueprint to support working copy caches.
Dec 3 2015, 8:46 AM
• VitaminCpp added a comment to T9724: "ssh-exec" sometimes hangs when git cloning larger repos .

The same here...

Dec 3 2015, 8:25 AM · Git
chad claimed T9622: Allow Phriction pages to have Project tags.
Dec 3 2015, 5:27 AM · Projects, Phriction, Restricted Project
chad claimed T7638: Archiving wiki pages in Phriction.
Dec 3 2015, 5:27 AM · Phriction
webframp added a comment to T9657: Upgrading: arc land flow has been rewritten in git.

That's sensible to me. Was just an unexpected side effect of improving the arc land workflow for git and thought I'd mention it.

Dec 3 2015, 12:05 AM · Installing & Upgrading, Arcanist
epriestley added a comment to T6549: Backup codes for multi-factor authentication.

See also T9515 and T7639 for "choose some other users to trust, if you lose your phone they can vote to strip your MFA".

Dec 3 2015, 12:03 AM · Restricted Project, Auth

Dec 2 2015

epriestley added a comment to T9657: Upgrading: arc land flow has been rewritten in git.

This was an intentional change in response to requests by other users in T4333 and elsewhere.

Dec 2 2015, 11:55 PM · Installing & Upgrading, Arcanist
chad added a revision to T9825: Remarkup is rendered literally in Diviner: Unknown Object (Differential Revision).
Dec 2 2015, 11:34 PM · Diviner
greggrossmeier awarded T6549: Backup codes for multi-factor authentication a Love token.
Dec 2 2015, 11:34 PM · Restricted Project, Auth
webframp added a comment to T9657: Upgrading: arc land flow has been rewritten in git.

On this issue, it would be great to tune the behavior regarding "Author date" vs "Commit date" for git. With our current CI tool, current build and previous build are determined in "Commit date" order not "Author Date', which can result in confusing links.

Dec 2 2015, 11:19 PM · Installing & Upgrading, Arcanist
greggrossmeier created T9891: Verify WMF use cases are accommodated after Herald Outbound Rules resolves.
Dec 2 2015, 11:16 PM · Mail, Differential
iangordon added a comment to T9876: Arcanist filename linter's regex should be configurable.

I wouldn't expect users to attach filetype specific filtering via the regex. The include portion of the linter config seems like a much better place to do such things.

Dec 2 2015, 11:06 PM · Lint, Arcanist
chad added a revision to T9825: Remarkup is rendered literally in Diviner: Unknown Object (Differential Revision).
Dec 2 2015, 10:30 PM · Diviner
joshuaspence added a comment to T9888: Provide guidance in the documentation about PHP7.

See also T9640 for tracking PHP7 compatibility.

Dec 2 2015, 9:56 PM · Documentation
chad added a revision to T9825: Remarkup is rendered literally in Diviner: Unknown Object (Differential Revision).
Dec 2 2015, 9:47 PM · Diviner
epriestley added a comment to T9825: Remarkup is rendered literally in Diviner.

There isn't really one, all the applications that do it right are doing comments, and you can't do the same thing they're doing very easily. Audit does something but it's a mess. It should really just get restructured, I think.

Dec 2 2015, 9:28 PM · Diviner
chad added a comment to T9825: Remarkup is rendered literally in Diviner.

So how do I fix this in Phame, Pholio, Ponder. I can't find a positive example.

Dec 2 2015, 9:18 PM · Diviner
vintrax added a comment to T9890: Version and lock search index rebuilds to reduce the cost of runaway writes.

Wauw, Evan, thank you so much for your debugging effort, for sharing your thoughts and your elaborate explanation. It's (seriously) highly appreciated!

Dec 2 2015, 9:14 PM · Search
jgelens added a comment to T9639: Unable to push to hosted Mercurial repository over SSH with new upstream bookmark position.
Dec 2 2015, 9:07 PM · Diffusion, Mercurial
hach-que added a comment to T9875: Build hosts run out of disk space because Drydock doesn't clean up working copies automatically.

So you have a machine full of unused working copies, and Drydock is failing every build instead of reusing them?

Dec 2 2015, 9:03 PM · Bug Report, Drydock
epriestley added a comment to T5031: Draft Comment Persists After Submission.

I've marked D14637 as fixing this.

Dec 2 2015, 8:59 PM · Restricted Project, Support Impact, Mobile
epriestley added a revision to T5031: Draft Comment Persists After Submission: Unknown Object (Differential Revision).
Dec 2 2015, 8:58 PM · Restricted Project, Support Impact, Mobile
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 2 2015, 8:58 PM · Restricted Project, ApplicationEditor, Transactions
epriestley moved T9887: Builds do not recover properly if a build step has an invalid build plan (e.g., a removed class) from Backlog to Far Future on the Harbormaster board.
Dec 2 2015, 8:54 PM · Restricted Project, Harbormaster
epriestley triaged T9887: Builds do not recover properly if a build step has an invalid build plan (e.g., a removed class) as Wishlist priority.
Dec 2 2015, 8:54 PM · Restricted Project, Harbormaster
hach-que reopened T9887: Builds do not recover properly if a build step has an invalid build plan (e.g., a removed class) as "Open".

This happens after upgrading Phabricator and having a build step implementation no longer exist; when the build plan runs you get an unexpected error. Getting the unexpected error isn't what's wrong - but that the buildable doesn't get marked as failed is incorrect.

Dec 2 2015, 8:52 PM · Restricted Project, Harbormaster
hach-que added a comment to T9875: Build hosts run out of disk space because Drydock doesn't clean up working copies automatically.

What happens if a new configuration / request comes in that doesn't match any of the available 16 working copies?

Dec 2 2015, 8:48 PM · Bug Report, Drydock
epriestley added a comment to T9875: Build hosts run out of disk space because Drydock doesn't clean up working copies automatically.

still won't get cleaned up and instead Drydock will just fail to allocate.

Dec 2 2015, 8:46 PM · Bug Report, Drydock
hach-que added a comment to T9875: Build hosts run out of disk space because Drydock doesn't clean up working copies automatically.

It's running out of disk space because Drydock isn't cleaning up the working copies and they're consuming all the disk space.

Dec 2 2015, 8:45 PM · Bug Report, Drydock
epriestley added a comment to T9875: Build hosts run out of disk space because Drydock doesn't clean up working copies automatically.

So you have a machine full of unused working copies, and Drydock is failing every build instead of reusing them?

Dec 2 2015, 8:45 PM · Bug Report, Drydock
hach-que added a comment to T9875: Build hosts run out of disk space because Drydock doesn't clean up working copies automatically.

Because if I don't clean it up, then every build from then on will fail until I fix it?

Dec 2 2015, 8:43 PM · Bug Report, Drydock
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 2 2015, 7:38 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 2 2015, 7:17 PM · Restricted Project, ApplicationEditor, Transactions
webframp edited P1900 Masterwork From Distant Lands.
Dec 2 2015, 6:59 PM
defuzz added a comment to T6777: Arcanist creates a branch when --nobranch is specified.

I forget the origins (it's been like a year), but Nick Zheng or a user at our company found this confusing.

Dec 2 2015, 6:58 PM · Arcanist
webframp edited P1898 Masterwork From Distant Lands.
Dec 2 2015, 6:44 PM
webframp edited P1898 Masterwork From Distant Lands.
Dec 2 2015, 6:42 PM
chad added a comment to T9884: Phabricator workboards should have scroll-locked column headers.

There are a couple concerns with this suggestion. Mostly, the core problem as described is "workboard has too many tasks". This is the problem we'd likely want to investigate and address.

Dec 2 2015, 5:36 PM
• pgiles added a comment to T5422: Does Phabricator integrate with JIRA?.

We're trying to integrate with JIRA 7.1. Is JIRA 7 or 7.1 supported?

Dec 2 2015, 5:35 PM · Guides, Doorkeeper
dstrine added a comment to T9884: Phabricator workboards should have scroll-locked column headers.

@chad I'm not very technical. Also I read a lot of your documentation. It clearly states that new requests should not start with specific solution, only use cases.

Dec 2 2015, 5:25 PM
dstrine updated subscribers of T9882: Improve the ability to drag tasks between long, short and distant columns..

@chad T5240 seems to mix several solutions and a note about regressions. Also @epriestley noted several issues and options. I wanted to call this out as opposed to other parts of that conversation.

Dec 2 2015, 5:18 PM
epriestley closed T9874: Documentation references to "restart your webserver" do not explicitly tell you to restart both HTTP and PHP server processes as Resolved by committing Restricted Diffusion Commit.
Dec 2 2015, 5:16 PM · Setup, Documentation
dstrine closed T9883: @mentions in descriptions should auto-complete as Resolved.
Dec 2 2015, 5:13 PM
epriestley added a revision to T9874: Documentation references to "restart your webserver" do not explicitly tell you to restart both HTTP and PHP server processes: Unknown Object (Differential Revision).
Dec 2 2015, 5:13 PM · Setup, Documentation
dstrine added a comment to T9883: @mentions in descriptions should auto-complete.

@chad ok thanks. I will move to that task.

Dec 2 2015, 5:12 PM
epriestley renamed T9874: Documentation references to "restart your webserver" do not explicitly tell you to restart both HTTP and PHP server processes from Need better instructions to fix the issue related to post_max_size to Documentation references to "restart your webserver" do not explicitly tell you to restart both HTTP and PHP server processes.
Dec 2 2015, 5:11 PM · Setup, Documentation
chad added a comment to T9883: @mentions in descriptions should auto-complete.

It's the exact same task to us and there is no benefit from managing it in two places. Autocomplete for users in Remarkup, when built, will just work everywhere for free.

Dec 2 2015, 5:10 PM
dstrine updated subscribers of T9883: @mentions in descriptions should auto-complete.

@chad I acknowledge that this is partly discussed in T3725. However it is a long conversation with many options and ideas. I would like to promote this part of that conversation. Also I would like to discuss the option of paid prioritization.

Dec 2 2015, 5:07 PM
dstrine reopened T9883: @mentions in descriptions should auto-complete as "Open".
Dec 2 2015, 5:02 PM
• Basheer added a comment to T9889: Object selector dialog does not work in Elasticsearch 2.0.

I just upgraded Phabricator, now the version is,

Dec 2 2015, 4:47 PM · Elasticsearch
epriestley claimed T9874: Documentation references to "restart your webserver" do not explicitly tell you to restart both HTTP and PHP server processes.
Dec 2 2015, 4:33 PM · Setup, Documentation
epriestley added a comment to T9875: Build hosts run out of disk space because Drydock doesn't clean up working copies automatically.

When this happens, there'll be hundreds of builds all running at the same time, which can result in hundreds of working copies for the same repository.

Dec 2 2015, 4:31 PM · Bug Report, Drydock
epriestley added a comment to T9876: Arcanist filename linter's regex should be configurable.

I'm concerned that it's difficult to give users a descriptive error message if the pattern is an arbitrary regular expression. What does your patch do when a filename fails a custom regular expression? Specifically, how does it help the user fix their filename?

Dec 2 2015, 4:23 PM · Lint, Arcanist
chad added a comment to T9889: Object selector dialog does not work in Elasticsearch 2.0.

Your install is fairly out of date. See https://secure.phabricator.com/book/phabcontrib/article/bug_reports/#common-fixes

Dec 2 2015, 4:15 PM · Elasticsearch
• Basheer added a comment to T9889: Object selector dialog does not work in Elasticsearch 2.0.

Phabricator Version d878f215617bb5a97bd5ea4145566308cb68d7e3

Dec 2 2015, 4:00 PM · Elasticsearch
epriestley closed T9887: Builds do not recover properly if a build step has an invalid build plan (e.g., a removed class) as Invalid.

I don't know how to reproduce the behavior this report describes. See Contributing Bug Reports.

Dec 2 2015, 3:57 PM · Restricted Project, Harbormaster
epriestley changed the edit policy for T9889: Object selector dialog does not work in Elasticsearch 2.0.
Dec 2 2015, 3:53 PM · Elasticsearch
epriestley added a comment to T9890: Version and lock search index rebuilds to reduce the cost of runaway writes.

I can't reproduce this. Here's what I did:

Dec 2 2015, 3:42 PM · Search
chad added a comment to T9889: Object selector dialog does not work in Elasticsearch 2.0.

What version of Phabricator are you running.. See Contributing Bug Reports

Dec 2 2015, 3:26 PM · Elasticsearch
chad added a project to T9889: Object selector dialog does not work in Elasticsearch 2.0: Elasticsearch.
Dec 2 2015, 3:26 PM · Elasticsearch
vintrax created T9890: Version and lock search index rebuilds to reduce the cost of runaway writes.
Dec 2 2015, 3:08 PM · Search
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 2 2015, 2:18 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 2 2015, 2:06 PM · Restricted Project, ApplicationEditor, Transactions
• Basheer created T9889: Object selector dialog does not work in Elasticsearch 2.0.
Dec 2 2015, 1:08 PM · Elasticsearch
epriestley created T9888: Provide guidance in the documentation about PHP7.
Dec 2 2015, 12:27 PM · Documentation
hach-que created T9887: Builds do not recover properly if a build step has an invalid build plan (e.g., a removed class).
Dec 2 2015, 9:50 AM · Restricted Project, Harbormaster
hach-que added a comment to T9877: Unable to get back to the build plan view page from the build step view page on mobile.

Yes, it's the breadcrumbs.

Dec 2 2015, 7:45 AM · Harbormaster
eadler moved T9859: `arc diff` allows addition of empty directories in SVN but `arc patch` creates files from Backlog to Important on the FreeBSD board.
Dec 2 2015, 7:41 AM · FreeBSD, Arcanist, Subversion
eadler added a project to T9859: `arc diff` allows addition of empty directories in SVN but `arc patch` creates files: FreeBSD.
Dec 2 2015, 7:41 AM · FreeBSD, Arcanist, Subversion
cspeckmim added a revision to T9886: Add Java linters, checkstyle and PMD: Unknown Object (Differential Revision).
Dec 2 2015, 5:53 AM · Restricted Project, Arcanist, Lint
cspeckmim created T9886: Add Java linters, checkstyle and PMD.
Dec 2 2015, 5:36 AM · Restricted Project, Arcanist, Lint
talshiri added a comment to T9845: Straighten out addTextSection() / addRemarkupSection() in mail body construction.

This one is totally my bad.
My intention was to make it less spooky to migrate individual pieces to the section construct (since the API remained largely the same), but the API weirdness was not worth it, and didn't even achieve that goal

Dec 2 2015, 4:44 AM · Differential
chad added a revision to T8628: Modernize AphrontControllers to implement handleRequest: Unknown Object (Differential Revision).
Dec 2 2015, 4:09 AM · Contributor Onboarding, Modernization, Badge Awarded, Aphront
hach-que added a comment to T9875: Build hosts run out of disk space because Drydock doesn't clean up working copies automatically.

fyi my Phabricator instance currently has 80 working copy resources open

Dec 2 2015, 3:55 AM · Bug Report, Drydock
chad added a revision to T8628: Modernize AphrontControllers to implement handleRequest: Unknown Object (Differential Revision).
Dec 2 2015, 3:50 AM · Contributor Onboarding, Modernization, Badge Awarded, Aphront
epriestley added a comment to T5096: Create a phabricator authentication provider that uses mediawiki oauth.

Aaah! That makes sense.

Dec 2 2015, 3:18 AM · Auth, Wikimedia
20after4 updated the task description for T5096: Create a phabricator authentication provider that uses mediawiki oauth.
Dec 2 2015, 3:13 AM · Auth, Wikimedia
20after4 added a comment to T5096: Create a phabricator authentication provider that uses mediawiki oauth.

@epriestley: The main motivation was that we had been maintaining these as cherry-picked patches on top of phabricator core, which required constant rebasing. It was ridiculous and not even necessary. Eventually I figured out that phabricator doesn't care if the auth providers live in an external library. I sure wish I'd figured that out in the beginning, it would have made things a lot easier ;)

Dec 2 2015, 3:09 AM · Auth, Wikimedia
20after4 added a comment to T9860: Upgrading: TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK are deprecated and will be removed.

@epriestley: FWIW I don't mind doing the work, and I would love to throw away all the hacky stuff we have right now.

Dec 2 2015, 2:47 AM · Maniphest, Installing & Upgrading
epriestley updated subscribers of T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.
Dec 2 2015, 1:21 AM · Restricted Project, FreeBSD, Arcanist
epriestley merged task T9885: Support custom task status values in Conduit query method into T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.
Dec 2 2015, 1:21 AM · Conduit, Maniphest
puls created T9885: Support custom task status values in Conduit query method.
Dec 2 2015, 1:09 AM · Conduit, Maniphest
epriestley added a comment to T9860: Upgrading: TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK are deprecated and will be removed.

I'm not 100% sure it actually works, but you'd just do this:

Dec 2 2015, 12:55 AM · Maniphest, Installing & Upgrading
20after4 added a comment to T9860: Upgrading: TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK are deprecated and will be removed.

I believe if you include a transaction which sets the CCs to the current CCs, it is guaranteed to run after any personal rules and will entirely undo the effects of any sneaky rules anyone might write.

Dec 2 2015, 12:45 AM · Maniphest, Installing & Upgrading
20after4 added a comment to T9860: Upgrading: TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK are deprecated and will be removed.

The problem is, we add a rule that includes "subscribers can view" to the policy - so even if it prevents mail from being sent, by the end of the herald processing, the user has gained 'can view' on the private task (by way of being CC'd) even though they should have never been able to CC themself in the first place.

Dec 2 2015, 12:44 AM · Maniphest, Installing & Upgrading
epriestley added a comment to T9860: Upgrading: TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK are deprecated and will be removed.

I believe if you include a transaction which sets the CCs to the current CCs, it is guaranteed to run after any personal rules and will entirely undo the effects of any sneaky rules anyone might write.

Dec 2 2015, 12:43 AM · Maniphest, Installing & Upgrading
20after4 added a comment to T9860: Upgrading: TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK are deprecated and will be removed.

What are you doing which can't be covered by Herald?

Dec 2 2015, 12:41 AM · Maniphest, Installing & Upgrading
dereckson added a comment to T9876: Arcanist filename linter's regex should be configurable.

To configure the regexp in an .arclint option for the linter seems valuable, with a clear use case.

Dec 2 2015, 12:15 AM · Lint, Arcanist

Dec 1 2015

chad renamed T3725: Using keyword @ to address users does not autocomplete names from Using keyword @ in comments to address users does not autocomplete names to Using keyword @ to address users does not autocomplete names.
Dec 1 2015, 11:44 PM · FreeBSD, User Delight, Remarkup
epriestley added a comment to P1897 find-unaccepted-revisions.php.

We also probably need to implement Phabricator Credits before we can add ᵐᶦᶜʳᵒᵖᵃʸᵐᵉᶰᵗˢ because otherwise we'll just be paying Stripe for the privilege of having ᵐᶦᶜʳᵒᵖᵃʸᵐᵉᶰᵗˢ.

Dec 1 2015, 11:28 PM
chad added a comment to P1897 find-unaccepted-revisions.php.

(i don't want to charge users for stuff, I just wanted to say ᵐᶦᶜʳᵒᵖᵃʸᵐᵉᶰᵗˢ)

Dec 1 2015, 11:26 PM
chad added a comment to P1897 find-unaccepted-revisions.php.

what about a jimmy wales banner ad?

Dec 1 2015, 11:24 PM
epriestley added a comment to P1897 find-unaccepted-revisions.php.

My major concern with pursuing that (or, say, "$1 to file a task") is that user expectations will be like billion times higher if something costs $0.25 than if it's free.

Dec 1 2015, 11:22 PM
chad added a comment to P1897 find-unaccepted-revisions.php.

ᵐᶦᶜʳᵒᵖᵃʸᵐᵉᶰᵗˢ﹗

Dec 1 2015, 11:19 PM
chad added a comment to P1897 find-unaccepted-revisions.php.

We need a Pay $5 to see this extension button.

Dec 1 2015, 11:19 PM
epriestley updated the title for P1897 find-unaccepted-revisions.php from untitled to find-unaccepted-revisions.php.
Dec 1 2015, 10:54 PM