Page MenuHomePhabricator
Feed All Stories

Nov 12 2015

eadler added a comment to T9766: Expose conduit API to activate/disable Herald rules.

A somewhat generic way to do this is to create the notion of a variable such as is_in_deployment and allow Herald rules to check to see if this is set/true/a specific value. If the API to expose the variable is exposed to conduit then also allows for far more interesting workflows (especially when combined with relying on other Herald rules).

Nov 12 2015, 5:50 AM · Restricted Project, Restricted Project, Conduit, Herald
chad added a comment to T9769: Test.

nyancat

Nov 12 2015, 1:25 AM · Search
joshuaspence closed T9769: Test as Spite.
Nov 12 2015, 1:15 AM · Search
joshuaspence created T9769: Test.
Nov 12 2015, 12:57 AM · Search
chad added a revision to T9756: Allow Blogs and Posts to be archived: Unknown Object (Differential Revision).
Nov 12 2015, 12:43 AM · Phame

Nov 11 2015

chad placed T9767: Add View Options to Diffusion File Viewer up for grabs.
Nov 11 2015, 10:38 PM · Diffusion
chad added a project to T9768: `arc diff` blows up if providing bad JIRA ticket name: Arcanist.
Nov 11 2015, 10:37 PM · Restricted Project, Arcanist
chad closed Q217: Differential: Closed by commit as resolved.
Nov 11 2015, 10:37 PM · Differential
chad added Q217: Differential: Closed by commit (Answer 249).
Nov 11 2015, 10:36 PM
avivey renamed T9768: `arc diff` blows up if providing bad JIRA ticket name from arc diffs blows up if providing bad JIRA ticket name' to arc diffs blows up if providing bad JIRA ticket name .
Nov 11 2015, 10:36 PM · Restricted Project, Arcanist
avivey claimed T9768: `arc diff` blows up if providing bad JIRA ticket name.
Nov 11 2015, 10:35 PM · Restricted Project, Arcanist
chad closed Q214: Folder structure after setting up file storage. as resolved.
Nov 11 2015, 10:34 PM · Files
chad added Q214: Folder structure after setting up file storage. (Answer 248).
Nov 11 2015, 10:34 PM
mikn updated the title for P1888 Feed publisher, diffs not existing from untitled to Feed publisher, diffs not existing.
Nov 11 2015, 10:22 PM
Luke081515.2 updated Q217: Differential: Closed by commit from to Differential: Closed by commit.
Nov 11 2015, 9:27 PM · Differential
DheerendraRathor closed Q216: Uploading large file in Files as resolved.
Nov 11 2015, 9:12 PM · Files
avivey renamed T5698: Github-style Remarkup previews on a checked-in resource from Github-style Markdown / Remarkup previews on a checked-in resource to Github-style Remarkup previews on a checked-in resource.
Nov 11 2015, 9:08 PM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup
avivey added a project to T5698: Github-style Remarkup previews on a checked-in resource: Diffusion.
Nov 11 2015, 9:07 PM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup
avivey added a comment to T9767: Add View Options to Diffusion File Viewer.

T8407?

Nov 11 2015, 9:06 PM · Diffusion
chad renamed T9767: Add View Options to Diffusion File Viewer from "Disable Highlighting" makes content editable to Add View Options to Diffusion File Viewer.
Nov 11 2015, 8:53 PM · Diffusion
joshuaspence added a comment to T9767: Add View Options to Diffusion File Viewer.
In T9767#144214, @chad wrote:

Maybe add a "View Options" button to "File Contents" in Diffusion? That seems most consistent.

Nov 11 2015, 8:10 PM · Diffusion
joshuaspence added a comment to T9767: Add View Options to Diffusion File Viewer.

Oh, right... it's not explicit in Differential. But rather when the file is too large for syntax highlighting.

Nov 11 2015, 8:08 PM · Diffusion
chad added a comment to T9767: Add View Options to Diffusion File Viewer.

Maybe add a "View Options" button to "File Contents" in Diffusion? That seems most consistent.

Nov 11 2015, 7:59 PM · Diffusion
ramesh_dharan added a comment to T9766: Expose conduit API to activate/disable Herald rules.

@epriestley correct.. basically we have an external system (a Jenkins-like CI tool) that we're effectively using as a workflow engine. The timing isn't strictly defined, it's basically "when the user presses the button, do all these things".

Nov 11 2015, 7:50 PM · Restricted Project, Restricted Project, Conduit, Herald
chad added a comment to T9767: Add View Options to Diffusion File Viewer.

Hmm, why not?

Nov 11 2015, 7:49 PM · Diffusion
joshuaspence added a comment to T9767: Add View Options to Diffusion File Viewer.

Hmm, why not? I'd prefer it (and it would be more consistent) if it wasn't editable, as in Differential.

Nov 11 2015, 7:39 PM · Diffusion
chad closed T9767: Add View Options to Diffusion File Viewer as Wontfix.

(I don't see a reason to remove this feature, specifically)

Nov 11 2015, 7:38 PM · Diffusion
chad added a comment to T9767: Add View Options to Diffusion File Viewer.

From the code, Diffusion has always rendered non-highlighted code in a textarea.

Nov 11 2015, 7:34 PM · Diffusion
joshuaspence created T9767: Add View Options to Diffusion File Viewer.
Nov 11 2015, 7:13 PM · Diffusion
epriestley added a comment to T9766: Expose conduit API to activate/disable Herald rules.

Just to clarify, you would rather rely on an external script to activate and deactivate this rule every day instead of having a Herald condition like "Current time is between 5PM and 9AM"?

Nov 11 2015, 6:57 PM · Restricted Project, Restricted Project, Conduit, Herald
chad added a project to T9766: Expose conduit API to activate/disable Herald rules: Restricted Project.
Nov 11 2015, 6:31 PM · Restricted Project, Restricted Project, Conduit, Herald
avivey updated the task description for T8914: Refine libphutil/resources/ssl/README.
Nov 11 2015, 6:26 PM · Documentation, libphutil
ramesh_dharan created T9766: Expose conduit API to activate/disable Herald rules.
Nov 11 2015, 5:42 PM · Restricted Project, Restricted Project, Conduit, Herald
r0bbie awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Nov 11 2015, 4:40 PM · Workboards (v3), Restricted Project
• pboszi moved T8345: Add task tabs for "Mentions" and "Merged" from Backlog to Nice To Have on the FreeBSD board.
Nov 11 2015, 4:37 PM · Restricted Project, FreeBSD, Maniphest
• pboszi moved T8345: Add task tabs for "Mentions" and "Merged" from Nice To Have to Backlog on the FreeBSD board.
Nov 11 2015, 4:37 PM · Restricted Project, FreeBSD, Maniphest
chad changed the visibility for T1931: Add keyboard shortcuts for Maniphest.
Nov 11 2015, 4:29 PM · Maniphest
epriestley closed T9765: Add support to Remarkup for "custom local links" eg. within same domain but not handled by phabricator as Wontfix.

I don't plan to support this in the upstream. This configuration is inherently dangerous because the custom application has access to Phabricator's cookies, and not one we recommend.

Nov 11 2015, 4:09 PM · Remarkup
• spencer1 added a comment to T1931: Add keyboard shortcuts for Maniphest.

Would love love love to see shortcuts, even just the ability to close a task and return to the previous board would be huge...

Nov 11 2015, 3:54 PM · Maniphest
etosan created T9765: Add support to Remarkup for "custom local links" eg. within same domain but not handled by phabricator.
Nov 11 2015, 3:47 PM · Remarkup
• guayosr added a comment to T1931: Add keyboard shortcuts for Maniphest.

Dropping in here to +1 keyboard shortcutrs on on Maniphest. Would be of huge help to us.

Nov 11 2015, 3:47 PM · Maniphest
ivo created T9764: Lint star colors have different meaning for revisions and diffs.
Nov 11 2015, 3:36 PM · Restricted Project, Differential
chad added Q216: Uploading large file in Files (Answer 247).
Nov 11 2015, 3:33 PM
halojedi20 updated the task description for T9456: Evaluate upstream support for third-party build systems.
Nov 11 2015, 3:16 PM · Restricted Project, Harbormaster
DheerendraRathor added a comment to Q182: Why git clone return 403 error when through http?.

Are you using VCS password for cloning?

Nov 11 2015, 3:01 PM · Diffusion, Git
joshuaspence added a revision to T9715: Prevent upgrade scripts from being run multiple times simultaneously: Unknown Object (Differential Revision).
Nov 11 2015, 12:17 PM · Database
joshuaspence added a comment to T3670: Add subprojects.

Ah OK, good to know.

Nov 11 2015, 11:18 AM · KDE, Projects (v3), Restricted Project, FreeBSD, Wikimedia
epriestley added a comment to T3670: Add subprojects.

You should be able to batch edit infinite tasks.

Nov 11 2015, 11:16 AM · KDE, Projects (v3), Restricted Project, FreeBSD, Wikimedia
DheerendraRathor added a comment to Q203: How do I embed YouTube videos?.

Sorry, I got it. I have to leave an empty line between youtube url and text.
Thanks.

Nov 11 2015, 10:55 AM · Remarkup
joshuaspence added a comment to Q203: How do I embed YouTube videos?.

How exactly are you embedding it?

Nov 11 2015, 10:12 AM · Remarkup
DheerendraRathor added a comment to Q203: How do I embed YouTube videos?.

Hi @joshuaspence I'm unable to embed youtube video in wikis. I've enabled remarkup.enable-embedded-youtube. But adding youtube link in wiki or adding youtube embedding html in wiki is not helping!

Nov 11 2015, 10:02 AM · Remarkup
DheerendraRathor updated Q216: Uploading large file in Files from to Uploading large file in Files.
Nov 11 2015, 9:46 AM · Files
revi created T9763: "Merged to" does not handle plural correctly.
Nov 11 2015, 9:46 AM · Maniphest, Localization
DheerendraRathor edited the content of Community Resources.
Nov 11 2015, 9:23 AM
DheerendraRathor updated the title for P1887 Arcanist Installation Shell Script for Linux from untitled to Arcanist Installation Shell Script for Linux.
Nov 11 2015, 9:20 AM · libphutil, Arcanist
joshuaspence added a comment to T7053: Restart daemons automagically.
  • When editing the small amount of config which can't auto-restart (phd.user, phd.start-taskmasters). I think phd.user already has an existing warning anyway.

Yeah, I would like to handle this properly but I'm not sure if it is worthwhile doing so?

Nov 11 2015, 8:21 AM · Daemons
joshuaspence added a comment to T3670: Add subprojects.

This is currently difficult to do because it involves bulk editing our entire workboard

What's difficult about this? Can't you just use the bulk editor to "Remove project X" and "Add project Y"?

Nov 11 2015, 8:14 AM · KDE, Projects (v3), Restricted Project, FreeBSD, Wikimedia
qinchao added a comment to T9252: Unprototype Drydock (v1).

likefromwall.jpeg (346×347 px, 29 KB)

Nov 11 2015, 8:03 AM · Prioritized, Drydock
angie updated subscribers of T6226: Conduit-created task always results in [Reopened] tag in the email subject.
Nov 11 2015, 7:45 AM · Restricted Project, Maniphest, Conduit
cspeckmim edited the content of Community Resources.
Nov 11 2015, 7:44 AM
chad added a comment to Blog Post: Development Notes (2015 Week 41).

Thanks for putting this together, it was very insightful.

Nov 11 2015, 5:16 AM
chad closed T9733: Add "Search First" to Feature Request documentation, maybe? as Wontfix.
Nov 11 2015, 3:35 AM · Documentation
avivey closed T9521: Programmatically Import Repositories as Resolved.
Nov 11 2015, 3:30 AM · Diffusion
• austinstoker added a comment to T182: Commit into repository directly from differential.

@epriestley I'll keep an eye on blueprints and the merge configurability. Thank you. Phabricator is awesome/and getting awesomer.

Nov 11 2015, 1:49 AM · Haskell.org, Restricted Project, Differential
joshuaspence added a comment to T9759: Show more history.

We don't show a specific amount of history: we show all activity since your last activity.

Nov 11 2015, 1:34 AM · Transactions
joshuaspence renamed T9760: Autoscaling for Almanac devices from Easier creation of Almanac devices to Autoscaling for Almanac devices.
Nov 11 2015, 1:33 AM · Drydock, Almanac
joshuaspence created T9762: Removing devices from Almanac services.
Nov 11 2015, 1:31 AM · Almanac (v2)
avivey updated the task description for T9761: tokenizer search button ignores limit.
Nov 11 2015, 1:24 AM · Javelin
avivey created T9761: tokenizer search button ignores limit.
Nov 11 2015, 1:23 AM · Javelin
joshuaspence updated Q175: Should I Reuse Device Keys? from Should I Reuse Device Keys to Should I Reuse Device Keys?.
Nov 11 2015, 12:04 AM · Drydock, Almanac
joshuaspence updated Q179: How do you configure an Almanac based Drydock resource from How do you configure an Almanac based Drydock ressource to How do you configure an Almanac based Drydock resource.
Nov 11 2015, 12:04 AM · Drydock

Nov 10 2015

joshuaspence added a comment to T9760: Autoscaling for Almanac devices.

Right, Almanac does not support autoscaling.

Nov 10 2015, 11:59 PM · Drydock, Almanac
chad closed Q215: UIExamples - purpose & use? as resolved.
Nov 10 2015, 11:58 PM
chad added Q215: UIExamples - purpose & use? (Answer 246).
Nov 10 2015, 11:58 PM
epriestley added a comment to T9760: Autoscaling for Almanac devices.

Right, Almanac does not support autoscaling. We'll have an EC2 blueprint (and similar) in the future which can manage autoscaling more simply. Almanac is the ground level "I have a list of IPs" version of things.

Nov 10 2015, 11:58 PM · Drydock, Almanac
epriestley added a comment to T9760: Autoscaling for Almanac devices.

bin/almanac register is just a shortcut for "put the private half of a key in the right place on disk, and the public half on the specified Almanac device". Maybe a clearer name would be bin/almanac install-keys.

Nov 10 2015, 11:57 PM · Drydock, Almanac
joshuaspence added a comment to T9760: Autoscaling for Almanac devices.

Right okay, but I can't autoscale the Drydock Pool right? Because I need to manually create new devices through the UI.

Nov 10 2015, 11:57 PM · Drydock, Almanac
epriestley added a comment to T9760: Autoscaling for Almanac devices.

This just means adding a device interface?

Nov 10 2015, 11:54 PM · Drydock, Almanac
joshuaspence added a comment to T9760: Autoscaling for Almanac devices.
  • Bind it to your pool to actually put it in service.
Nov 10 2015, 11:52 PM · Drydock, Almanac
joshuaspence added a comment to T9760: Autoscaling for Almanac devices.

So what does ./bin/almanac register actually do?

Nov 10 2015, 11:51 PM · Drydock, Almanac
epriestley added a comment to T9760: Autoscaling for Almanac devices.

Right. You just need to:

Nov 10 2015, 11:49 PM · Drydock, Almanac
joshuaspence added a comment to T9760: Autoscaling for Almanac devices.

Ok thanks. So I don't need to register my build agent with ./bin/almanac register?

Nov 10 2015, 11:49 PM · Drydock, Almanac
epriestley added a comment to T9760: Autoscaling for Almanac devices.

Don't do steps (3) or (4)! Those are useless at best, and dangerous at worst.

Nov 10 2015, 11:43 PM · Drydock, Almanac
• schmidna updated Q215: UIExamples - purpose & use? from to UIExamples - purpose & use?.
Nov 10 2015, 11:41 PM
joshuaspence created T9760: Autoscaling for Almanac devices.
Nov 10 2015, 11:39 PM · Drydock, Almanac
epriestley added a comment to T6049: Implement Phurl, a URL shortener/bookmarking application.
  • The view page doesn't actually show the short URL anywhere. You can copy it from "View URL", but I think this isn't totally obvious, and we probably have enough room to reasonably add it (e.g., "Short URL: ..." under "Original URL: ...").
  • If a link has an alias, "View URL" still links to the non-alias version (e.g. U6 links to /u/6, but a more-preferred link would be /u/bug).
  • The "Remarkup Reference" document (https://secure.phabricator.com/book/phabricator/article/remarkup/) should explain how to use ((6)) and ((bug)). It might be worthwhile to hint these on the U6 page itself, e.g. In Remarkup: ((bug)) in the properties? Not sure how useful/cluttered that would look.
  • Maybe show aliases on the list at /phurl/?
  • Maybe let users search for the link with a particular alias? If I know ((bug)), there's no way for me to actually find the URL object right now. Hovercards would be one fix but just going to Phurl and being able to search for "Alias: bug" is probably good too.
Nov 10 2015, 10:37 PM · Phurl
epriestley added a comment to T7053: Restart daemons automagically.

This also seems to work properly on this host, although I hit the "daemons are not running" setup warning once, presumably by racing their restart. If this is an issue we can tweak how that warning works, I think.

Nov 10 2015, 10:30 PM · Daemons
chad added a comment to T6049: Implement Phurl, a URL shortener/bookmarking application.

Also "Active" in the Object Header should just be the normal color, not green. Our design pattern is "normal" states are plainly colored and exceptional states are actively colored. (red, green, purple).

Nov 10 2015, 10:29 PM · Phurl
epriestley added a comment to T6049: Implement Phurl, a URL shortener/bookmarking application.

Oh, transaction publishing from Phurl also currently fails in the daemons:

Nov 10 2015, 10:25 PM · Phurl
epriestley added a comment to T7053: Restart daemons automagically.

One possible minor followup to maybe keep on the radar is showing some extra warnings in a few cases:

Nov 10 2015, 10:20 PM · Daemons
epriestley added a comment to T6049: Implement Phurl, a URL shortener/bookmarking application.

A couple of notes so far, after poking at this:

Nov 10 2015, 10:19 PM · Phurl
epriestley closed T9322: Avoid spawning setup errors when changing parameters in application "Config" as Resolved.
Nov 10 2015, 10:15 PM · Phacility Support, Phacility
epriestley added a comment to T9322: Avoid spawning setup errors when changing parameters in application "Config".

The resolution of T7053 should indirectly resolve this.

Nov 10 2015, 10:15 PM · Phacility Support, Phacility
epriestley awarded T7053: Restart daemons automagically a Mountain of Wealth token.
Nov 10 2015, 10:14 PM · Daemons
epriestley added a comment to T3670: Add subprojects.

This is currently difficult to do because it involves bulk editing our entire workboard

Nov 10 2015, 10:13 PM · KDE, Projects (v3), Restricted Project, FreeBSD, Wikimedia
joshuaspence added a comment to T3670: Add subprojects.

I have a use case which is maybe suited for subprojects, but I don't exactly know how you are planning on implementing this...

Nov 10 2015, 9:59 PM · KDE, Projects (v3), Restricted Project, FreeBSD, Wikimedia
epriestley added a comment to T9758: Diff context for Objective-C doesn't show method name if open brace is on newline.

We run this entire algorithm ourselves and it's pretty simple (basically just looks at indent levels, no language awareness). Should be pretty easy to have it peek at the previous line if it initially finds a line containing only "{" and see if that line is at the same indent level and otherwise suitable.

Nov 10 2015, 9:55 PM · Differential
joshuaspence closed T7053: Restart daemons automagically as Resolved by committing Restricted Diffusion Commit.
Nov 10 2015, 9:44 PM · Daemons
epriestley added a comment to T9759: Show more history.

(We could theoretically fiddle with this and include some time constraints and stuff but I suspect this rule is already the best rule we're really going to get, given how contentious/subjective the subject is and how little complaining we hear about it, relatively.)

Nov 10 2015, 9:43 PM · Transactions
chad added a comment to T9360: Unbeta Phame.

Phame should be "mostly reasonable" to test as an internal blog platform. There is more polish to come, but feel free to send feedback along here.

Nov 10 2015, 9:43 PM · Phame