Page MenuHomePhabricator

Add View Options to Diffusion File Viewer
Closed, DuplicatePublic

Description

View Options would be useful on File Contents view in Diffusion, it should include the same features (as applicable) as View Options in Differential (such as Highlight As...)

Event Timeline

joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added a project: Diffusion.
joshuaspence added a subscriber: joshuaspence.

From the code, Diffusion has always rendered non-highlighted code in a textarea.

chad claimed this task.

(I don't see a reason to remove this feature, specifically)

Hmm, why not? I'd prefer it (and it would be more consistent) if it wasn't editable, as in Differential.

Hmm, why not?

I think a better question is why? Specifically I presume since this feature exists, people use it as is.

it would be more consistent

There isn't a "disable highlighting" feature I'm aware of in Differential, nor a "highlight as" feature in Diffusion. So I'm not sure what you're advocating as consistent.

Maybe add a "View Options" button to "File Contents" in Diffusion? That seems most consistent.

Oh, right... it's not explicit in Differential. But rather when the file is too large for syntax highlighting.

In T9767#144214, @chad wrote:

Maybe add a "View Options" button to "File Contents" in Diffusion? That seems most consistent.

+1

chad renamed this task from "Disable Highlighting" makes content editable to Add View Options to Diffusion File Viewer.Nov 11 2015, 8:53 PM
chad reopened this task as Open.
chad removed chad as the assignee of this task.Nov 11 2015, 10:38 PM
chad updated the task description. (Show Details)