Page MenuHomePhabricator
Feed All Stories

Aug 16 2017

epriestley added a comment to T12838: Make sure "state" is in new Branch view.

Yes. In Mercurial, branch heads may be "Open" or "Closed".

Aug 16 2017, 9:14 PM · Design, Diffusion
chad closed T12837: Make it clear you're browsing the history of a tag, a subtask of T12824: Redesign Diffusion, as Resolved.
Aug 16 2017, 7:16 PM · Design, Diffusion
chad closed T12837: Make it clear you're browsing the history of a tag as Resolved by committing Restricted Diffusion Commit.
Aug 16 2017, 7:16 PM · Design, Diffusion
chad added a revision to T12837: Make it clear you're browsing the history of a tag: Unknown Object (Differential Revision).
Aug 16 2017, 7:16 PM · Design, Diffusion
chad added a comment to T12838: Make sure "state" is in new Branch view.

That the branch is closed?

Aug 16 2017, 7:15 PM · Design, Diffusion
chad added a comment to T12838: Make sure "state" is in new Branch view.

What is state here? I don't really remember what this was about, or if it's needed.

Aug 16 2017, 7:15 PM · Design, Diffusion
epriestley updated the task description for T12963: Aggregate similar stories in Feed, Notifications and Timelines.
Aug 16 2017, 7:01 PM · Transactions
epriestley merged T5891: Add button to notification panel to concatenate notifications on the same objects into T12963: Aggregate similar stories in Feed, Notifications and Timelines.
Aug 16 2017, 6:58 PM · Transactions
epriestley merged task T5891: Add button to notification panel to concatenate notifications on the same objects into T12963: Aggregate similar stories in Feed, Notifications and Timelines.
Aug 16 2017, 6:58 PM · Notifications
epriestley added a comment to T5891: Add button to notification panel to concatenate notifications on the same objects.

I'm going to merge this into T12963, which isn't exactly the same but overlaps this substantially. It's possible we'll pursue a more narrow "vacation review" mode eventually, but we'd want to finish T12963 first and make sure it didn't adequately address this problem on its own.

Aug 16 2017, 6:58 PM · Notifications
epriestley created T12963: Aggregate similar stories in Feed, Notifications and Timelines.
Aug 16 2017, 6:55 PM · Transactions
darkwing awarded T10363: Reorient Doorkeeper publishing around transactions instead of feed stories a Like token.
Aug 16 2017, 5:02 PM · Nuance, Restricted Project, Feed, Doorkeeper
MatanUbe awarded T10350: Scripts to migrate old "points" fields and move projects beneath other projects a Party Time token.
Aug 16 2017, 12:05 PM · Projects (v3)
DominicFrei added a comment to T7125: Provide tooling to for periodic reminders (like renewing domains and update SSL certificates).

@epriestley @jdiepenmaat If I may add ideas on that. I am using Things at the moment. There are only two reasons that hold me back to finally and completely switch to Phabricator:

  • recurring tasks
  • start dates for tasks

The latter is basically what your example is about, right? Because if I have just renewed the SSL certificate then a new task is created (due date being in one year), but it should not possible to start that right away, as it's not necessary. You would use a start date as well, wouldn't you?

Aug 16 2017, 11:32 AM · Calendar
DominicFrei awarded T7125: Provide tooling to for periodic reminders (like renewing domains and update SSL certificates) a Like token.
Aug 16 2017, 11:19 AM · Calendar
OCram added a comment to T10252: Username autocompletion doesn't work with some non-US keyboard layouts.

It works great now with Windows + Chrome + German keyboard layout!

Aug 16 2017, 6:41 AM · Restricted Project, Bug Report
chad added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

Search is now in the header, see rP

Aug 16 2017, 1:47 AM · Diffusion, Design

Aug 15 2017

• tomekj2ee awarded T6072: Improve usability of `arc diff` a Like token.
Aug 15 2017, 10:02 PM · Restricted Project, Documentation, Arcanist
darkwing added a watcher for Doorkeeper: darkwing.
Aug 15 2017, 8:32 PM
epriestley closed T6861: PHP sort function is unpredictable to human minds when dealing with mixed types as Resolved.

Practically, msortv() and PhutilSortVector are now the solution here. They provide high-performance (no usort*()), multi-dimensional, stable, explicitly typed sort.

Aug 15 2017, 6:17 PM · Infrastructure
epriestley removed a project from T9518: In diff summary linting error code shown instead of message, when PHP_CodeSniffer linter was used: Differential.
Aug 15 2017, 5:59 PM · Lint
epriestley closed T10856: Small Revision page enhanchments as Resolved.

Just sweeping this up, rewriting the property display to show +x seems reasonable to me but I think it's self-evident enough that we don't need to keep a task around for it.

Aug 15 2017, 5:58 PM · Restricted Project, Feature Request, Differential
epriestley closed T11218: Differential advanced search: bucket/group by repository, a subtask of T9287: Working with many repositories, as Wontfix.
Aug 15 2017, 5:56 PM · Restricted Project, Restricted Project, Diffusion
epriestley closed T11218: Differential advanced search: bucket/group by repository as Wontfix.

I don't think this meets the high bar required by modern feature requests (see "Upstreamable Feautures" in Planning).

Aug 15 2017, 5:56 PM · Restricted Project, Differential, Feature Request
epriestley closed T11900: Create bot reviewers that do code analysis and post findings as inline comments. as Wontfix.

(This isn't anything upstream-actionable.)

Aug 15 2017, 5:55 PM · Differential, Feature Request
epriestley moved T12534: Differential still appears in "responsible users" query after resigning as a reviewer from Backlog to Reviewer Rules on the Differential board.
Aug 15 2017, 5:54 PM · Bug Report (Needs Information), Differential
epriestley moved T12539: Revision with an older "accept" showed up in "waiting on other reviewers" after "request review" from Backlog to Reviewer Rules on the Differential board.
Aug 15 2017, 5:54 PM · Differential
epriestley moved T12689: Mail is still received after resigning from a revision from Backlog to Reviewer Rules on the Differential board.
Aug 15 2017, 5:53 PM · Mail, Differential, Bug Report
epriestley closed T12733: (2017 Week 20) Inline Comments Errata / Feedback as Resolved.

This seems to have calmed down.

Aug 15 2017, 5:53 PM · Inline Comments, Installing & Upgrading, Differential
epriestley moved T12920: Retracting requested changes can leave revision in "Needs Revision" state from Backlog to Reviewer Rules on the Differential board.
Aug 15 2017, 5:53 PM · Restricted Project, Differential, Bug Report
epriestley closed T10967: Move Differential reviewers back to a dedicated database storage table as Resolved.

We appear to have survived this. D18398 removed the double writes. There's a bit more cleanup (we could remove the edge type and actually destroy the older data) but that can happen whenever we get around to it.

Aug 15 2017, 5:51 PM · Restricted Project, Infrastructure, Differential
fooishbar added a comment to T10890: Less chatty Maniphest feed rendering.

I don't think this clearly describes a root problem. PHI33 touches on similar issues, and I'll file something vaguely in this realm if anything comes of that.

Aug 15 2017, 5:49 PM · Maniphest, Feature Request
epriestley closed T1084: Preview what's new in a diff when attaching it to an existing revision as Wontfix.

This is five years old, and doesn't meet the requirements of a modern feature request. If you're still interested in this, feel free to start a new discussion on Discourse.

Aug 15 2017, 5:49 PM · Restricted Project, Arcanist, Differential
epriestley closed T8134: There should be a way to quickly navigate between new comments as Wontfix.

This doesn't meet the criteria of a modern feature request and predates significant changes to the inline comment UI. If this is still an issue, feel free to start a new discussion on Discourse.

Aug 15 2017, 5:46 PM · Restricted Project, Differential
epriestley closed T12548: Unable to initialize database with invalid credentials in configuration file as Invalid.

Closing this for lack of feedback, feel free to resurrect it if you get back to it.

Aug 15 2017, 5:34 PM · Database, Bug Report
epriestley closed T12602: Assignees of tasks don't count as subscribers in maniphest search as Invalid.

This isn't a bug; they aren't subscribers, and aren't listed in "Subscribers" in the right-hand column or in "Subscribers" in "Edit Task".

Aug 15 2017, 5:32 PM · Maniphest, Bug Report
epriestley closed T10890: Less chatty Maniphest feed rendering as Wontfix.

I don't think this clearly describes a root problem. PHI33 touches on similar issues, and I'll file something vaguely in this realm if anything comes of that.

Aug 15 2017, 5:19 PM · Maniphest, Feature Request
saggid awarded P2068 Ubuntu 16.04.3 Installer Script a Evil Spooky Haunted Tree token.
Aug 15 2017, 7:37 AM
chad closed T12962: Unable to review instance billing information on `admin.phacility.com` as Resolved.
Aug 15 2017, 12:14 AM · Phacility
chad added a revision to T12962: Unable to review instance billing information on `admin.phacility.com`: Unknown Object (Differential Revision).
Aug 15 2017, 12:14 AM · Phacility

Aug 14 2017

epriestley added a comment to T12962: Unable to review instance billing information on `admin.phacility.com`.

I just clicked through it, I don't think there's any reason for staff to be there normally.

Aug 14 2017, 10:39 PM · Phacility
chad added a comment to T12962: Unable to review instance billing information on `admin.phacility.com`.

Just curious what you want to do there as staff.

Aug 14 2017, 10:34 PM · Phacility
chad added a comment to T12962: Unable to review instance billing information on `admin.phacility.com`.

Is this what you expect to see:

Aug 14 2017, 10:34 PM · Phacility
chad added a comment to T12962: Unable to review instance billing information on `admin.phacility.com`.

Alrighty

Aug 14 2017, 10:03 PM · Phacility
epriestley assigned T12962: Unable to review instance billing information on `admin.phacility.com` to chad.
Aug 14 2017, 10:03 PM · Phacility
epriestley created T12962: Unable to review instance billing information on `admin.phacility.com`.
Aug 14 2017, 10:01 PM · Phacility
epriestley added a revision to T12956: Upgrade saved queries in ApplicationSearch to use a "personal" + "global/default" model, like the home menu: Unknown Object (Differential Revision).
Aug 14 2017, 8:15 PM · ApplicationSearch
epriestley closed T12961: [CVE-2017-1000117, et al] Git, Mercurial and Subversion could all execute arbitrary commands when interacting with malicious SSH URIs (`ssh://-...`) as Resolved.

There doesn't seem to be anything actionable remaining on our end.

Aug 14 2017, 8:07 PM · Subversion, Mercurial, Git, Security
epriestley added a revision to T12956: Upgrade saved queries in ApplicationSearch to use a "personal" + "global/default" model, like the home menu: Unknown Object (Differential Revision).
Aug 14 2017, 6:13 PM · ApplicationSearch
epriestley added a comment to T12956: Upgrade saved queries in ApplicationSearch to use a "personal" + "global/default" model, like the home menu.

We still get a tiny mess where administrators clicking "pin" might mean "pin by default for all users" or "pin by default for just me" but that's reasonable to clarify in the workflow.

Aug 14 2017, 4:58 PM · ApplicationSearch
epriestley added a comment to T12956: Upgrade saved queries in ApplicationSearch to use a "personal" + "global/default" model, like the home menu.

Currently, users may hide or reorder builtin queries. With the simplest version of the plan above, users will lose that ability: builtin queries will always be visible (unless hidden by an administrator) and always at the bottom of the list.

Aug 14 2017, 4:30 PM · ApplicationSearch
epriestley added a comment to T5963: Hosted repos could set default branch in HEAD to help new clones.

@aubort, please use the community forum (see: Discourse) if you'd like to discuss this issue.

Aug 14 2017, 4:05 PM · Diffusion
epriestley added a comment to T12742: `arc land` shows only part of the error that causes the final squash to fail.

@aleb, if you like to continue discussion of this please use the appropriate channels, as @chad suggested above (at the time, they were Conpherence and Ponder, but the appropriate channel is now the community forum -- see: Discourse).

Aug 14 2017, 4:04 PM · Bug Report
epriestley added a revision to T12956: Upgrade saved queries in ApplicationSearch to use a "personal" + "global/default" model, like the home menu: Unknown Object (Differential Revision).
Aug 14 2017, 4:01 PM · ApplicationSearch
aubort added a comment to T5963: Hosted repos could set default branch in HEAD to help new clones.

+1 the problem is still here. There's no way for a end user to make it right without the need for an admin to go run a command on the server, which is not very good.

Aug 14 2017, 12:41 PM · Diffusion
aleb added a comment to T12742: `arc land` shows only part of the error that causes the final squash to fail.

The error truncating behavior affects also Diffusion > R > Status, where only part of the stderr is shown, making it impossible to debug the problem without hacking Phabricator:

ab@phabricator-1-vm:/opt/bitnami$ diff apps/phabricator/libphutil/src/future/exec/CommandException.php.original apps/phabricator/libphutil/src/future/exec/CommandException.php
59c59
<     $limit = 1000;
---
>     $limit = 1000000000;
Aug 14 2017, 11:09 AM · Bug Report
chad edited P2068 Ubuntu 16.04.3 Installer Script.
Aug 14 2017, 4:40 AM

Aug 13 2017

chad created P2069 Fedora 26 Installer.
Aug 13 2017, 12:30 AM

Aug 12 2017

epriestley added a comment to T9408: Upgrading: `dot` (Graphviz) support removed, changes to `figlet` and `cowsay`.

In https://hackerone.com/reports/259246 (not currently disclosed) a researcher found an actual issue with figlet. Although it would probably be hard to develop into a practical attack, it does make me feel better about the decision to pull all this stuff into PHP (not just dot) when the dot issue was originally identified.

Aug 12 2017, 11:02 PM · Remarkup, Security, Installing & Upgrading
chad edited P2068 Ubuntu 16.04.3 Installer Script.
Aug 12 2017, 9:21 PM
chad edited P2068 Ubuntu 16.04.3 Installer Script.
Aug 12 2017, 9:15 PM
chad created P2068 Ubuntu 16.04.3 Installer Script.
Aug 12 2017, 9:05 PM
epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

I've landed the two scary migration changes (D18418, D18419) and deployed them here without any obvious issues arising. The actual effects here are:

Aug 12 2017, 11:17 AM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a parent task for T929: Allow two arbitrary revisions to be compared in Diffusion: T12824: Redesign Diffusion.
Aug 12 2017, 10:52 AM · Diffusion (v3), Restricted Project
epriestley added a subtask for T12824: Redesign Diffusion: T929: Allow two arbitrary revisions to be compared in Diffusion.
Aug 12 2017, 10:52 AM · Design, Diffusion
epriestley merged T12831: Update compare page with more features into T929: Allow two arbitrary revisions to be compared in Diffusion.
Aug 12 2017, 10:52 AM · Diffusion (v3), Restricted Project
epriestley merged task T12831: Update compare page with more features into T929: Allow two arbitrary revisions to be compared in Diffusion.
Aug 12 2017, 10:52 AM · Design, Diffusion
epriestley added a comment to T12831: Update compare page with more features.

I'm just going to merge this into T929, I don't think it's a distinct task. I'll link that to T12824.

Aug 12 2017, 10:52 AM · Design, Diffusion
epriestley closed T12854: Clean up resources for decommissioned `repo012`, a subtask of T12798: Decommission cluster host `repo012`, as Resolved.
Aug 12 2017, 10:50 AM · Ops, Phacility
epriestley closed T12854: Clean up resources for decommissioned `repo012` as Resolved.

They should fix themselves once the instance is suspended.

Aug 12 2017, 10:50 AM · Ops, Phacility
epriestley added a subtask for T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: T12928: Tokens in the form "v0.1" are not handled well by the MySQL FULLTEXT index.
Aug 12 2017, 10:44 AM · Restricted Project, Search
epriestley added a parent task for T12928: Tokens in the form "v0.1" are not handled well by the MySQL FULLTEXT index: T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size.
Aug 12 2017, 10:44 AM · Customer Impact, Search
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Aug 12 2017, 12:03 AM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential

Aug 11 2017

epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Aug 11 2017, 11:34 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Aug 11 2017, 11:23 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Aug 11 2017, 11:06 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Aug 11 2017, 10:50 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Aug 11 2017, 10:45 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Aug 11 2017, 10:39 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Aug 11 2017, 10:18 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
chad closed T12755: Aphlict doesn't work with the latest version of `ws` as Resolved by committing Restricted Diffusion Commit.
Aug 11 2017, 10:17 PM · Aphlict, Bug Report
chad added a revision to T12755: Aphlict doesn't work with the latest version of `ws`: Unknown Object (Differential Revision).
Aug 11 2017, 10:03 PM · Aphlict, Bug Report
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Aug 11 2017, 9:39 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Aug 11 2017, 8:26 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a comment to T12961: [CVE-2017-1000117, et al] Git, Mercurial and Subversion could all execute arbitrary commands when interacting with malicious SSH URIs (`ssh://-...`).

This cropped up in the HN thread -- works in my browsers (although Phabricator does not recognize it as a valid link):

Aug 11 2017, 8:07 PM · Subversion, Mercurial, Git, Security
avivey added a comment to T12961: [CVE-2017-1000117, et al] Git, Mercurial and Subversion could all execute arbitrary commands when interacting with malicious SSH URIs (`ssh://-...`).

Thanks for the writeup :)

Aug 11 2017, 7:04 PM · Subversion, Mercurial, Git, Security
kojik1010 added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

adding my vote to @ivo's suggestion.

Aug 11 2017, 6:59 PM · Diffusion, Design
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Aug 11 2017, 4:53 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Aug 11 2017, 4:48 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Aug 11 2017, 4:47 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T10967: Move Differential reviewers back to a dedicated database storage table: Unknown Object (Differential Revision).
Aug 11 2017, 4:47 PM · Restricted Project, Infrastructure, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Aug 11 2017, 4:34 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Aug 11 2017, 4:33 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Restricted Differential Revision.
Aug 11 2017, 4:20 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Aug 11 2017, 4:06 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
indygreg added a comment to T12961: [CVE-2017-1000117, et al] Git, Mercurial and Subversion could all execute arbitrary commands when interacting with malicious SSH URIs (`ssh://-...`).

The reason the upstream projects aren't using -- is that it isn't portable. For example, Putty's ssh doesn't support it.

Aug 11 2017, 3:45 PM · Subversion, Mercurial, Git, Security
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Aug 11 2017, 3:13 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Aug 11 2017, 2:58 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley updated the task description for T12961: [CVE-2017-1000117, et al] Git, Mercurial and Subversion could all execute arbitrary commands when interacting with malicious SSH URIs (`ssh://-...`).
Aug 11 2017, 1:41 PM · Subversion, Mercurial, Git, Security
epriestley added a comment to T12961: [CVE-2017-1000117, et al] Git, Mercurial and Subversion could all execute arbitrary commands when interacting with malicious SSH URIs (`ssh://-...`).

The full set of mitigations is now available in stable, and I've promoted 2017 Week 32 (Mid August).

Aug 11 2017, 1:36 PM · Subversion, Mercurial, Git, Security