Page MenuHomePhabricator
Feed Advanced Search

Jun 6 2016

epriestley added a revision to T10785: Allow custom third-party auth providers to implement autologin: Restricted Differential Revision.
Jun 6 2016, 8:13 PM · Prioritized, Auth, Restricted Project, Feature Request
epriestley added a project to T10785: Allow custom third-party auth providers to implement autologin: Prioritized.

I'm going to support third-party (as here) and OAuth2 (easy) but we have no use cases for other stuff right now (mostly OAuth1 on Twitter/Jira/Bitbucket, I think).

Jun 6 2016, 8:02 PM · Prioritized, Auth, Restricted Project, Feature Request
epriestley renamed T10785: Allow custom third-party auth providers to implement autologin from Support auto-login on all auth providers that can reasonably support it. to Allow custom third-party auth providers to implement autologin.
Jun 6 2016, 8:01 PM · Prioritized, Auth, Restricted Project, Feature Request
epriestley claimed T10431: Allow arc alias to read aliases from system configuration file.
Jun 6 2016, 7:40 PM · Prioritized, Restricted Project, Arcanist, Feature Request
epriestley added a comment to T10402: Add a client setup check to detect that the browser is using HTTPS but Phabricator does not recognize it.

Yeah, I think something similar to D15961 is reasonable here. It's going to a little bit one-off and weird, but this and the timezone checks are the only cases where we care about client settings, I think.

Jun 6 2016, 7:17 PM · Setup
epriestley added a comment to T11103: Browser do not connect to aphlict (notification) server using ssl terminating nginx reverse proxy.

T10402 is the "check client/server agreement about HTTPS" task.

Jun 6 2016, 6:54 PM · Notifications, Aphlict, Bug Report
epriestley added a comment to T11101: Subproject tasks get orphaned when switching to parent workboard.

This was likely fixed by D16052 (June 5th). Can you reproduce the issue at HEAD?

Jun 6 2016, 4:14 PM · Projects, Bug Report
epriestley added a revision to T3353: Make Phriction Document changes reviewable: Unknown Object (Differential Revision).
Jun 6 2016, 3:23 PM · Restricted Project, Prioritized, Phriction
epriestley added a comment to T10382: Transaction abort when pushing via SSH to a Mercurial repository.

See T9548#139908 for some discussion.

Jun 6 2016, 3:19 PM · Mercurial, Bug Report
epriestley added a revision to T3353: Make Phriction Document changes reviewable: Unknown Object (Differential Revision).
Jun 6 2016, 3:01 PM · Restricted Project, Prioritized, Phriction
epriestley closed T11099: Timezone issue in Phrequent as Invalid.

I can't reproduce this. Here's what I did. I set the server timezone to "America/Chicago":

Jun 6 2016, 1:59 PM · Bug Report
epriestley merged task T11100: transaction abort! when push a lot of changes with mercurial into T10382: Transaction abort when pushing via SSH to a Mercurial repository.
Jun 6 2016, 1:51 PM · Bug Report
epriestley merged T11100: transaction abort! when push a lot of changes with mercurial into T10382: Transaction abort when pushing via SSH to a Mercurial repository.
Jun 6 2016, 1:51 PM · Mercurial, Bug Report
epriestley added a revision to T10811: `phd-daemon` crash after automatic restart following config change: Unknown Object (Differential Revision).
Jun 6 2016, 1:35 PM · Daemons, Bug Report
epriestley added a revision to T10811: `phd-daemon` crash after automatic restart following config change: Unknown Object (Differential Revision).
Jun 6 2016, 1:34 PM · Daemons, Bug Report

Jun 5 2016

epriestley closed T11088: Moving a task to a parent project via non-workboard methods does not remove it from milestone columns as Resolved by committing Restricted Diffusion Commit.
Jun 5 2016, 11:06 PM · Maniphest, Projects (v3), Bug Report
epriestley triaged T11073: Allow the user to specify a date in a different timezone using date controls as Wishlist priority.

I think this is reasonable to add to date controls in the very long run, but suspect few users routinely create events or countdowns in non-local timezones.

Jun 5 2016, 11:05 PM · KDE, Calendar, Feature Request
epriestley added a comment to T11088: Moving a task to a parent project via non-workboard methods does not remove it from milestone columns.

This also reproduced with normal "Edit Projects", it wasn't specific to the bulk editor.

Jun 5 2016, 11:03 PM · Maniphest, Projects (v3), Bug Report
epriestley renamed T11088: Moving a task to a parent project via non-workboard methods does not remove it from milestone columns from Batch Editor doesn't assign parent project if task already exists in Milestone to Moving a task to a parent project via non-workboard methods does not remove it from milestone columns.
Jun 5 2016, 11:01 PM · Maniphest, Projects (v3), Bug Report
epriestley added a revision to T11088: Moving a task to a parent project via non-workboard methods does not remove it from milestone columns: Unknown Object (Differential Revision).
Jun 5 2016, 11:01 PM · Maniphest, Projects (v3), Bug Report
epriestley closed T11084: LDAP Unable to Connect as Invalid.

If you come up with reproduction steps, feel free to file a new report.

Jun 5 2016, 10:28 PM · Bug Report
epriestley closed T8203: Make Phacility account import default to "ignore" and confirm imports as Resolved.

The safer default generally seems sufficient here.

Jun 5 2016, 10:26 PM · Phacility
epriestley closed T8203: Make Phacility account import default to "ignore" and confirm imports, a subtask of T8210: Phacility Cluster: Bastion host stopped responding, as Resolved.
Jun 5 2016, 10:26 PM · Ops, Phacility
epriestley closed T10457: Improve Harbomaster/Drydock UI/UX before release as Resolved.

I don't think there's anything actionable remaining here that isn't covered elsewhere.

Jun 5 2016, 10:24 PM · Harbormaster (v3), Drydock (v3), Phacility
epriestley closed T10457: Improve Harbomaster/Drydock UI/UX before release, a subtask of T10246: Deploy Drydock in the Phacility cluster, as Resolved.
Jun 5 2016, 10:24 PM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
epriestley closed T10809: SVN service proxying in Phacility cluster can fail in a couple of ways as Resolved.

This has been live for some time and appears to have resolved the problems.

Jun 5 2016, 10:24 PM · Diffusion, Subversion, Phacility
epriestley closed T10832: Evaluate Git remote execution vulnerabilities with 2GB pathnames as Resolved.
Jun 5 2016, 10:22 PM · Ops, Git, Phacility, Security
epriestley closed T10849: Support query timeouts via `max_statement_time` or MYSLQI_ASYNC as Resolved.

This has been live for some time now.

Jun 5 2016, 10:21 PM · Infrastructure, Phacility
epriestley closed T10077: Reduce the cost of building the "Quick Create" menu as Resolved.

D16045 reduced this to one query. We can cache it more aggressively and amortize the cost to 0 queries, but I'll leave that for T11096. This is no longer wildly out of line in terms of cost/value.

Jun 5 2016, 10:20 PM · Infrastructure, Performance
epriestley added a project to T11097: Pop-up notifications picked up a timestamp as a side effect: Notifications.
Jun 5 2016, 10:11 PM · Notifications
epriestley added a revision to T11098: Feedback and Errata for Global Settings: Unknown Object (Differential Revision).
Jun 5 2016, 8:54 PM · Prioritized, Restricted Project, User Preferences
epriestley added a revision to T11098: Feedback and Errata for Global Settings: Unknown Object (Differential Revision).
Jun 5 2016, 8:41 PM · Prioritized, Restricted Project, User Preferences
epriestley added a revision to T11098: Feedback and Errata for Global Settings: Unknown Object (Differential Revision).
Jun 5 2016, 8:36 PM · Prioritized, Restricted Project, User Preferences
epriestley added a comment to T11098: Feedback and Errata for Global Settings.

Ah, thanks. We actually have a lot more of those than I realized.

Jun 5 2016, 8:31 PM · Prioritized, Restricted Project, User Preferences
epriestley moved T11098: Feedback and Errata for Global Settings from Backlog to Paused on the Prioritized board.
Jun 5 2016, 8:26 PM · Prioritized, Restricted Project, User Preferences
epriestley added projects to T11098: Feedback and Errata for Global Settings: Restricted Project, Prioritized.
Jun 5 2016, 8:26 PM · Prioritized, Restricted Project, User Preferences
epriestley closed T4103: Implement "Role Profiles" to provide search, homepage and application defaults as Spite.
  • Settings → Create Global Defaults as an administrator to set global defaults.
  • T11098 for feedback or bugs.
Jun 5 2016, 8:26 PM · Prioritized, Restricted Project, Restricted Project, Dashboards, Applications
epriestley awarded T4103: Implement "Role Profiles" to provide search, homepage and application defaults a The World Burns token.
Jun 5 2016, 8:22 PM · Prioritized, Restricted Project, Restricted Project, Dashboards, Applications
epriestley added a project to T11098: Feedback and Errata for Global Settings: User Preferences.
Jun 5 2016, 8:22 PM · Prioritized, Restricted Project, User Preferences
epriestley created T11098: Feedback and Errata for Global Settings.
Jun 5 2016, 8:20 PM · Prioritized, Restricted Project, User Preferences
epriestley added a revision to T4103: Implement "Role Profiles" to provide search, homepage and application defaults: Unknown Object (Differential Revision).
Jun 5 2016, 8:02 PM · Prioritized, Restricted Project, Restricted Project, Dashboards, Applications
epriestley closed T11095: $PATH Component Unusable as Invalid.
Jun 5 2016, 6:35 PM · Support Request
epriestley created T11097: Pop-up notifications picked up a timestamp as a side effect.
Jun 5 2016, 5:29 PM · Notifications
epriestley added a revision to T4103: Implement "Role Profiles" to provide search, homepage and application defaults: Unknown Object (Differential Revision).
Jun 5 2016, 5:25 PM · Prioritized, Restricted Project, Restricted Project, Dashboards, Applications
epriestley closed T8846: Unable to turn off Desktop Notifications as Resolved by committing Restricted Diffusion Commit.
Jun 5 2016, 3:49 PM · Notifications
epriestley added a comment to T11095: $PATH Component Unusable.

This is the UI you saw, right? Is there any way we could make this more clear?

Jun 5 2016, 3:27 PM · Support Request
epriestley added a revision to T4103: Implement "Role Profiles" to provide search, homepage and application defaults: Unknown Object (Differential Revision).
Jun 5 2016, 2:50 PM · Prioritized, Restricted Project, Restricted Project, Dashboards, Applications
epriestley added a revision to T10077: Reduce the cost of building the "Quick Create" menu: Unknown Object (Differential Revision).
Jun 5 2016, 2:34 PM · Infrastructure, Performance
epriestley added a revision to T10078: Implement global readthrough cache pools: Unknown Object (Differential Revision).
Jun 5 2016, 1:58 PM · Restricted Project, Infrastructure, Performance
epriestley added a revision to T4103: Implement "Role Profiles" to provide search, homepage and application defaults: Unknown Object (Differential Revision).
Jun 5 2016, 1:54 PM · Prioritized, Restricted Project, Restricted Project, Dashboards, Applications
epriestley added a revision to T10078: Implement global readthrough cache pools: Unknown Object (Differential Revision).
Jun 5 2016, 1:53 PM · Restricted Project, Infrastructure, Performance
epriestley added a revision to T4103: Implement "Role Profiles" to provide search, homepage and application defaults: Unknown Object (Differential Revision).
Jun 5 2016, 1:39 PM · Prioritized, Restricted Project, Restricted Project, Dashboards, Applications
epriestley added a revision to T10078: Implement global readthrough cache pools: Unknown Object (Differential Revision).
Jun 5 2016, 1:39 PM · Restricted Project, Infrastructure, Performance
epriestley added a comment to T11095: $PATH Component Unusable.

Sorry for the delay, we're mostly Pacific Time here so this was filed around 3AM for us.

Jun 5 2016, 1:13 PM · Support Request
epriestley added a revision to T4103: Implement "Role Profiles" to provide search, homepage and application defaults: Unknown Object (Differential Revision).
Jun 5 2016, 1:55 AM · Prioritized, Restricted Project, Restricted Project, Dashboards, Applications
epriestley added a revision to T10078: Implement global readthrough cache pools: Unknown Object (Differential Revision).
Jun 5 2016, 1:54 AM · Restricted Project, Infrastructure, Performance
epriestley added a revision to T4103: Implement "Role Profiles" to provide search, homepage and application defaults: Unknown Object (Differential Revision).
Jun 5 2016, 1:00 AM · Prioritized, Restricted Project, Restricted Project, Dashboards, Applications
epriestley added a revision to T10078: Implement global readthrough cache pools: Unknown Object (Differential Revision).
Jun 5 2016, 1:00 AM · Restricted Project, Infrastructure, Performance

Jun 4 2016

epriestley added a revision to T4103: Implement "Role Profiles" to provide search, homepage and application defaults: Unknown Object (Differential Revision).
Jun 4 2016, 11:26 PM · Prioritized, Restricted Project, Restricted Project, Dashboards, Applications
epriestley added a revision to T4103: Implement "Role Profiles" to provide search, homepage and application defaults: Unknown Object (Differential Revision).
Jun 4 2016, 11:23 PM · Prioritized, Restricted Project, Restricted Project, Dashboards, Applications
epriestley added a revision to T4103: Implement "Role Profiles" to provide search, homepage and application defaults: Unknown Object (Differential Revision).
Jun 4 2016, 10:10 PM · Prioritized, Restricted Project, Restricted Project, Dashboards, Applications
epriestley added a revision to T4103: Implement "Role Profiles" to provide search, homepage and application defaults: Unknown Object (Differential Revision).
Jun 4 2016, 10:02 PM · Prioritized, Restricted Project, Restricted Project, Dashboards, Applications
epriestley added a revision to T8846: Unable to turn off Desktop Notifications: Unknown Object (Differential Revision).
Jun 4 2016, 10:02 PM · Notifications
epriestley added a revision to T4103: Implement "Role Profiles" to provide search, homepage and application defaults: Unknown Object (Differential Revision).
Jun 4 2016, 9:48 PM · Prioritized, Restricted Project, Restricted Project, Dashboards, Applications
epriestley added a comment to T8846: Unable to turn off Desktop Notifications.

I think this has never worked -- nothing actually reads this preference. This makes converting it for T4103 a little tricky.

Jun 4 2016, 3:17 PM · Notifications
epriestley added a revision to T4103: Implement "Role Profiles" to provide search, homepage and application defaults: Unknown Object (Differential Revision).
Jun 4 2016, 3:09 PM · Prioritized, Restricted Project, Restricted Project, Applications, Dashboards
epriestley added a revision to T4103: Implement "Role Profiles" to provide search, homepage and application defaults: Unknown Object (Differential Revision).
Jun 4 2016, 3:05 PM · Prioritized, Restricted Project, Restricted Project, Applications, Dashboards
epriestley closed T11076: Ship CORGI as Resolved.
  • I nuked the corp and clb devices and DNS, and updated the documentation.
  • I aligned reserved instances with actual usage after changes.
  • I also added secure002 to plb001 (the phurl.io LB).
Jun 4 2016, 1:24 PM · Prioritized, Ops, Phacility
epriestley updated the task description for T11076: Ship CORGI.
Jun 4 2016, 1:18 PM · Prioritized, Ops, Phacility
epriestley edited the content of Phacility Cluster Devices.
Jun 4 2016, 1:11 PM
asherkin awarded Blog Post: Write, Review, Merge, Publish: Phabricator Review Workflow a Mountain of Wealth token.
Jun 4 2016, 1:02 PM
epriestley added a comment to T11076: Ship CORGI.

I think this is live now. I'm going to complete the rest of the deploy and then button up the AWS stuff, but yell if it's horribly broken or whatever.

Jun 4 2016, 12:49 PM · Prioritized, Ops, Phacility
epriestley updated the task description for T11076: Ship CORGI.
Jun 4 2016, 12:48 PM · Prioritized, Ops, Phacility

Jun 3 2016

epriestley edited the content of Changelog.
Jun 3 2016, 9:37 PM
epriestley created 2016 Week 23 (Early June).
Jun 3 2016, 9:36 PM
epriestley created T11093: DifferentialInlineCommentEditor retains state across Quicksand requests.
Jun 3 2016, 9:06 PM · Inline Comments, Restricted Project, Quicksand, Differential
epriestley added a comment to T8852: Comments attaching to wrong diff with chat column open.

T11092 has a lot of discussion, but D16031 will almost certainly prevent this from doing damage. It does not fix the underlying Quicksand issue, but you should get an immediate error instead of confusing/spooky behavior/apparent data loss.

Jun 3 2016, 8:48 PM · Quicksand, Conpherence, Differential
epriestley added a comment to T11092: Review comments lost or posted to wrong diff.

Assuming D16031 is a common element, you can identify all comments with inconsistent state like this:

Jun 3 2016, 8:46 PM · Differential, Bug Report
epriestley added a revision to T11092: Review comments lost or posted to wrong diff: Unknown Object (Differential Revision).
Jun 3 2016, 8:39 PM · Differential, Bug Report
epriestley added a comment to T11092: Review comments lost or posted to wrong diff.

It's not permanent, but this sequence would cause the problem:

Jun 3 2016, 8:35 PM · Differential, Bug Report
epriestley added a comment to T11092: Review comments lost or posted to wrong diff.

Is he 100% sure he has never touched the \ key on his keyboard to bring up the chat sidebar?

Jun 3 2016, 8:31 PM · Differential, Bug Report
epriestley added a comment to T11092: Review comments lost or posted to wrong diff.

I was able to reproduce some flavor of this for inline comments with Quicksand enabled (i.e., the persistent Conpherence chat sidebar open). That's probably T8852, but I expect it to be specific to Quicksand / client-side JS state and impossible to hit without pressing the \ key to open the chat column. I should be able to fix this, but I can't repro it without opening the column.

Jun 3 2016, 8:24 PM · Differential, Bug Report
epriestley added a comment to T11092: Review comments lost or posted to wrong diff.

There's no possible way that PDF is about inline comments, I think? How do inline comments appear on different reviews which presumably have different files? Or did they happen to affect the same files?

Jun 3 2016, 7:54 PM · Differential, Bug Report
epriestley added a comment to T11092: Review comments lost or posted to wrong diff.

Particularly useful, then, would be to find these inlines in the database and figure out what happened to them.

Jun 3 2016, 7:48 PM · Differential, Bug Report
epriestley added a comment to T11092: Review comments lost or posted to wrong diff.

Haha, okay. I may be headed down the wrong path -- T5031 is almost certainly not related here, because the draft system and EditEngine don't interact directly with inline comments. This is almost certainly also not Quicksand-related either if the inlines appear correctly originally (Quicksand could potentially mangle request in-flight).

Jun 3 2016, 7:43 PM · Differential, Bug Report
epriestley added a comment to T11092: Review comments lost or posted to wrong diff.

Oh, are "comments" in this description inline comments, versus blocks of comment text?

Jun 3 2016, 7:39 PM · Differential, Bug Report
epriestley added a revision to T4103: Implement "Role Profiles" to provide search, homepage and application defaults: Unknown Object (Differential Revision).
Jun 3 2016, 7:14 PM · Prioritized, Restricted Project, Restricted Project, Applications, Dashboards
epriestley added a comment to T11092: Review comments lost or posted to wrong diff.

We can blindly move Differential to EditEngine, which may fix this indirectly, but this is a large amount of work.

Jun 3 2016, 7:04 PM · Differential, Bug Report
epriestley added a comment to T11092: Review comments lost or posted to wrong diff.

Although I'm not sure this has the same root cause as T8852, I can't reproduce that either.

Jun 3 2016, 7:01 PM · Differential, Bug Report
epriestley merged T8852: Comments attaching to wrong diff with chat column open into T11092: Review comments lost or posted to wrong diff.
Jun 3 2016, 7:00 PM · Differential, Bug Report
epriestley merged task T8852: Comments attaching to wrong diff with chat column open into T11092: Review comments lost or posted to wrong diff.
Jun 3 2016, 7:00 PM · Quicksand, Conpherence, Differential
epriestley added a comment to T11092: Review comments lost or posted to wrong diff.

Here's how I attempted to reproduce this:

Jun 3 2016, 7:00 PM · Differential, Bug Report
epriestley added a comment to T11092: Review comments lost or posted to wrong diff.

When the Conpherence column is open, it activates a completely separate browsing mode (Quicksand) where all navigations occur over Ajax. This is expected to have weird bugs associated with it, but this mode is not active if the column is not open. If the users this is affecting have never opened the chat column, I suspect this is not the same as T8852.

Jun 3 2016, 6:49 PM · Differential, Bug Report
epriestley added a revision to T4103: Implement "Role Profiles" to provide search, homepage and application defaults: Unknown Object (Differential Revision).
Jun 3 2016, 5:53 PM · Prioritized, Restricted Project, Restricted Project, Applications, Dashboards
epriestley added a revision to T4103: Implement "Role Profiles" to provide search, homepage and application defaults: Unknown Object (Differential Revision).
Jun 3 2016, 5:37 PM · Prioritized, Restricted Project, Restricted Project, Applications, Dashboards
epriestley added a comment to T11091: Make `arc patch` try the local working copy and staging areas.

In particular, T182 discusses a desired "chain of custody" workflow where the merge/promote flow happens on the server.

Jun 3 2016, 5:15 PM · Haskell.org, Arcanist
epriestley created T11091: Make `arc patch` try the local working copy and staging areas.
Jun 3 2016, 5:06 PM · Haskell.org, Arcanist
epriestley added a revision to T4103: Implement "Role Profiles" to provide search, homepage and application defaults: Unknown Object (Differential Revision).
Jun 3 2016, 4:23 PM · Prioritized, Restricted Project, Restricted Project, Applications, Dashboards
epriestley added a comment to T11084: LDAP Unable to Connect.

We can only move forward with complete reproduction steps that allow us to reproduce this problem in a local environment.

Jun 3 2016, 4:08 PM · Bug Report
epriestley added a revision to T4103: Implement "Role Profiles" to provide search, homepage and application defaults: Unknown Object (Differential Revision).
Jun 3 2016, 2:49 PM · Prioritized, Restricted Project, Restricted Project, Applications, Dashboards