Page MenuHomePhabricator
Feed Advanced Search

Dec 7 2015

epriestley added a comment to T5622: "copy" attribute for custom fields is not working, at least for text fields.

I've marked D14699 as fixing this, but it only applies to the EditEngine form, see T9905.

Dec 7 2015, 9:40 PM · Maniphest, Custom Fields
epriestley added a revision to T5622: "copy" attribute for custom fields is not working, at least for text fields: Restricted Differential Revision.
Dec 7 2015, 9:40 PM · Maniphest, Custom Fields
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 7 2015, 9:40 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a revision to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter: Unknown Object (Differential Revision).
Dec 7 2015, 9:40 PM · ApplicationEditor
epriestley updated subscribers of T5622: "copy" attribute for custom fields is not working, at least for text fields.
Dec 7 2015, 9:38 PM · Custom Fields, Maniphest
epriestley merged task T8055: "copy":true does not work in Maniphest custom field configuration into T5622: "copy" attribute for custom fields is not working, at least for text fields.
Dec 7 2015, 9:38 PM · Maniphest
epriestley added a revision to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter: Unknown Object (Differential Revision).
Dec 7 2015, 7:27 PM · ApplicationEditor
epriestley added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

Hrrm, double header in the quick create menu is a little weird. Maybe I'll just drop the first header completely, I think it's fairly easy to figure out what the menu is doing.

Dec 7 2015, 7:25 PM · ApplicationEditor
epriestley added a revision to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter: Unknown Object (Differential Revision).
Dec 7 2015, 7:11 PM · ApplicationEditor
epriestley added a revision to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter: Unknown Object (Differential Revision).
Dec 7 2015, 7:00 PM · ApplicationEditor
joshuaspence added a project to T9924: Add support for git worktree: Arcanist.
Dec 7 2015, 6:56 PM · FreeBSD, Restricted Project, Arcanist, Feature Request
joshuaspence added a member for Feature Request: joshuaspence.
Dec 7 2015, 6:53 PM
joshuaspence added a member for Bug Report: joshuaspence.
Dec 7 2015, 6:53 PM
joshuaspence added a project to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter: ApplicationEditor.
Dec 7 2015, 6:49 PM · ApplicationEditor
epriestley added a revision to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter: Unknown Object (Differential Revision).
Dec 7 2015, 6:40 PM · ApplicationEditor
epriestley added a revision to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter: Restricted Differential Revision.
Dec 7 2015, 6:37 PM · ApplicationEditor
epriestley added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

Notes for me / the curious:

Dec 7 2015, 5:57 PM · ApplicationEditor
epriestley added a comment to T9920: Be able to set the sort of the transaction log or set when older changes need to be hidden.

I'm not a big fan of haunt mode and think it's near the top of the "dumbest features" pile, but it's easy to bring everywhere if you're more of a fan. And maybe we're stuck with doing that anyway one Differential folds into EditEngine.

Dec 7 2015, 5:55 PM · Transactions
epriestley updated subscribers of T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.
Dec 7 2015, 5:52 PM · ApplicationEditor
epriestley merged task T9913: ApplicationEditor stacked comment actions can't be removed on mobile into T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.
Dec 7 2015, 5:52 PM · ApplicationEditor, Maniphest
epriestley claimed T9920: Be able to set the sort of the transaction log or set when older changes need to be hidden.
Dec 7 2015, 5:51 PM · Transactions
epriestley reopened T9920: Be able to set the sort of the transaction log or set when older changes need to be hidden as "Open".

Let me at least see if I can tweak the text a little bit, I think this rule can be made more clear than it is.

Dec 7 2015, 5:51 PM · Transactions
epriestley added a comment to T9920: Be able to set the sort of the transaction log or set when older changes need to be hidden.

The logic is "if they've seen them before".

Dec 7 2015, 5:44 PM · Transactions
epriestley triaged T9924: Add support for git worktree as Wishlist priority.

Git 2.5 is less than 6 months old and we haven't seen other interest in this, so it will probably be a while before we get to it, but it's reasonable for us to try to accommodate this better.

Dec 7 2015, 5:40 PM · FreeBSD, Restricted Project, Arcanist, Feature Request
epriestley updated subscribers of T5953: Build a modular user account batch importer.
Dec 7 2015, 5:35 PM · Restricted Project, Auth, Projects
epriestley merged task T9925: Create Multiple Users into T5953: Build a modular user account batch importer.
Dec 7 2015, 5:35 PM · Feature Request
epriestley added a comment to T9925: Create Multiple Users.

I'm going to merge this into T5953, which discusses building a general bulk import workflow (from CSV, LDAP, an external system, etc).

Dec 7 2015, 5:35 PM · Feature Request
epriestley added a comment to T6205: Replace "Associate Projects" action in task editing form with "Edit Projects".

Alright, I'll just replace "Add Projects" with "Change Projects".

Dec 7 2015, 4:53 PM · Projects, Transactions, Maniphest

Dec 6 2015

epriestley added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

From elsewhere:

Dec 6 2015, 4:54 PM · ApplicationEditor
epriestley closed T9917: Example Bug as Spite.
Dec 6 2015, 4:49 PM · Bug Report
epriestley created T9917: Example Bug.
Dec 6 2015, 4:48 PM · Bug Report
epriestley closed T9916: Unable to push to hosted repository as Invalid.

This does not describe a bug in Phabricator. See Support Resources and Contributing Bug Reports.

Dec 6 2015, 3:55 PM · Bug Report
epriestley added a comment to T9876: Arcanist filename linter's regex should be configurable.

I just think this isn't very good:

Dec 6 2015, 1:48 PM · Lint, Arcanist
joshuaspence added a comment to T9876: Arcanist filename linter's regex should be configurable.

For what it's worth, I think that this is a reasonable request. I think that the only way to implement this would be to use a custom message which would be specified in the .arclint file. For example:

Dec 6 2015, 10:15 AM · Lint, Arcanist
epriestley merged T9914: Badges are not shown on some timeline entries into T8941: Badges don't show in certain Timeline conditions.
Dec 6 2015, 2:12 AM · Badges (v0)
epriestley merged task T9914: Badges are not shown on some timeline entries into T8941: Badges don't show in certain Timeline conditions.
Dec 6 2015, 2:12 AM · Transactions, Badges
joshuaspence created T9914: Badges are not shown on some timeline entries.
Dec 6 2015, 1:59 AM · Transactions, Badges
joshuaspence awarded T8707: Task descriptions with leading newlines are not preserved correctly across edits a Love token.
Dec 6 2015, 1:24 AM · Maniphest
epriestley closed T6132: Negative Maniphest priorities can be created, but not used as Resolved by committing Restricted Diffusion Commit.
Dec 6 2015, 1:11 AM · Maniphest
epriestley renamed T9913: ApplicationEditor stacked comment actions can't be removed on mobile from Can't remove action to ApplicationEditor stacked comment actions can't be removed on mobile.
Dec 6 2015, 1:10 AM · ApplicationEditor, Maniphest
epriestley added a comment to T9913: ApplicationEditor stacked comment actions can't be removed on mobile.

Yeah, just a mobile issue.

Dec 6 2015, 1:07 AM · ApplicationEditor, Maniphest
joshuaspence awarded T8707: Task descriptions with leading newlines are not preserved correctly across edits a Heartbreak token.
Dec 6 2015, 12:57 AM · Maniphest
epriestley added a revision to T6132: Negative Maniphest priorities can be created, but not used: Unknown Object (Differential Revision).
Dec 6 2015, 12:52 AM · Maniphest
joshuaspence added a subtask for T9132: Build an ApplicationEditor abstraction: T9913: ApplicationEditor stacked comment actions can't be removed on mobile.
Dec 6 2015, 12:52 AM · Restricted Project, ApplicationEditor, Transactions
joshuaspence added a parent task for T9913: ApplicationEditor stacked comment actions can't be removed on mobile: T9132: Build an ApplicationEditor abstraction.
Dec 6 2015, 12:52 AM · ApplicationEditor, Maniphest
joshuaspence created T9913: ApplicationEditor stacked comment actions can't be removed on mobile.
Dec 6 2015, 12:49 AM · ApplicationEditor, Maniphest
joshuaspence added a comment to T8707: Task descriptions with leading newlines are not preserved correctly across edits.

Nice.

Dec 6 2015, 12:47 AM · Maniphest

Dec 5 2015

epriestley renamed T5586: Make "magic words" in comment text localizable from Configurable prefixes for task refs in commit messages to Make "magic words" in comment text localizable.
Dec 5 2015, 11:50 PM · Localization
epriestley updated subscribers of T4863: Allow Workboard Cards to be customized for display.
Dec 5 2015, 11:48 PM · Projects, Workboards, Wikimedia
epriestley merged task T6005: Allow remarkup syntax for tasks to extract specific fields like assignee or due date into T4863: Allow Workboard Cards to be customized for display.
Dec 5 2015, 11:48 PM · Remarkup, Maniphest
epriestley added a comment to T6005: Allow remarkup syntax for tasks to extract specific fields like assignee or due date.

I assume the use case for this is building tables in, e.g., Phriction documents with the status of various tasks.

Dec 5 2015, 11:48 PM · Remarkup, Maniphest
epriestley moved T6132: Negative Maniphest priorities can be created, but not used from Backlog to vNext on the Maniphest board.
Dec 5 2015, 11:46 PM · Maniphest
epriestley closed T8707: Task descriptions with leading newlines are not preserved correctly across edits as Resolved by committing Restricted Diffusion Commit.
Dec 5 2015, 11:46 PM · Maniphest
epriestley moved T8666: When a task is resolved with "Resolves T123", Phrequent should stop tracking time from Backlog to Far Future on the Maniphest board.
Dec 5 2015, 11:43 PM · Maniphest, Phrequent
epriestley moved T8480: Support querying for tasks where a user has tracked time against them from Backlog to Far Future on the Maniphest board.
Dec 5 2015, 11:43 PM · Phrequent, Maniphest
epriestley moved T8707: Task descriptions with leading newlines are not preserved correctly across edits from Backlog to vNext on the Maniphest board.
Dec 5 2015, 11:42 PM · Maniphest
epriestley added a revision to T8707: Task descriptions with leading newlines are not preserved correctly across edits: Unknown Object (Differential Revision).
Dec 5 2015, 11:39 PM · Maniphest
epriestley claimed T8707: Task descriptions with leading newlines are not preserved correctly across edits.
Dec 5 2015, 11:38 PM · Maniphest
epriestley added a comment to T8707: Task descriptions with leading newlines are not preserved correctly across edits.

Apparently this is just how <textarea> works. Here's a test case in WebKit explicitly testing this behavior:

Dec 5 2015, 11:35 PM · Maniphest
epriestley moved T8740: Batch edit Add Project does not perform the action requested from Backlog to vNext on the Maniphest board.
Dec 5 2015, 11:03 PM · Maniphest
epriestley moved T9905: Upgrading: ApplicationEditor changes in Maniphest from Backlog to vNext on the Maniphest board.
Dec 5 2015, 11:03 PM · Maniphest, Installing & Upgrading
epriestley renamed T9077: Some applications don't support the "Quote" action on comments properly from Quotes don't work in paste and audit to Some applications don't support the "Quote" action on comments properly.
Dec 5 2015, 9:26 PM · Restricted Project, Transactions
epriestley added a comment to T9077: Some applications don't support the "Quote" action on comments properly.

I also made them work in Paste, so generalizing this task per D14416.

Dec 5 2015, 9:26 PM · Restricted Project, Transactions
epriestley closed T8676: Easy raw link for pastes as Resolved.

I implemented this a while ago:

Dec 5 2015, 9:25 PM · Paste
epriestley closed T6270: Search inside Paste as Invalid.

This task doesn't describe a root problem. See Contributing Feature Requests for modern documentation on feature requests.

Dec 5 2015, 9:24 PM · Paste
epriestley closed T8556: Pastes index fails to load. as Invalid.

In any case, we can't reproduce this and aren't sure if it reproduces at HEAD. See Contributing Bug Reports.

Dec 5 2015, 9:22 PM · Paste
epriestley added a comment to T9077: Some applications don't support the "Quote" action on comments properly.

See also D14665 for EditEngine integration, which slightly changes one call.

Dec 5 2015, 9:21 PM · Restricted Project, Transactions
epriestley closed T8853: Allow "Administrator" to be used in Herald rules for "pusher" as Wontfix.

We haven't seen other requests for this and I think putting administrators in a project and using "Pusher's projects ..." is a pretty reasonable workaround. This can also now reasonably be written as an extension.

Dec 5 2015, 9:16 PM · Diffusion, Herald
epriestley merged task T7833: Allow merge commits to be excluded in Herald rules for Audit into T5788: Support "Commit is a merge" in Herald "Commit" (post-commit) rules.
Dec 5 2015, 9:11 PM · Audit, Herald
epriestley updated subscribers of T5788: Support "Commit is a merge" in Herald "Commit" (post-commit) rules.
Dec 5 2015, 9:11 PM · Diffusion, Herald
epriestley merged task T7026: Add "Run build plan" to commit hooks into T9821: Allow Harbormaster build plans to run on branch push instead of per-commit.
Dec 5 2015, 9:10 PM · Harbormaster, Herald
epriestley updated subscribers of T9821: Allow Harbormaster build plans to run on branch push instead of per-commit.
Dec 5 2015, 9:10 PM · Restricted Project, Harbormaster
epriestley closed T5788: Support "Commit is a merge" in Herald "Commit" (post-commit) rules as Resolved by committing Restricted Diffusion Commit.
Dec 5 2015, 9:08 PM · Diffusion, Herald
epriestley closed T6763: Allow herald rules to filter on branch/tag creation in Subversion as Wontfix.

We haven't seen other requests for this in a year, and our behavior is technically correct and I think it is broadly reasonable.

Dec 5 2015, 9:07 PM · Subversion, Herald
epriestley added a revision to T5788: Support "Commit is a merge" in Herald "Commit" (post-commit) rules: Unknown Object (Differential Revision).
Dec 5 2015, 8:58 PM · Diffusion, Herald
epriestley added a project to T5788: Support "Commit is a merge" in Herald "Commit" (post-commit) rules: Diffusion.
Dec 5 2015, 8:57 PM · Diffusion, Herald
epriestley claimed T5788: Support "Commit is a merge" in Herald "Commit" (post-commit) rules.
Dec 5 2015, 8:57 PM · Diffusion, Herald
epriestley closed T5274: Herald Rules - Trigger when Diff content contains as Wontfix.

I don't think this is a good fit for the upstream: it's inherently a bit unreliable, can't be made reliable, and I don't think the use case described here is a particularly robust one even if it's reasonable for some organizations.

Dec 5 2015, 8:47 PM · Herald
epriestley closed T5162: Add Herald action value for content creator / author as Wontfix.

This doesn't describe a use case (per Contributing Feature Requests) except by reference to requiring projects (which is covered by T6030).

Dec 5 2015, 8:42 PM · Herald
epriestley closed T9206: Herald unable to place task up for grabs as Resolved by committing Restricted Diffusion Commit.
Dec 5 2015, 8:39 PM · Typeahead, Herald
epriestley added a revision to T9206: Herald unable to place task up for grabs: Unknown Object (Differential Revision).
Dec 5 2015, 8:38 PM · Typeahead, Herald
epriestley added a comment to T9352: Write some custom Herald glue for driving builds through Owners.

At HEAD, you can now edit this field via the owners.edit Conduit API method.

Dec 5 2015, 8:27 PM · Harbormaster, Herald, Owners, Prioritized
epriestley closed T9601: Herald rule not working as expected as Invalid.

No clue how to reproduce. If you see it again, grab the field value too? My guess is that it's something like the reviewer PHID ending up as the project PHID instead of your PHID and "Reviewer" needing to be updated to "Reviewers" or similar.

Dec 5 2015, 8:26 PM · Herald
epriestley added a comment to T7661: Object creation is often accompanied by transaction records which aren't of much use.

This is related to T5158, I'm going to split things up like this:

Dec 5 2015, 7:27 PM · Transactions, Maniphest
epriestley reopened T5158: Maniphest custom field refuses to use non-empty default value as "Open".

Ah, I figured out how to reproduce this.

Dec 5 2015, 7:25 PM · Maniphest, Custom Fields, Transactions
epriestley renamed T7661: Object creation is often accompanied by transaction records which aren't of much use from Custom field default isn't populated at creation to Object creation is often accompanied by transaction records which aren't of much use.
Dec 5 2015, 7:22 PM · Transactions, Maniphest
epriestley closed T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions as Resolved by committing Restricted Diffusion Commit.
Dec 5 2015, 7:20 PM · Maniphest, Herald
epriestley added a comment to T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions.

I think it wasn't that bad thanks to a similar set of changes elsewhere from D14669, which I wrote yesterday.

Dec 5 2015, 7:19 PM · Maniphest, Herald
epriestley added a revision to T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions: Unknown Object (Differential Revision).
Dec 5 2015, 7:17 PM · Maniphest, Herald
epriestley added a revision to T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions: Unknown Object (Differential Revision).
Dec 5 2015, 7:12 PM · Maniphest, Herald
epriestley closed T9496: Allow Maniphest custom statuses (and priorities) to be disabled as Resolved by committing Restricted Diffusion Commit.
Dec 5 2015, 7:01 PM · Maniphest
epriestley reopened T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions as "Open".
Dec 5 2015, 6:59 PM · Maniphest, Herald
epriestley added a comment to T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions.

Oh, I should have read that comment more carefully. You tested more thoroughly than I did.

Dec 5 2015, 6:59 PM · Maniphest, Herald
epriestley closed T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions as Resolved.
Dec 5 2015, 6:56 PM · Maniphest, Herald
epriestley closed T7250: Actions in wrong order after merging duplicates + reopening as Resolved by committing Restricted Diffusion Commit.
Dec 5 2015, 6:51 PM · Maniphest
epriestley added a revision to T9496: Allow Maniphest custom statuses (and priorities) to be disabled: Unknown Object (Differential Revision).
Dec 5 2015, 6:44 PM · Maniphest
epriestley claimed T9496: Allow Maniphest custom statuses (and priorities) to be disabled.
Dec 5 2015, 6:41 PM · Maniphest
epriestley claimed T7250: Actions in wrong order after merging duplicates + reopening.
Dec 5 2015, 6:09 PM · Maniphest
epriestley added a revision to T7250: Actions in wrong order after merging duplicates + reopening: Unknown Object (Differential Revision).
Dec 5 2015, 6:08 PM · Maniphest
epriestley closed T5158: Maniphest custom field refuses to use non-empty default value as Resolved.

This no longer reproduces for me at HEAD in EditEngine (see T9905), although I can't immediately reproduce it in the old editor either. Since it seems like it got fixed somewhere I'm not going to worry about it too much.

Dec 5 2015, 5:57 PM · Maniphest, Custom Fields, Transactions