Page MenuHomePhabricator
Feed Advanced Search

Sep 13 2015

epriestley added a revision to T7785: Build a Phacility cluster service tier to sandbox Graphviz and Cowsay: Restricted Differential Revision.
Sep 13 2015, 6:50 PM · Phacility, Phacility Support
epriestley added a revision to T7785: Build a Phacility cluster service tier to sandbox Graphviz and Cowsay: Restricted Differential Revision.
Sep 13 2015, 6:27 PM · Phacility, Phacility Support
epriestley added a revision to T7785: Build a Phacility cluster service tier to sandbox Graphviz and Cowsay: Unknown Object (Differential Revision).
Sep 13 2015, 5:26 PM · Phacility, Phacility Support
epriestley added a revision to T7785: Build a Phacility cluster service tier to sandbox Graphviz and Cowsay: Unknown Object (Differential Revision).
Sep 13 2015, 4:23 PM · Phacility, Phacility Support
epriestley edited the content of Roadmap.
Sep 13 2015, 3:18 PM
epriestley edited the content of Roadmap.
Sep 13 2015, 3:17 PM
epriestley edited the content of Changelog.
Sep 13 2015, 1:42 PM
epriestley created 2015 Week 37 (Early September).
Sep 13 2015, 1:42 PM
epriestley closed T9402: Unknown Objects as Resolved.

I suspect this is a "security researcher" manually editing the form to submit bogus values. We've had some activity on HackerOne recently which puts this project in various feeds there, and there are a large number of "security researchers" who do not read the program description at all before attempting to grab some quick cash by finding trivial XSS.

Sep 13 2015, 12:58 PM · Maniphest
epriestley closed T9407: Project list tag filtering as Wontfix.

We haven't seen other requests for this and don't plan to let projects be tagged with projects, which is what this amounts to.

Sep 13 2015, 12:35 PM
epriestley closed T9405: Project list hashtag filtering as Wontfix.

Project hashtags are unique, so only one project is ever related to a given hashtag.

Sep 13 2015, 12:18 PM · Projects
epriestley closed T9404: ( as Spite.
Sep 13 2015, 2:52 AM

Sep 12 2015

joshuaspence added projects to T9386: Embed search results in remarkup: Remarkup, Dashboards.
Sep 12 2015, 7:05 AM · Dashboards, Remarkup
joshuaspence added a comment to T9403: Different icons for task statuses.

I think it would still be reasonable to default wontfix and invalid to an X, but not fussed.

Sep 12 2015, 7:01 AM · Maniphest
joshuaspence added a comment to T9390: Show merged tasks.

+1 on this from me, but I agree that this is a duplicate of T8345.

Sep 12 2015, 6:59 AM · Maniphest
joshuaspence added a comment to T9403: Different icons for task statuses.

Wontfix also has a ticked checkbox.

Sep 12 2015, 5:02 AM · Maniphest
joshuaspence created T9403: Different icons for task statuses.
Sep 12 2015, 5:01 AM · Maniphest
joshuaspence created T9402: Unknown Objects.
Sep 12 2015, 2:50 AM · Maniphest
joshuaspence placed T9400: Running unit tests asynchronously when using `arc diff` up for grabs.
Sep 12 2015, 1:06 AM · Unit, Arcanist
joshuaspence closed T9401: inspect as Invalid.
Sep 12 2015, 1:05 AM

Sep 11 2015

joshuaspence added a project to T9400: Running unit tests asynchronously when using `arc diff`: Unit.
Sep 11 2015, 11:32 PM · Unit, Arcanist
epriestley added a comment to T7673: Make "Log Out" on Phacility instances behave in a way better aligned with user expectation.

Specifically, to completely log out of Phacility, you must currently:

Sep 11 2015, 5:51 PM · Auth, Phacility
epriestley closed T9397: IDOR as Spite.
Sep 11 2015, 5:08 PM
epriestley closed T9396: Test as Spite.
Sep 11 2015, 5:01 PM
epriestley placed T9391: arc diff: relax handling of submodule diffs in working copy up for grabs.
Sep 11 2015, 5:01 PM · Arcanist
epriestley added a comment to T7148: Allow users to export their data from Phacility.

This is getting fairly close to working locally but isn't going to make it into this week's release. I want to let the changes in connection with T9307 settle first, and am still unsatisfied with the permission model (currently: anyone who can exit the instance can perform exports) because this capability represents a huge increase in power over any other capability.

Sep 11 2015, 3:01 PM · Phacility
epriestley added a comment to T9395: harbormaster.sendmessage does not update build status for the same build target..

Broadly, this behavior is expected.

Sep 11 2015, 1:36 PM · Harbormaster, Conduit
epriestley added a comment to T9395: harbormaster.sendmessage does not update build status for the same build target..

Is Jenkins restarting the build automatically, or is a human going into Jenkins and clicking "restart"?

Sep 11 2015, 1:13 PM · Harbormaster, Conduit
revi awarded T4768: Phabricator silently overwrites concurrent changes (no conflict detection) a The World Burns token.
Sep 11 2015, 12:53 PM · Restricted Project, ApplicationEditor, Wikimedia, Maniphest, Phriction
epriestley closed T9394: sdfgfdgh as Invalid.
Sep 11 2015, 11:17 AM · Android
epriestley added a comment to T4103: Implement "Role Profiles" to provide search, homepage and application defaults.

The "role" stuff is mostly just practical/technical: we have to do about 95% of the same work whether we end up with multiple configurable sets of defaults or a single set of defaults.

Sep 11 2015, 11:14 AM · Prioritized, Restricted Project, Restricted Project, Dashboards, Applications
epriestley added a comment to T7719: Impossible to submit "Done" inline comment state without adding a comment.

We should probably improve this behavior at some point, but it isn't entirely trivial, I'll likely do concurrently with T9132 anyway, and the current behavior is a little rough but doesn't seem too bad (it's inconsistent and needlessly indirect, but not technically incorrect).

Sep 11 2015, 4:02 AM · Restricted Project, Audit, Differential
epriestley added a comment to T8646: Provide more context for search results, particularly wiki documents.

D14097 reverts this because it felt really bad in production, and generally not very promising as a direction we could iterate on and make successful.

Sep 11 2015, 4:00 AM · Design, Search, Restricted Project
epriestley added a comment to T9161: How can we fix "too much mail"?.

For whatever it's worth, here are the comparable (14-day) numbers from this install with the more modern script:

Sep 11 2015, 3:53 AM · Restricted Project, User Preferences, Mail
epriestley added a comment to T8646: Provide more context for search results, particularly wiki documents.

How about we:

Sep 11 2015, 3:33 AM · Design, Search, Restricted Project
epriestley added a comment to T9126: diffusion history page should give browse links for each committed version of the file.

D14096 has some screenshots of this and I've pushed it to this server. It may get some design followup but feels relatively reasonable to me in its current form.

Sep 11 2015, 3:23 AM · Prioritized, Diffusion, Restricted Project
epriestley added a comment to T6118: Support for Mercurial extensions in hosted repositories.

T9393 discusses the "Blackbox" extension. To summarize:

Sep 11 2015, 3:21 AM · Mercurial, Diffusion
epriestley closed T9393: Importing Mercurial repo with blackbox extension enabled results in non-completing import and erroneneous revision as Wontfix.

Cool, that sounds reasonable. Broadly:

Sep 11 2015, 3:18 AM · Mercurial, Diffusion
epriestley added a comment to T8646: Provide more context for search results, particularly wiki documents.

Here's a case where the result feels OK, especially if I'm a new user:

Sep 11 2015, 3:13 AM · Design, Search, Restricted Project
epriestley added a comment to T8646: Provide more context for search results, particularly wiki documents.

On real data, this feels very bloated to me for tasks, at least:

Sep 11 2015, 3:12 AM · Design, Search, Restricted Project
epriestley added a comment to T9393: Importing Mercurial repo with blackbox extension enabled results in non-completing import and erroneneous revision.

Can you just disable the extension for Phabricator's copy of the repository?

Sep 11 2015, 3:01 AM · Mercurial, Diffusion
epriestley added a comment to T9393: Importing Mercurial repo with blackbox extension enabled results in non-completing import and erroneneous revision.

The erroneous revision is because when hg log is invoked with --debug, it prints arbitrary messages to stdout which we can not distinguish from log output.

Sep 11 2015, 2:58 AM · Mercurial, Diffusion
epriestley added a comment to T9393: Importing Mercurial repo with blackbox extension enabled results in non-completing import and erroneneous revision.

Why are you interested in running this extension?

Sep 11 2015, 2:50 AM · Mercurial, Diffusion
epriestley closed T9126: diffusion history page should give browse links for each committed version of the file as Resolved by committing Restricted Diffusion Commit.
Sep 11 2015, 2:28 AM · Prioritized, Diffusion, Restricted Project
epriestley added a comment to T8646: Provide more context for search results, particularly wiki documents.

This doesn't feel completely solid to us yet so we're going to try it out for a bit and see if there are further adjustments to make. We're interested in feedback on this version of the feature if anyone has a particularly positive or negative experience with it. I'll push it to this install shortly so it's available to play around with.

Sep 11 2015, 2:11 AM · Design, Search, Restricted Project
epriestley moved T8572: Prompt for incomplete/unsaved inline comments upon creating a new comment instead of doing nothing from Backlog to The Queue on the Prioritized board.
Sep 11 2015, 2:05 AM · Prioritized, Differential, Restricted Project
epriestley moved T8646: Provide more context for search results, particularly wiki documents from Backlog to Paused on the Prioritized board.
Sep 11 2015, 2:05 AM · Design, Search, Restricted Project
epriestley moved T9126: diffusion history page should give browse links for each committed version of the file from Backlog to The Queue on the Prioritized board.
Sep 11 2015, 2:05 AM · Prioritized, Diffusion, Restricted Project
epriestley claimed T9126: diffusion history page should give browse links for each committed version of the file.
Sep 11 2015, 2:04 AM · Prioritized, Diffusion, Restricted Project
epriestley added a revision to T9126: diffusion history page should give browse links for each committed version of the file: Unknown Object (Differential Revision).
Sep 11 2015, 1:23 AM · Prioritized, Diffusion, Restricted Project

Sep 10 2015

epriestley closed T9351: Add CustomField support to Owners as Resolved by committing Restricted Diffusion Commit.
Sep 10 2015, 8:32 PM · Custom Fields, Prioritized, Owners
epriestley closed T9351: Add CustomField support to Owners, a subtask of T9352: Write some custom Herald glue for driving builds through Owners, as Resolved.
Sep 10 2015, 8:32 PM · Harbormaster, Herald, Owners, Prioritized
epriestley created T9392: Paging UI is missing some padding for Diffusion history view.
Sep 10 2015, 7:30 PM · Design, Diffusion
epriestley added a comment to T8646: Provide more context for search results, particularly wiki documents.

See that diff for some details, here's what it looks like currently:

Sep 10 2015, 6:45 PM · Design, Search, Restricted Project
epriestley added a comment to T8646: Provide more context for search results, particularly wiki documents.

D14095 is a rough pass at this. I'm summarizing (showing the first ~paragraph of content) rather than showing contextual content around body search results. This is easier and maybe-better, given that our search results are more highly structured than webpages? I'm not sure if this holds up in practice.

Sep 10 2015, 6:44 PM · Design, Search, Restricted Project
epriestley claimed T8646: Provide more context for search results, particularly wiki documents.
Sep 10 2015, 6:42 PM · Design, Search, Restricted Project
epriestley added a revision to T8646: Provide more context for search results, particularly wiki documents: Unknown Object (Differential Revision).
Sep 10 2015, 6:42 PM · Design, Search, Restricted Project
epriestley closed T8572: Prompt for incomplete/unsaved inline comments upon creating a new comment instead of doing nothing as Resolved by committing Restricted Diffusion Commit.
Sep 10 2015, 6:36 PM · Prioritized, Differential, Restricted Project
epriestley claimed T8572: Prompt for incomplete/unsaved inline comments upon creating a new comment instead of doing nothing.
Sep 10 2015, 6:19 PM · Prioritized, Differential, Restricted Project
epriestley added a revision to T8572: Prompt for incomplete/unsaved inline comments upon creating a new comment instead of doing nothing: Unknown Object (Differential Revision).
Sep 10 2015, 6:19 PM · Prioritized, Differential, Restricted Project
epriestley added a revision to T9351: Add CustomField support to Owners: Unknown Object (Differential Revision).
Sep 10 2015, 5:57 PM · Custom Fields, Prioritized, Owners
thoughtpolice awarded T9123: Build Phabricator in Harbormaster (v2) a Yellow Medal token.
Sep 10 2015, 2:22 PM · Prioritized, Harbormaster
epriestley closed T9389: test as Invalid.
Sep 10 2015, 2:09 PM
epriestley added a project to T9388: Convert Phame to ApplicationSearch: ApplicationSearch.
Sep 10 2015, 1:05 PM · ApplicationSearch, Dashboards, Phame
epriestley renamed T9388: Convert Phame to ApplicationSearch from Phame query link from within Dashboard panel is broken to Convert Phame to ApplicationSearch.
Sep 10 2015, 1:04 PM · ApplicationSearch, Dashboards, Phame
epriestley closed T7959: Mercurial doesn't store HTTP passwords in config anymore as Resolved.

This should be resolved by D14092. Thanks for the fix!

Sep 10 2015, 12:44 PM · Diffusion, Mercurial
epriestley added a revision to T7959: Mercurial doesn't store HTTP passwords in config anymore: Unknown Object (Differential Revision).
Sep 10 2015, 12:42 PM · Diffusion, Mercurial
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Sep 10 2015, 12:40 PM
epriestley added a comment to T7959: Mercurial doesn't store HTTP passwords in config anymore.

@berenm suggests what is likely a simpler fix here:

Sep 10 2015, 12:30 PM · Diffusion, Mercurial
epriestley updated subscribers of T7959: Mercurial doesn't store HTTP passwords in config anymore.
Sep 10 2015, 12:27 PM · Diffusion, Mercurial
epriestley merged task T9387: Diffusion is unable to pull updates from a Mercurial repository with HTTP authentication into T7959: Mercurial doesn't store HTTP passwords in config anymore.
Sep 10 2015, 12:27 PM · Diffusion, Mercurial
epriestley added a comment to T6162: Add an "Email and unread notification" option in user's Email Preferences.

See also T7004, although I'm generally not hopeful about being able to build a version of that which feels like it works well.

Sep 10 2015, 12:18 PM · Notifications, llvm, Restricted Project, Mail
epriestley added a comment to T9382: PhabricatorTaskmasterDaemon getting into MySQL deadlocks when executing PhabricatorApplicationTransactionPublishWorker tasks.

What if we do this?

Sep 10 2015, 12:10 PM · Daemons
epriestley added a comment to T9382: PhabricatorTaskmasterDaemon getting into MySQL deadlocks when executing PhabricatorApplicationTransactionPublishWorker tasks.

I get some odd results locally, in MySQL too, although I have a very small table on my laptop (~1100 rows):

Sep 10 2015, 12:07 PM · Daemons
epriestley added a comment to T9383: Support `git notes`.

No.

Sep 10 2015, 12:04 PM · KDE, Git, Diffusion
epriestley added a comment to T9382: PhabricatorTaskmasterDaemon getting into MySQL deadlocks when executing PhabricatorApplicationTransactionPublishWorker tasks.

The fact that it's not using the key at all explains why the GC was slow for you and why removing the ORDER BY improved performance, at least, but it seems like it should be able to use the key to execute this query efficiently, and appears to do so in MySQL (we don't have as much data as you do, but I don't recall the GC having any issues when we pushed this change here, and other large installs haven't reported issues but I'd expect them to if the GC was not able to use the key).

Sep 10 2015, 11:56 AM · Daemons
epriestley added a comment to T9382: PhabricatorTaskmasterDaemon getting into MySQL deadlocks when executing PhabricatorApplicationTransactionPublishWorker tasks.

I'm tentatively inclined to think that this is a bug in Percona, since:

Sep 10 2015, 11:52 AM · Daemons
epriestley added a comment to T9382: PhabricatorTaskmasterDaemon getting into MySQL deadlocks when executing PhabricatorApplicationTransactionPublishWorker tasks.

Yuck. Can you come up with any query where it uses the key? What if we do something really dumb like this to try to trick it?

Sep 10 2015, 11:44 AM · Daemons
epriestley added a comment to T9382: PhabricatorTaskmasterDaemon getting into MySQL deadlocks when executing PhabricatorApplicationTransactionPublishWorker tasks.

Out of curiosity, what's the query plan for this (DESC instead of ASC)?

Sep 10 2015, 11:40 AM · Daemons
epriestley added a comment to T9382: PhabricatorTaskmasterDaemon getting into MySQL deadlocks when executing PhabricatorApplicationTransactionPublishWorker tasks.

Hmm, that's surprising. At least on our dataset, I get a worse-looking query plan without the ORDER BY:

Sep 10 2015, 11:36 AM · Daemons
epriestley added a subtask for T6162: Add an "Email and unread notification" option in user's Email Preferences: T9161: How can we fix "too much mail"?.
Sep 10 2015, 11:08 AM · Notifications, llvm, Restricted Project, Mail
epriestley added a parent task for T9161: How can we fix "too much mail"?: T6162: Add an "Email and unread notification" option in user's Email Preferences.
Sep 10 2015, 11:08 AM · Restricted Project, User Preferences, Mail
epriestley updated subscribers of T6162: Add an "Email and unread notification" option in user's Email Preferences.
Sep 10 2015, 11:08 AM · Notifications, llvm, Restricted Project, Mail
epriestley merged task T9384: New Email Preference "Email + Notify" into T6162: Add an "Email and unread notification" option in user's Email Preferences.
Sep 10 2015, 11:08 AM · User Preferences, Notifications
epriestley added a comment to T9383: Support `git notes`.

We do not currently support git notes, and I had never heard of it before this task.

Sep 10 2015, 11:07 AM · KDE, Git, Diffusion
epriestley renamed T9383: Support `git notes` from Diffusion rejects git-notes objects to Support `git notes`.
Sep 10 2015, 11:07 AM · KDE, Git, Diffusion
epriestley added a comment to T9382: PhabricatorTaskmasterDaemon getting into MySQL deadlocks when executing PhabricatorApplicationTransactionPublishWorker tasks.

Yes, this looks consistent with the GC and publisher deadlocking.

Sep 10 2015, 11:03 AM · Daemons
epriestley added a comment to T7477: Handle inbound email with phabricator address in the CC.

That just looks like a bug that's only tangentially related, I think Audit and Countdown are both trying to receive mail at C... addresses.

Sep 10 2015, 10:49 AM · llvm, Restricted Project, Restricted Project, Mail
epriestley closed T9386: Embed search results in remarkup as Resolved.

Create a dashboard panel with the query, then embed it with {W...}.

Sep 10 2015, 10:45 AM · Dashboards, Remarkup
epriestley closed T9380: lint/unit failures cause confusing error message as Resolved by committing Restricted Diffusion Commit.
Sep 10 2015, 2:18 AM · Arcanist, Harbormaster, Restricted Project
epriestley added a revision to T9380: lint/unit failures cause confusing error message: Unknown Object (Differential Revision).
Sep 10 2015, 2:17 AM · Arcanist, Harbormaster, Restricted Project
epriestley closed T7304: Add CORS support to Conduit API as Wontfix.

I don't plan to pursue this. We'll offer JS access to the OAuth API instead (see T7303).

Sep 10 2015, 1:35 AM · Restricted Project, Conduit
epriestley added a comment to T9380: lint/unit failures cause confusing error message.

Maybe renaming "Arcanist Client Results to "arc lint + arc unit" would be clear enough? It sounds like this workflow is generally fine, users are just not making the connection between "Arcanist Client Results" and the "arc" client?

Sep 10 2015, 1:31 AM · Arcanist, Harbormaster, Restricted Project
epriestley added projects to T9380: lint/unit failures cause confusing error message: Harbormaster, Arcanist.
Sep 10 2015, 1:30 AM · Arcanist, Harbormaster, Restricted Project
epriestley added a comment to T9380: lint/unit failures cause confusing error message.

I don't see an especially clear way forward here:

Sep 10 2015, 1:30 AM · Arcanist, Harbormaster, Restricted Project
epriestley added a comment to T7477: Handle inbound email with phabricator address in the CC.

This is not blocked, although it's a moderate amount of work (4-6 hours?) and not adjacent to other work.

Sep 10 2015, 1:19 AM · llvm, Restricted Project, Restricted Project, Mail
epriestley added a comment to T8162: Option to disable "Generate Keypair".

This is 1-2 hours of work and can be slipped in somewhere if approved.

Sep 10 2015, 1:18 AM · Restricted Project, Passphrase, Auth
epriestley added a comment to T8172: "Edit" button shouldn't be hidden in "Actions".

We can look at this as part of the next Phriction iteration, although other changes likely impact the eventual design here.

Sep 10 2015, 1:17 AM · FreeBSD, Restricted Project, Phriction
epriestley moved T6502: Policy to define who can move cards in a workboard from Backlog to Projects v3 on the Projects board.
Sep 10 2015, 12:59 AM · Projects, Wikimedia, Policy, Workboards
epriestley added a project to T6502: Policy to define who can move cards in a workboard: Projects.
Sep 10 2015, 12:59 AM · Projects, Wikimedia, Policy, Workboards