| aik099 | |
| Apr 1 2015, 12:11 PM |
| F787229: Screen Shot 2015-09-09 at 5.29.29 PM.png | |
| Sep 10 2015, 12:31 AM |
Steps to reproduce:
Right now nothing happens because comment text is empty. Instead the transaction for marking inline comments Done/Undone should be created regardless of:
| Status | Assigned | Task | ||
|---|---|---|---|---|
| Restricted Maniphest Task | ||||
| Resolved | epriestley | T1315 Phacility Launch Status | ||
| Resolved | epriestley | T2795 Phacility (Mid Priority) | ||
| Resolved | chad | T2637 Unbeta Pholio | ||
| Restricted Maniphest Task | ||||
| Resolved | epriestley | T5644 Add controls to prevent `pygmentize` from saturating system resources | ||
| Resolved | epriestley | T5179 Unearth Differential rendering technical debt | ||
| Duplicate | epriestley | T5654 Show more context for inline comments in Differential timeline | ||
| Wontfix | epriestley | T5742 Add commentor column to "Revision Update History" table | ||
| Restricted Maniphest Task | ||||
| Resolved | epriestley | T7358 When Replying to an Inline Comment, provide original context in email? | ||
| Resolved | epriestley | T1460 Add "Done" link to an inline comment | ||
| Resolved | angie | T7719 Impossible to submit "Done" inline comment state without adding a comment |
Come across this issue and thought the functionality was broken. Should be able to mark done without any comment required.
At HEAD, I get this:
Clicking "Apply Remaining Actions" marks the inline as done. This behavior isn't great, but also isn't "Impossible". Am I doing something wrong (or, uh, not doing something wrong, I guess?)
We should probably improve this behavior at some point, but it isn't entirely trivial, I'll likely do concurrently with T9132 anyway, and the current behavior is a little rough but doesn't seem too bad (it's inconsistent and needlessly indirect, but not technically incorrect).